Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <132d5dc1-6104-1d2e-543a-e92177b01fae@nvidia.com>
Date:   Thu, 27 Jul 2023 14:57:39 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.13.0
Subject: Re: [PATCH] hte: Explicitly include correct DT includes
To:     Rob Herring <robh@kernel.org>,
        Thierry Reding <thierry.reding@gmail.com>,
        Jonathan Hunter <jonathanh@nvidia.com>
Cc:     devicetree@vger.kernel.org, timestamp@lists.linux.dev,
        linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20230714174600.4057041-1-robh@kernel.org>
Content-Language: en-US
From:   Dipen Patel <dipenp@nvidia.com>
In-Reply-To: <20230714174600.4057041-1-robh@kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YXdDTC9LR3FzYUVZQ2RnZUZsNlBCWGJoL1U5ZjNUVG5PMUUzU2VOeWdodXN1?=
 =?utf-8?B?YlBFc0JVYW5FSHNzcWNYVDB6TEMyenpwM1E4eEpubDBHbk9JL2pBOWh5MmE0?=
 =?utf-8?B?STNSOGhwY2g2OUZlU2plaHAzWGgzeUxsczNiOXNlaWNKNTNwNmN3TnJzUFhn?=
 =?utf-8?B?emJNcUVzVE8zZ2pKNVFZR0JuR2VUSVVUcnlJcW5FL0JRRzBwekFydi9hMEtZ?=
 =?utf-8?B?bDNCQWpwQTg3L09sc1llZnNVVEtlcjNMSUR5RjVrYXFsRkx3YUlxVzFtR2N5?=
 =?utf-8?B?Rzk0eXZkc1BGZGhzVm55RWVhV2lkbm1FNFREKzYxb2pYV2pzb2M4dHFJWWF0?=
 =?utf-8?B?ejhkaklIdTNEdm5xb1l2eUZoNlYxREdFeUUvTnJleENuTmY2UTlGb0RNSUZB?=
 =?utf-8?B?RlNhWmZ4T0dHejMyMUgrbmxkQjdBTU9SZzRXVy9qaVNnckNabitCQVlPd3pN?=
 =?utf-8?B?S1dMZW5GNmI0YWt2M202QTl0OVQzaGY2Ym5WT0RrSzlOcVJYM0hDLzZRWndC?=
 =?utf-8?B?YUNSa0hObGRUTERtVHQ4QXI1M0V1VVJIalhCQTdEWmFoeit4MlNyQ3RDSGh2?=
 =?utf-8?B?MDJuREdXNFBzZTNiaUYrWWdIV1FiU2Y0elBZSmNRSFArNExXUzQ1eGFKNjZt?=
 =?utf-8?B?RmtXdmlpMGFGRkxIOTloL2YzcU9ZSWxIbm1FUW0rd0NwMHVtZWMxNzRtbFhn?=
 =?utf-8?B?MlBGZHBUOEFDWEpSaVhSQ2RKd25LNE9NVEdRbXZHaUV3QlJnTHoxbFZRaUs4?=
 =?utf-8?B?b2Zkckh2Z1J1SlF0ZzhUM0hWeFlCSi9hYmdBYjYxS3JLWHdBeHhrTE4yVjY3?=
 =?utf-8?B?eCt6SG9LL0pqZlJJVUwzR0ZCMitnNWV0WmpnRWtlcnNnTzFBSjh3QUtOTHRN?=
 =?utf-8?B?QXRuRUI1bDNJSGUycE1Pd0JNU2RvR0xoTGd4RFdEUlhmak90OHFiWU1TcXQx?=
 =?utf-8?B?RkxNUkxUQm9jNVA5aDJmb0pXUEYrNkZqZHJDb216djNFeGZKaEpaMEthN1dj?=
 =?utf-8?B?ZWpMTTVMZFZaV2lIMTF0SHJoU1RrYnArVzVSc3lZaDZQb2toVERKbUtUZm95?=
 =?utf-8?B?WG9COFZJQnpwZnd1UUoybXpwYVUrc3BGbVZwd2xvTzhhWll2Qll0Ry92N0xa?=
 =?utf-8?B?ZFVKQXRacUhwNEN4RXhoeFJEWGxodWRKU0tCK2NtekZSV0N5RjU5Qnp3R1Ny?=
 =?utf-8?B?SmpQVkptcjFZRWdGKzN6cXhGNklyd1VOZjRoOEszL0lURDRDVWtscU9rSmJ6?=
 =?utf-8?B?L2JXdXhVTlJDaWFuV2xnNXpQS2VPbHNWQWNzNW1MWnlmNXlWMmtSSm0zLzJM?=
 =?utf-8?B?eUsyU09qblJ3UXVMUllyeG5TdnBDWjc5WjFSZVJOWmpOdkM2ZmtTN2xmRnJN?=
 =?utf-8?B?bS9sbDdCaDlyUEZUV1BhNTg2M0JEakJ6NFRjdTlNTjZZd2JGbnlwRzlHaWdY?=
 =?utf-8?B?Tm9KVkQrU0hWMEEzRkZOVFpGRGFaTEcrZDRBakUwWGo2VlhtRkFRZmtWazU3?=
 =?utf-8?B?QmtsOE9USzV1V1RyZkhDSGxxb2VSemVsMDY2VUh3bFlMZS9KNWtBVjZ5RW5L?=
 =?utf-8?B?VjcwN1lKYm5jTG5Va2VMYTJWVWRUbVBpL3NNK2x1TTMzSnJYdzJqRnFmNy96?=
 =?utf-8?B?c1dxc0Fvbm43dndQT2x3akUzRUg1VjVQZjNtakdsd1JGMlFvUEQ1b01iQ1Bi?=
 =?utf-8?B?V0ZqRy9oVUV1WVkvS1drbW5MQWxjemJmbVkxRVAzOEh5SFhlQzM4d0l5RWpK?=
 =?utf-8?B?eEtPKzlmRzZZSUVBMGpzTzBCY0dXckl4QUxsZWRZWXdWVkdEZmRVV0M3WFFV?=
 =?utf-8?B?TG9xQi9iTk5VTURQMHhTOC9wTEptemxvWEs5SlVVdGJEcjRhYmsrclVtSFI5?=
 =?utf-8?B?UUYzb3hXZXFTUzVwenpYVlREMUo1MkhCUE90Y0xDMzlGQzB5WkVnUnQ5akxJ?=
 =?utf-8?B?d3J0ZWRrdTVYN3dKZ1Q1TnNOSVBnakQ3dWtzZ2xDWVZpQ1ErdW44VllHSGZi?=
 =?utf-8?B?STJqRnFEUmpUWWZxVUJHMVhoT1NJVkZvWGJJSVdORFJSN0oyZ0V5NFVpeVRO?=
 =?utf-8?B?NzB5akJvdkJ1K3czZXFuVlM1MEpwNEdBYXFWZXpUSmRwM0RCTHRrNVJXNFk4?=
 =?utf-8?Q?dcAa675oqCX8qW1PXYxA0qRU3?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 43701772-3e9c-428f-c01a-08db8eec80a1
X-MS-Exchange-CrossTenant-AuthSource: IA1PR12MB6604.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2023 21:57:42.7071
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SQanWyKcQB9hvvdiBc55mtv/32Shw5hxAhKIrWpY3jsEX2PhSz77m/hTCgaCQXe6TfOcr0DTeB4no28nmcs0mg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYXPR12MB9428
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 7/14/23 10:46 AM, Rob Herring wrote:
> The DT of_device.h and of_platform.h date back to the separate
> of_platform_bus_type before it as merged into the regular platform bus.
> As part of that merge prepping Arm DT support 13 years ago, they
> "temporarily" include each other. They also include platform_device.h
> and of.h. As a result, there's a pretty much random mix of those include
> files used throughout the tree. In order to detangle these headers and
> replace the implicit includes with struct declarations, users need to
> explicitly include the correct includes.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
>  drivers/hte/hte-tegra194.c | 1 -
>  drivers/hte/hte.c          | 2 +-
>  2 files changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/hte/hte-tegra194.c b/drivers/hte/hte-tegra194.c
> index 06ef349a2265..6fe6897047ac 100644
> --- a/drivers/hte/hte-tegra194.c
> +++ b/drivers/hte/hte-tegra194.c
> @@ -12,7 +12,6 @@
>  #include <linux/stat.h>
>  #include <linux/interrupt.h>
>  #include <linux/of.h>
> -#include <linux/of_device.h>
>  #include <linux/platform_device.h>
>  #include <linux/hte.h>
>  #include <linux/uaccess.h>
> diff --git a/drivers/hte/hte.c b/drivers/hte/hte.c
> index 67c15724ee78..598a716b7364 100644
> --- a/drivers/hte/hte.c
> +++ b/drivers/hte/hte.c
> @@ -10,12 +10,12 @@
>  #include <linux/err.h>
>  #include <linux/slab.h>
>  #include <linux/of.h>
> -#include <linux/of_device.h>
>  #include <linux/mutex.h>
>  #include <linux/uaccess.h>
>  #include <linux/hte.h>
>  #include <linux/delay.h>
>  #include <linux/debugfs.h>
> +#include <linux/device.h>
>  
>  #define HTE_TS_NAME_LEN		10
>  
Acked-by: Dipen Patel <dipenp@nvidia.com>