Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6ba4a23c-3b4b-eb7f-0ecb-3b7bf5c4406e@intel.com>
Date:   Thu, 27 Jul 2023 15:05:20 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH] x86/APM: drop the duplicate APM_MINOR_DEV macro
Content-Language: en-US
To:     Randy Dunlap <rdunlap@infradead.org>,
        <linux-kernel@vger.kernel.org>
CC:     Jiri Kosina <jikos@kernel.org>, <x86@kernel.org>
References: <20230726234910.14775-1-rdunlap@infradead.org>
 <c4410ce3-e38d-a935-0e5f-6773cdbfe11b@intel.com>
 <772ac95d-9eab-2090-245e-fcc40bd7a5da@infradead.org>
From:   Sohil Mehta <sohil.mehta@intel.com>
In-Reply-To: <772ac95d-9eab-2090-245e-fcc40bd7a5da@infradead.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RVF1MjZNNnBBdy9YSFB4ZkFXTHZWWFE5Ry83RUZ4L3MwaXRBcjhBdnZQa240?=
 =?utf-8?B?SWpFbDdocUlmRHBUaWxhS0x3N0hHWnJ5STdwQVhLSGhkZkIrdUNIZU8vQ1V4?=
 =?utf-8?B?eWdIVVk3R3BGQk0zL3JtSlFkVUVIMk5FcVp1VTdCM25KVXNJaHRVV3YycFM0?=
 =?utf-8?B?YUt1aHo5R2xmN0syWGFBZEZxMkZYNWV4MGJrNWlBVEwrMXlpOXJ2VGs4b2RB?=
 =?utf-8?B?ME9XclN0QTZBa2YyZ1FMVE5vcHFRZnpuMDBVNmNjUWlGd0FmeTlGeFJndmpE?=
 =?utf-8?B?dlJCNkZOUERHd0tuamJpSjZYRW05NG9FR3ovZjFCeFdqYTFmZmlSMTkwb21G?=
 =?utf-8?B?VnY5Y1JHbEZFWVc5bEoyRVRHLzZnYUltT3lYeVc0dVQzdmhGbEx0M2dBWS9j?=
 =?utf-8?B?c21Db3FGcUx5SVdLRG1JK0hDYXkzdjVCNzJ3RTNmY1BLWXE4SVIzdHdGR3Zu?=
 =?utf-8?B?WTFVQ3cxa0ZSanRzS2RhVkJRL3RDUVB2QkR4SWEvejR5cGExbG9FQXNOUU9k?=
 =?utf-8?B?L05QbjczdlFsakRKUHVwbWVqTmppVkVucTYxWEs5dEV1NGYrM2JqQWd1eHl4?=
 =?utf-8?B?Wk5nMXRPeXJPRlR6QU1DVU5Mdm5GZWV1UUZiWWZ5UGxRL1BVZ1lOd29OS1du?=
 =?utf-8?B?WjFMN1QzTHVnM1lXcktEY0FiVmxwVXVRMmdhSDg4QlozQWFFN1NNdFhUZFh2?=
 =?utf-8?B?UnNpaUhvRnVZdXhDRk5jVkg2NHZqdy9EekNLNENIMW9sNXJMNTRJT2dkTnRD?=
 =?utf-8?B?ekVpYmI0Y0c0bG9SdEozMm5lZW1pMVByMnNDV0grK3R4T3RyU0NoZndQVkov?=
 =?utf-8?B?RDBpSlJMTFYrWENXZ2FXR0VuVVBLSTdTcmxmRmN4V2I3cEtMckxKRUlSYXl6?=
 =?utf-8?B?QmFjZmwzSUhaNXdRSjVmb3FhNUw0cDY1VHBMQm9QNlZpeXA0QVVIUFRtWCs2?=
 =?utf-8?B?aDBtRTN4Q3puMGtVTUFmQzBQZ2hqc01qVVd3TE9xUXRNd3VwT1JtZmpzZ1V1?=
 =?utf-8?B?MWZzSGJkUG5ESzdVWUxMTVNzdUtoS0sxR2V4WDdYTG1NYUhUUzlLZFNiSVVY?=
 =?utf-8?B?ZFliNUJyRXkyY3doUmNhQ0k2ck5IWHREbGpwL2ppK1FxS0pSS0hqTGhwRWpL?=
 =?utf-8?B?QUhsM0xIcyszS1lZZkdqUS81TkxLdGhNbS92Z29abllZcUFTMkJRMWc5dlFX?=
 =?utf-8?B?eHpJSXdTV2dtTzJqYzJCYzVFVzkwVGVjLzM4S3pSaVRGY0ZHTDNYMDgrUkZx?=
 =?utf-8?B?ZDl2SVY4ZGtnM1A2VEd4aFc0d05seVQ3dVdvWWltd2Jrcng4SUN2dk1DR1RG?=
 =?utf-8?B?bDdkdmRSNzY1Z0MvaUVtRWRMQ1FRS05MTUtQVHhEY21IeEs5K0FxQTFzdU00?=
 =?utf-8?B?aWZSNzFkY2tvVXdFY0I5VkllZUlERGZPT1J6OXc3anU4RXJvT0tiNG01RnFV?=
 =?utf-8?B?Nnl6ckNBQzB1Z1JxRjJGUGJMNnNFWUpJUmV1NTlpZHBvVkNxcGNkRFE4a1pG?=
 =?utf-8?B?NnJjbVZNYXFRTTVGQndRbERjdGdTZkxoaFppSVRDL0FhemJBL3dIU1F0ZGoz?=
 =?utf-8?B?dkkwejMvSGpnU3hXRitMNDdNNjNKK2xyNUgzODQvczZxaERsVSt3MGlLSUhB?=
 =?utf-8?B?dUFJZ0lQblNaK0xmQnZFV1BDcjVvdEtzSHNvWEozMmdGcDF0bGNYa04vNHor?=
 =?utf-8?B?aXZ4TlNWazkxR2JHN2gvT1kwU1VaeHBYZ29tM09iQWNDYk1JamVWaDYzR0RY?=
 =?utf-8?B?RHExMjJnZklyakZzeU1hZWRvTS9kamJmakljZzRUTm1PdlYrQ0hHQkVJTFNt?=
 =?utf-8?B?ZXpkeXZKL09vYUMzQlB6MEJiNXlDbmRtTnpZUUtRMUxHUkRaNFpXR1RSVlVJ?=
 =?utf-8?B?RndLcHE5bUNETDE1YUtndWdjVUZRZkswVllFbVk4aGFKT3ZmQXk5Mk92aHBB?=
 =?utf-8?B?djZSMzhQMzVLcUNZRE41REk3Q0tSUmZiZXhNc09IUlBURnd6YnFGMjZzVm43?=
 =?utf-8?B?YmNuUDRxR2NJQXBqUmszcU1ybkZRSXR0Tmc5aE5HUWQrc1JwWUdwYUNjcW5a?=
 =?utf-8?B?WTNXMnpsc0xBcm9hejZ5SjlXbXErRmtlTWpYMW1NN3NKUDQybm9IVlFYemdo?=
 =?utf-8?Q?LIEDRIBe+j1Z4MRlBbYjajQpD?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 83e6a137-32b7-4dc3-6d08-08db8eed9249
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3320.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2023 22:05:21.6742
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: b1OhlHVllvFV6lJ4O4ZS4MK3ad7XhVclChs9mlvXmCFSOZWX4yXJgcdA+XRf8vUg7/elqLRO2mDplKCzDSdUBQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR11MB7694
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 7/27/2023 2:21 PM, Randy Dunlap wrote:
> On 7/27/23 13:06, Sohil Mehta wrote:
>> I am not sure if a Fixes tag is really needed for a redundant macro
>> definition. If at all, shouldn't it be 874bcd00f520c ("apm-emulation:
>> move APM_MINOR_DEV to include/linux/miscdevice.h") ?
> 
> I don't see any need for this patch to be backported.
> 
> Should it be commit 874bcd00f520c?  Maybe. That one certainly
> missed moving this macro.
> 

Also, applying this patch anytime before 874bcd00f520c will cause a
compilation issue unless 874bcd00f520c is applied as well.

-Sohil