Received: by 2002:a05:6358:c692:b0:131:369:b2a3 with SMTP id fe18csp485717rwb; Thu, 27 Jul 2023 16:25:26 -0700 (PDT) X-Google-Smtp-Source: APBJJlEJoD0sLJtMLn11ZGxHIwoNSW6AAV3a1RfN6GhJNpeUPETSmR8FsxmJj3l3k3P0LyjppB2v X-Received: by 2002:a17:90b:2551:b0:268:5620:cfc7 with SMTP id nw17-20020a17090b255100b002685620cfc7mr1217pjb.30.1690500326228; Thu, 27 Jul 2023 16:25:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690500326; cv=none; d=google.com; s=arc-20160816; b=xxL7+P6lwAM1N0rS9S8UaCiB2zioxZIZO0R9jrV8U7RbnU4DOC+Msroi4dLxQHyQfI Enn2IWZrRBpZm07T5rH64nn3NeQSseYOkGYDcwwlKLLZHX9Ze4o+kZnw9gzJZAjlm2h6 4/yz469IYMlhs5xFHg6pb6Ae+MDb12sjYJLHjDndxZLyWyVPEIRQuK3+H+Nxgu7oAI6m 9a/Y7skjB5gt6qfWJBL9MkpX+g+fCa/V5SThkGN9OztypENHFZp/a+sR1R66lk/TqcBQ M8gG+si8FRX8bMKxHn+5HvsPZZ20ku3nLaEyaWswXy+rMNyPTOpmGt/BY+XOpwRNDnaL D02A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=n1VhVo0HogyRdDnZClaPFcVrNefiSsa2ShFGejri7zg=; fh=hG+2ty4feDY+2OZPqUnDncw9bDFHBUr9whTeCLGbtTI=; b=wRRzuGO8G/XECxWvLx52cNCXt4dLPrzk+S0uXGjWK5x+nDHA9wzR64mDwZV/H+f0iO 5EUPF2V2IKLNyi1g4jFPsGl7Jp8Z2+yP0coVPZr//khD4DrgSbEcoaabk59PrG5HLy0G B3c+fG7TzQC2et46hRUaSZgxE2EFmfodJUylO2ADP9zwFq9zBHffiMQcQdwBjENHlgE7 1LpCDbAi3dCmx13PBtPDBsjd7SwMxhxT0UaBjLzMTF/Ud3mNspYWJ1UEVSvvzDgjpbwS PTlyo6Gulpe0x7QtdvmCWtDujnoxxTLT/PjOdEMbBcCmdDiummb98E6u5diE7Am8MAE8 a8Vg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=XCl2rfQ6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b3-20020a170903228300b001b024322547si2006761plh.577.2023.07.27.16.25.13; Thu, 27 Jul 2023 16:25:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=XCl2rfQ6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233301AbjG0WfM (ORCPT + 99 others); Thu, 27 Jul 2023 18:35:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49384 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233064AbjG0Wes (ORCPT ); Thu, 27 Jul 2023 18:34:48 -0400 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F3B7F2D7B; Thu, 27 Jul 2023 15:34:26 -0700 (PDT) Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 36RMO8Ag013279; Thu, 27 Jul 2023 22:34:13 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=qcppdkim1; bh=n1VhVo0HogyRdDnZClaPFcVrNefiSsa2ShFGejri7zg=; b=XCl2rfQ6JodJD7gOwTevvDJEyzbpC3j7zDwpZdvVMSQdSf0tTiv0TRuX/QIylZevBqei TCUXCB2NtH6mv+evTPlNZHnjZHzfXfXLcDr5cugSzVTwKO3h3s6oj+KDgehCqP4aCOka 1gfotzpqIPTHwQycF6bAC0ZQAHt7Og2BCFeBXrnZczoabv68isdA4+QtiLyLYdt4rRCK bJ06dLFHJb7edGmK9z+oKCQk8srtyVnAWmufwX7Fk+4qWVTuVTBOJ/Pqlkp5LFpq++p5 tffeE55MlQzuTQvcg1z6QVCxZAg6mXaVyb1bZ5Cpq5E2W+ar6PnoliGOtZtfLtgJ7LJd 2w== Received: from nalasppmta04.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3s336t42ar-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 27 Jul 2023 22:34:13 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 36RMYCgM001948 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 27 Jul 2023 22:34:12 GMT Received: from hu-kriskura-hyd.qualcomm.com (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.30; Thu, 27 Jul 2023 15:34:06 -0700 From: Krishna Kurapati To: Thinh Nguyen , Greg Kroah-Hartman , Philipp Zabel , "Andy Gross" , Bjorn Andersson , "Konrad Dybcio" , Rob Herring , Krzysztof Kozlowski , Felipe Balbi , Wesley Cheng , Johan Hovold , Mathias Nyman CC: , , , , , , , , , Krishna Kurapati Subject: [PATCH v10 08/11] usb: dwc3: qcom: Add multiport suspend/resume support for wrapper Date: Fri, 28 Jul 2023 04:03:04 +0530 Message-ID: <20230727223307.8096-9-quic_kriskura@quicinc.com> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230727223307.8096-1-quic_kriskura@quicinc.com> References: <20230727223307.8096-1-quic_kriskura@quicinc.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: ZDPesW6l6HW4d7YVK7Hre0-MvHsr_KMw X-Proofpoint-GUID: ZDPesW6l6HW4d7YVK7Hre0-MvHsr_KMw X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-07-27_10,2023-07-26_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 spamscore=0 clxscore=1015 mlxlogscore=854 adultscore=0 lowpriorityscore=0 suspectscore=0 priorityscore=1501 bulkscore=0 impostorscore=0 mlxscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2306200000 definitions=main-2307270205 X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org QCOM SoC SA8295P's tertiary quad port controller supports 2 HS+SS ports and 2 HS only ports. Add support for configuring PWR_EVENT_IRQ's for all the ports during suspend/resume. Signed-off-by: Krishna Kurapati --- drivers/usb/dwc3/dwc3-qcom.c | 38 ++++++++++++++++++++++++++++++------ 1 file changed, 32 insertions(+), 6 deletions(-) diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers/usb/dwc3/dwc3-qcom.c index a98223291306..2db1472eed21 100644 --- a/drivers/usb/dwc3/dwc3-qcom.c +++ b/drivers/usb/dwc3/dwc3-qcom.c @@ -37,7 +37,11 @@ #define PIPE3_PHYSTATUS_SW BIT(3) #define PIPE_UTMI_CLK_DIS BIT(8) -#define PWR_EVNT_IRQ_STAT_REG 0x58 +#define PWR_EVNT_IRQ1_STAT_REG 0x58 +#define PWR_EVNT_IRQ2_STAT_REG 0x1dc +#define PWR_EVNT_IRQ3_STAT_REG 0x228 +#define PWR_EVNT_IRQ4_STAT_REG 0x238 + #define PWR_EVNT_LPM_IN_L2_MASK BIT(4) #define PWR_EVNT_LPM_OUT_L2_MASK BIT(5) @@ -121,6 +125,19 @@ enum dwc3_qcom_phy_irq_identifier { SS_PHY_IRQ, }; +/* + * SA8295 has 4 power event IRQ STAT registers to be checked + * during suspend resume. + */ +#define NUM_PWR_EVENT_STAT_REGS 4 + +static u32 pwr_evnt_irq_stat_reg_offset[NUM_PWR_EVENT_STAT_REGS] = { + PWR_EVNT_IRQ1_STAT_REG, + PWR_EVNT_IRQ2_STAT_REG, + PWR_EVNT_IRQ3_STAT_REG, + PWR_EVNT_IRQ4_STAT_REG, +}; + static inline void dwc3_qcom_setbits(void __iomem *base, u32 offset, u32 val) { u32 reg; @@ -455,15 +472,19 @@ static void dwc3_qcom_enable_interrupts(struct dwc3_qcom *qcom) static int dwc3_qcom_suspend(struct dwc3_qcom *qcom, bool wakeup) { + u8 num_ports; u32 val; int i, ret; if (qcom->is_suspended) return 0; - val = readl(qcom->qscratch_base + PWR_EVNT_IRQ_STAT_REG); - if (!(val & PWR_EVNT_LPM_IN_L2_MASK)) - dev_err(qcom->dev, "HS-PHY not in L2\n"); + num_ports = qcom->data->num_ports; + for (i = 0; i < num_ports; i++) { + val = readl(qcom->qscratch_base + pwr_evnt_irq_stat_reg_offset[i]); + if (!(val & PWR_EVNT_LPM_IN_L2_MASK)) + dev_err(qcom->dev, "HS-PHY not in L2\n"); + } for (i = qcom->num_clocks - 1; i >= 0; i--) clk_disable_unprepare(qcom->clks[i]); @@ -486,6 +507,7 @@ static int dwc3_qcom_suspend(struct dwc3_qcom *qcom, bool wakeup) static int dwc3_qcom_resume(struct dwc3_qcom *qcom, bool wakeup) { + u8 num_ports; int ret; int i; @@ -509,8 +531,12 @@ static int dwc3_qcom_resume(struct dwc3_qcom *qcom, bool wakeup) dev_warn(qcom->dev, "failed to enable interconnect: %d\n", ret); /* Clear existing events from PHY related to L2 in/out */ - dwc3_qcom_setbits(qcom->qscratch_base, PWR_EVNT_IRQ_STAT_REG, - PWR_EVNT_LPM_IN_L2_MASK | PWR_EVNT_LPM_OUT_L2_MASK); + num_ports = qcom->data->num_ports; + for (i = 0; i < num_ports; i++) { + dwc3_qcom_setbits(qcom->qscratch_base, + pwr_evnt_irq_stat_reg_offset[i], + PWR_EVNT_LPM_IN_L2_MASK | PWR_EVNT_LPM_OUT_L2_MASK); + } qcom->is_suspended = false; -- 2.40.0