Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 28 Jul 2023 00:27:24 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Justin Stitt <justinstitt@google.com>
Cc:     Cezary Rojewski <cezary.rojewski@intel.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
        Liam Girdwood <liam.r.girdwood@linux.intel.com>,
        Peter Ujfalusi <peter.ujfalusi@linux.intel.com>,
        Bard Liao <yung-chuan.liao@linux.intel.com>,
        Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
        Kai Vehmanen <kai.vehmanen@linux.intel.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        Kees Cook <keescook@chromium.org>,
        Nathan Chancellor <nathan@kernel.org>,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ASoC: Intel: Skylake: replace deprecated strncpy with
 strscpy
Message-ID: <f0f0ebe4-55fb-4861-a94c-77c82ec600c5@sirena.org.uk>
References: <20230726-asoc-intel-skylake-remove-deprecated-strncpy-v1-1-020e04184c7d@google.com>
 <20230727-asoc-intel-skylake-remove-deprecated-strncpy-v2-1-152830093921@google.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="fxdzMHT9nHAlz0DB"
Content-Disposition: inline
In-Reply-To: <20230727-asoc-intel-skylake-remove-deprecated-strncpy-v2-1-152830093921@google.com>
Precedence: bulk


--fxdzMHT9nHAlz0DB
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Jul 27, 2023 at 08:30:18PM +0000, Justin Stitt wrote:
> `strncpy` is deprecated for use on NUL-terminated destination strings [1].
>=20
> A suitable replacement is `strscpy` [2] due to the fact that it
> guarantees NUL-termination on its destination buffer argument which is
> _not_ the case for `strncpy`!

Please don't send new patches in reply to old patches or serieses, this
makes it harder for both people and tools to understand what is going
on - it can bury things in mailboxes and make it difficult to keep track
of what current patches are, both for the new patches and the old ones.

--fxdzMHT9nHAlz0DB
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmTC/VwACgkQJNaLcl1U
h9BKtQf+PU+B7WMVvB7nKGZnwnltRf1hOqO+ppLtmCXfk99XwgbXWOnUINT6wWH8
rqz+nkDW5ENnOOk1EVwQ1ZhlFbJjQhKa6GtrywDD3j69RP8MljzUJB9U1aqemxlM
g2ZbR9w+dkv1BR/tbYavi/OceU/0f4BOYEAMCv94GOEh55dCbXcJPVC+QU4zjORa
LY+hg4QCm9+h6KL8bwUpim02/gfJ94NugdogkyB31Ct/d87gH53GGnrJRU7x7nB2
UcDs6mPmCH9QSxupNP0S5Zy9VA5yl06ahKnW9YvFiEmRLQJ00An+Pam5Cjrwsfa/
3gihyIbKLSxc4IGD9kJDuCTDJuz2Gg==
=wnJm
-----END PGP SIGNATURE-----

--fxdzMHT9nHAlz0DB--