Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a510e9bd-ea17-dc43-9985-0c7fcec4b245@infradead.org>
Date:   Thu, 27 Jul 2023 17:58:47 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH] x86/APM: drop the duplicate APM_MINOR_DEV macro
Content-Language: en-US
From:   Randy Dunlap <rdunlap@infradead.org>
To:     Sohil Mehta <sohil.mehta@intel.com>, linux-kernel@vger.kernel.org
Cc:     Jiri Kosina <jikos@kernel.org>, x86@kernel.org
References: <20230726234910.14775-1-rdunlap@infradead.org>
 <c4410ce3-e38d-a935-0e5f-6773cdbfe11b@intel.com>
 <772ac95d-9eab-2090-245e-fcc40bd7a5da@infradead.org>
 <6ba4a23c-3b4b-eb7f-0ecb-3b7bf5c4406e@intel.com>
 <de55c767-1bc3-3bd5-84c3-1a636373f3b0@infradead.org>
In-Reply-To: <de55c767-1bc3-3bd5-84c3-1a636373f3b0@infradead.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 7/27/23 15:41, Randy Dunlap wrote:
> 
> 
> On 7/27/23 15:05, Sohil Mehta wrote:
>> On 7/27/2023 2:21 PM, Randy Dunlap wrote:
>>> On 7/27/23 13:06, Sohil Mehta wrote:
>>>> I am not sure if a Fixes tag is really needed for a redundant macro
>>>> definition. If at all, shouldn't it be 874bcd00f520c ("apm-emulation:
>>>> move APM_MINOR_DEV to include/linux/miscdevice.h") ?
>>>
>>> I don't see any need for this patch to be backported.
>>>
>>> Should it be commit 874bcd00f520c?  Maybe. That one certainly
>>> missed moving this macro.
>>>
>>
>> Also, applying this patch anytime before 874bcd00f520c will cause a
>> compilation issue unless 874bcd00f520c is applied as well.
> 
> Yeah, that's a good point. Thanks.
> 

I'll send a v2 with the Fixes: tag changed.
Thanks.

-- 
~Randy