Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230725130709.58207-1-gavinl@nvidia.com> <20230725130709.58207-3-gavinl@nvidia.com>
 <f5823996fffad2f3c1862917772c182df74c74e7.camel@redhat.com>
In-Reply-To: <f5823996fffad2f3c1862917772c182df74c74e7.camel@redhat.com>
From:   Jason Wang <jasowang@redhat.com>
Date:   Fri, 28 Jul 2023 09:42:00 +0800
Message-ID: <CACGkMEs4wUh0TydcXSMR2GdBSTk+H-Tkbhn53BywEeiK9cA9Gg@mail.gmail.com>
Subject: Re: [PATCH net-next V4 2/3] virtio_net: support per queue interrupt
 coalesce command
To:     Paolo Abeni <pabeni@redhat.com>
Cc:     Gavin Li <gavinl@nvidia.com>, mst@redhat.com,
        xuanzhuo@linux.alibaba.com, davem@davemloft.net,
        edumazet@google.com, kuba@kernel.org, ast@kernel.org,
        daniel@iogearbox.net, hawk@kernel.org, john.fastabend@gmail.com,
        jiri@nvidia.com, dtatulea@nvidia.com, gavi@nvidia.com,
        virtualization@lists.linux-foundation.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, bpf@vger.kernel.org,
        Heng Qi <hengqi@linux.alibaba.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Jul 27, 2023 at 9:28=E2=80=AFPM Paolo Abeni <pabeni@redhat.com> wro=
te:
>
> On Tue, 2023-07-25 at 16:07 +0300, Gavin Li wrote:
> > Add interrupt_coalesce config in send_queue and receive_queue to cache =
user
> > config.
> >
> > Send per virtqueue interrupt moderation config to underlying device in
> > order to have more efficient interrupt moderation and cpu utilization o=
f
> > guest VM.
> >
> > Additionally, address all the VQs when updating the global configuratio=
n,
> > as now the individual VQs configuration can diverge from the global
> > configuration.
> >
> > Signed-off-by: Gavin Li <gavinl@nvidia.com>
> > Reviewed-by: Dragos Tatulea <dtatulea@nvidia.com>
> > Reviewed-by: Jiri Pirko <jiri@nvidia.com>
> > Acked-by: Michael S. Tsirkin <mst@redhat.com>
>
> FTR, this patch is significantly different from the version previously
> acked/reviewed, I'm unsure if all the reviewers are ok with the new
> one.

Good point, and I plan to review this no later than next Monday and
offer my ack if necessary. Please hold this series now.

Thanks

>
> [...]
>
> >  static int virtnet_set_coalesce(struct net_device *dev,
> >                               struct ethtool_coalesce *ec,
> >                               struct kernel_ethtool_coalesce *kernel_co=
al,
> >                               struct netlink_ext_ack *extack)
> >  {
> >       struct virtnet_info *vi =3D netdev_priv(dev);
> > -     int ret, i, napi_weight;
> > +     int ret, queue_number, napi_weight;
> >       bool update_napi =3D false;
> >
> >       /* Can't change NAPI weight if the link is up */
> >       napi_weight =3D ec->tx_max_coalesced_frames ? NAPI_POLL_WEIGHT : =
0;
> > -     if (napi_weight ^ vi->sq[0].napi.weight) {
> > -             if (dev->flags & IFF_UP)
> > -                     return -EBUSY;
> > -             else
> > -                     update_napi =3D true;
> > +     for (queue_number =3D 0; queue_number < vi->max_queue_pairs; queu=
e_number++) {
> > +             ret =3D virtnet_should_update_vq_weight(dev->flags, napi_=
weight,
> > +                                                   vi->sq[queue_number=
].napi.weight,
> > +                                                   &update_napi);
> > +             if (ret)
> > +                     return ret;
> > +
> > +             if (update_napi) {
> > +                     /* All queues that belong to [queue_number, queue=
_count] will be
> > +                      * updated for the sake of simplicity, which migh=
t not be necessary
>
> It looks like the comment above still refers to the old code. Should
> be:
>         [queue_number, vi->max_queue_pairs]
>
> Otherwise LGTM, thanks!
>
> Paolo
>