Received: by 2002:a05:6358:c692:b0:131:369:b2a3 with SMTP id fe18csp711489rwb; Thu, 27 Jul 2023 21:16:44 -0700 (PDT) X-Google-Smtp-Source: APBJJlGdJz+pmFnDCD0PgbW2UfgdwfP8rbwk8RP7VFrkiXHb+dKXGSjg/EcG+7BcKbWbd5IdAdTE X-Received: by 2002:a05:6808:11c9:b0:3a3:ed22:5a4a with SMTP id p9-20020a05680811c900b003a3ed225a4amr1758184oiv.40.1690517804016; Thu, 27 Jul 2023 21:16:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690517803; cv=none; d=google.com; s=arc-20160816; b=02g/k4PsheK/Bv7DV9HK/Bsf0yBMFODfq6nWBT0iq+sDmxjfZMYPalKkAPAD1rPYKf KGgsxHZUYFz90X50bBQoYV1lWt1sEYlMozEgS8tovRYsBBBz0YXKEPjG/9Prqa6atYNC ZdcdRZwjAv2lhYldVRdL4ye4cQ16KGxK3f4w6X7O8IGdwtDtliwbalX5TS+G1a+fyUzV 9gRpjRL6o8e2DJAlAqqW/cU8XMnZB+UZVQ0IFzxMrkCdmnepmoWHiXaja4OY2DwUq17Z NIFsiFruqfCmkQDoBo6SDHcdz+mbGNbEHUwSMQZ0ORqAWIqM0GAIV7EFcA9ro4xL//TA CWvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=/ZVv652svSCo0L6bO/XsHs+canFT5Mf8LoxscdDUnqc=; fh=PoncN7pNcqwcbixWcdo3zqt13+EKPnVAnPQHd9mjtbw=; b=lwYqaiFPNlvPQ2hY9MJysvaXkuzrpV283pKBAt3w8fuWGw0qx2qZyAiMVoIQttGfsf CvXAk6qpJa7zxmWm8lFXAzkJ4uVZaGJIwrjY6scPXAaeysDPW4vw3a2DCAdGB/wokje/ UkzcH42RoRa1kDTdfN6kxdVNJVEx99ErVFjlD+2LBsufSsRXI9ZiFzFCkmnZJyE4ahCn Ggq5qOqEENNfGChhbK9y9L97MKroCgVw+lDpDZGCyrXrAAhTd8ZVl19woBJg067F4EJD LvEnvuCjRMxYtxsGNx/U/p/lr4r8ET0pJj7YQeUl5SdW0qaPZoKCjiDZsVG/28Wmmpc2 Ivpw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=RyKFWjVP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r15-20020a632b0f000000b00563dde13952si2307772pgr.720.2023.07.27.21.16.31; Thu, 27 Jul 2023 21:16:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=RyKFWjVP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232943AbjG1DbB (ORCPT + 99 others); Thu, 27 Jul 2023 23:31:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55690 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233141AbjG1Da5 (ORCPT ); Thu, 27 Jul 2023 23:30:57 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AD58C26BC; Thu, 27 Jul 2023 20:30:56 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2D7D461FBF; Fri, 28 Jul 2023 03:30:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D0A27C433C8; Fri, 28 Jul 2023 03:30:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690515055; bh=/ZVv652svSCo0L6bO/XsHs+canFT5Mf8LoxscdDUnqc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RyKFWjVP86xtA4FozPZ2U5JiD7AF3MszxVpvGbcNRSmy3FS/og8h7NYbSYC8GWboa +cei1IAbiIgG7PiRO7C3+lGeoY3/+cqcYYqkHcYAUGWxwLWjaptDT5PrFlu2me3wTv FwXRyLwGkPzFZEfYj1XYR4RIGHRWyNa7ndxW5vE6dTHYwjYBnZYOmcQAWpSFVOhbUv iJyrpWgo22a8uFtZFlITcFhAfYcFbYx+tNGhjKhduZvnTPAJcNiysh7HVfUdFFXMuy N3x4j7gQBjYnGUMgU4ZivPT7LhjhH1iOlJKupvYj5a3AhdmTYsN5ikhTSP1bvOlnK3 eR3C766TGnTng== Date: Thu, 27 Jul 2023 20:34:06 -0700 From: Bjorn Andersson To: Konrad Dybcio Cc: Andy Gross , Michael Turquette , Stephen Boyd , Mike Turquette , Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Stephen Boyd Subject: Re: [PATCH v2] clk: qcom: reset: Use the correct type of sleep/delay based on length Message-ID: References: <20230726-topic-qcom_reset-v2-1-4a6e1b1d0439@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230726-topic-qcom_reset-v2-1-4a6e1b1d0439@linaro.org> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 27, 2023 at 07:14:52PM +0200, Konrad Dybcio wrote: > Based on the length of the delay (see: [1]), use the correct sleep/delay > functions. I believe this comment was good in v1, but there's no mentioning of fsleep() in the referenced document. Now I have read the code and know better, real nice. Could you please improve the commit message to make obvious what I had to look at the code to understand, and to by-pass-educate readers of it? Thanks, Bjorn