Received: by 2002:a05:6358:c692:b0:131:369:b2a3 with SMTP id fe18csp750328rwb; Thu, 27 Jul 2023 22:11:09 -0700 (PDT) X-Google-Smtp-Source: APBJJlGhK3SxNFeMoQDle0otogFlgvN26Km8SsVLb/iaEGkuY2ZcvZ3ks18TrKu6+4N3uRGKgPFI X-Received: by 2002:a17:907:2716:b0:994:56db:cb8d with SMTP id w22-20020a170907271600b0099456dbcb8dmr1123145ejk.14.1690521068847; Thu, 27 Jul 2023 22:11:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690521068; cv=none; d=google.com; s=arc-20160816; b=VJdQv4Lgu942Bssj0pPM5sDG+R/Rh68MB1YpQlCbAGwp8OOgVon9a5sGs6CMpSRQca wPm867RU3kdH4Ze9TQ5uZHIHyPtMlBzw3qi4CE8Rh0J0e6OjkaHwo5K1x7zaGo87adu6 RTe5dO+TeLP+Lw3G2H+PQQ74RUc/ELgaLW/qkNBGCaOg505kI8Wfl8zdnz1ZKSlRmUEV Lq5jiENux1iH9coWWg87DiI4+TGtAEC7MI8Ztvc2Dxl4AEpocFDYXnYxd0joUaO/HRb2 KTMPWsKPLhaOLkOG3tVBM/qUI3CMZM80cQ52rl+6sSdaL96VRDFbZCpxjLWECvV8Z0Rt JZwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=He4/7ZjAaJYV3oY1Q5qsfXRQN2c+aw/i3Z8upeCFxZY=; fh=yA/ZzTR4GKgsZ5MlVb+VfscNDPdhmJZisz1UZ2ETSRg=; b=BYHtd6W21DURFXTx3CAnooPSSgO3PvjumiTtf/O4HgfWyHUd3EGtyYEtGQLsYtnvdk kzVG1YJwHYclquPW4pPJfSMz7+8TwCW6JFkYoRd3G9guhbfRpE8c53pH7FYmZrcnl5qZ 2AqS2fhDASoGcAc5CO7/iOim5ntsZDBLZS/wgn7Bn0kIb8OQWTXH9AteOqssjUIIkM+M FW1oPO296EruOFAQ7cFfyH0Uw8et8AYeUiS34SbLf92FsisQ3Td2NFlRGmplLwzTuJUa KapS5G6vAyk3J3WbLi0avgRrl7QeGhUGBD5o3QIOUybQO2qGG9zLv7TEnL07rvS+joFu ArFg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=UJJSmsvK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id gq15-20020a170906e24f00b0099212b34e82si2114749ejb.18.2023.07.27.22.10.44; Thu, 27 Jul 2023 22:11:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=UJJSmsvK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232604AbjG1Dxy (ORCPT + 99 others); Thu, 27 Jul 2023 23:53:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60936 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233216AbjG1Dxn (ORCPT ); Thu, 27 Jul 2023 23:53:43 -0400 Received: from mail-pf1-x42c.google.com (mail-pf1-x42c.google.com [IPv6:2607:f8b0:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5BB0E2D64 for ; Thu, 27 Jul 2023 20:53:42 -0700 (PDT) Received: by mail-pf1-x42c.google.com with SMTP id d2e1a72fcca58-686ed1d2594so1628284b3a.2 for ; Thu, 27 Jul 2023 20:53:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1690516422; x=1691121222; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=He4/7ZjAaJYV3oY1Q5qsfXRQN2c+aw/i3Z8upeCFxZY=; b=UJJSmsvKuA+7vHlEK5zqxwvD8B6Yt8XfXuAItoiHvAj3OoqGrALOYkCYQccCqOBd5Z tmtMhmnK6zN87HaVH9ygwQIQdC4SZMGydBwDwFW+ZmxwVd+Yinpn/4wGAvXFE++zJAos O2FXcKEu9fLVqrGMsoLKFn9LRJ/AlJZ69+Cpw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690516422; x=1691121222; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=He4/7ZjAaJYV3oY1Q5qsfXRQN2c+aw/i3Z8upeCFxZY=; b=S9bUCgh1DKwOStV1Zc4mTN/QRAqcrDfVMZy+T4/nJwMnVHQvB2kLNiUJcUqCDd+AS5 8MMK5WC4ogL87/q7Ny9MC7XpXqtq/ucuXDnhC51RLbHWNnQGtv18FEtxkYRxBWsorKMB FPA05e5iaChuo/nya87vkMyQHKERRAOf7bRukoAZTGb0hIzxVZPRm8t/cUPTgQYEySp8 b47kaENi5e6bMKmaN4/HtgGEwclsW3PD8z0tas6OUaWE7F8Xp64ZfHsYfyY5gisX0j1q rQMlNC2SS/WNgHgYlU3wjdTxhyb0KxfcLkaqb74akennZAJ7+BQknHyow19pCcAh0k2W ZomQ== X-Gm-Message-State: ABy/qLbA0PljGYOcrlcYboCxkiNepAOGA9Wb06/0Et20RG9IBAVa3kvY H1TU3pieTAb6rgUPkQKlshehow== X-Received: by 2002:a05:6a00:194f:b0:680:2b80:8479 with SMTP id s15-20020a056a00194f00b006802b808479mr868615pfk.19.1690516421816; Thu, 27 Jul 2023 20:53:41 -0700 (PDT) Received: from google.com ([2401:fa00:8f:203:9314:7aae:8542:aa2d]) by smtp.gmail.com with ESMTPSA id d26-20020aa78e5a000000b006870ff20242sm212301pfr.186.2023.07.27.20.53.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Jul 2023 20:53:41 -0700 (PDT) Date: Fri, 28 Jul 2023 12:53:36 +0900 From: Sergey Senozhatsky To: Andrew Yang Cc: Minchan Kim , Sergey Senozhatsky , Andrew Morton , Matthias Brugger , AngeloGioacchino Del Regno , Sebastian Andrzej Siewior , wsd_upstream@mediatek.com, casper.li@mediatek.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH v2] zsmalloc: Fix races between modifications of fullness and isolated Message-ID: <20230728035336.GL955071@google.com> References: <20230727062910.6337-1-andrew.yang@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230727062910.6337-1-andrew.yang@mediatek.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FSL_HELO_FAKE, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (23/07/27 14:29), Andrew Yang wrote: > > Since fullness and isolated share the same unsigned int, > modifications of them should be protected by the same lock. > > Signed-off-by: Andrew Yang > Fixes: c4549b871102 ("zsmalloc: remove zspage isolation for migration") Reviewed-by: Sergey Senozhatsky