Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Lu, Brent" <brent.lu@intel.com>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
CC:     "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
        "Rojewski, Cezary" <cezary.rojewski@intel.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
        Liam Girdwood <liam.r.girdwood@linux.intel.com>,
        Peter Ujfalusi <peter.ujfalusi@linux.intel.com>,
        Bard Liao <yung-chuan.liao@linux.intel.com>,
        Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
        Kai Vehmanen <kai.vehmanen@linux.intel.com>,
        Mark Brown <broonie@kernel.org>,
        "Jaroslav Kysela" <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Ajye Huang <ajye_huang@compal.corp-partner.google.com>,
        "Zhi, Yong" <yong.zhi@intel.com>,
        Terry Cheong <htcheong@chromium.org>,
        "Bhat, Uday M" <uday.m.bhat@intel.com>,
        "Chiang, Mac" <mac.chiang@intel.com>,
        "R, Dharageswari" <dharageswari.r@intel.com>,
        Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
        ye xingchen <ye.xingchen@zte.com.cn>
Subject: RE: [PATCH v3 1/2] ASoC: Intel: maxim-common: get codec number from
 ACPI
Thread-Topic: [PATCH v3 1/2] ASoC: Intel: maxim-common: get codec number from
 ACPI
Thread-Index: AQHZwDUZO6mj1TKwEUKaGOiVkgw2Fq/NZsAAgAFLSmA=
Date:   Fri, 28 Jul 2023 06:10:44 +0000
Message-ID: <CY5PR11MB62573C5E84F29D3B211492889706A@CY5PR11MB6257.namprd11.prod.outlook.com>
References: <20230727104354.2344418-1-brent.lu@intel.com>
 <20230727104354.2344418-2-brent.lu@intel.com>
 <ZMJESOsmm/0ta+Nc@smile.fi.intel.com>
In-Reply-To: <ZMJESOsmm/0ta+Nc@smile.fi.intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?TcOYV3u8Kg9oYzNfJDNpA43npHlWZEN+29tgCDEnCec6VLglp2ME8YDmeSyN?=
 =?us-ascii?Q?mA91EgK1EPT8Ie3mScd747cw7nkKJWTCSdr6xs40VRGRIburc956OlzLHI1G?=
 =?us-ascii?Q?z9utPsu83ZUSjzC8WukP9PZUyYTo/iQJB8Fl+HsiRhDWmKfMUrwkbWKUp/oG?=
 =?us-ascii?Q?eYzXtsR5IuvmvNmFkwBV87aOFtGkd+3/y82y0LNtZlp8gX1NMYVMXwxjC+kz?=
 =?us-ascii?Q?AvjNDh9GCQg72jxncVN+1vwkJhSg2PvZ9ugQ99I50WJJ8vKBqLSP8qysLE/C?=
 =?us-ascii?Q?rgyWxrwiG4joy8OKn3veMR32pBHgU5LwgtwORKkRl6+g3pViRFB5M9OM2wh0?=
 =?us-ascii?Q?JVjTbR4tqfF3Sao0x55atLGydYfAwOKg5agVCmbD4L8x/M2Fy6mIEcTIak4E?=
 =?us-ascii?Q?H+o+GbBfrbqFudm3JjFvep+JglTtd/gabaAWYf9YzzDGFVySN5VeKBosp7+u?=
 =?us-ascii?Q?LbC6BBGU1cKWzh67CBvMitb6LkJSB8IFEOuTK44XV9Cq+NCLdkm7dnbNiCvx?=
 =?us-ascii?Q?KnrNVzBCljHSmiLh0zRbsbl0ZETzaSZ+lzYw9szebeYFUnwqcd9Q5JpT5vlR?=
 =?us-ascii?Q?ALGdmcqAAku5qdkKgCrhiIeajv+jVUcdswqaOk2OJyxWCyYSu2Kl//6Z3mSM?=
 =?us-ascii?Q?XF72Aulc5SwydxK7ucTLUftx8U61aaPOZKHUyqlTm3n8RKbp4zOxkYHZS91E?=
 =?us-ascii?Q?vu+nPqdFj6dh0ZR7I6HZBBD7WicGnH9u1EDvjaAZeIcsDqvlasBi0qM9xwov?=
 =?us-ascii?Q?Pbc/bO8QHc1QKdtcVSs1MkR4xVx9YzTCldTsFKdrrQJrAPWga1k+eFv6q593?=
 =?us-ascii?Q?Z0RPMKadU+Io8m7PEBXTLBRdxvbmay1+FOj39IgmvR5XxeJ5ZvKlG/vxFHXO?=
 =?us-ascii?Q?hiDFyBhRr6pESMbBEuUiJEZ91Qag8Mt41Jqj9Pt6CQpb6/Vmxq3wFVp3RbGT?=
 =?us-ascii?Q?F7AXzlsMsRGtXy8SQHVhfZYt2fkNwlw9ARMzIKafp/qZ23g/WxovwYIzitxC?=
 =?us-ascii?Q?0dk5zRjfZbMK3FM/8YAk5H10hNUBR3qisSiMhDr/ZEw6kY0A7ytdbbAbvMvz?=
 =?us-ascii?Q?XQ5hqUiflitkosnFuJJACDhy94IxoVQTwSr0u2PSQE0Lw07lJI4OPoIN1av+?=
 =?us-ascii?Q?SNhfXLmvS7lm027kiqi48Er4vBIYnlTCiHpqqCW0I4N5PVsHQT4GjoMt7Ksp?=
 =?us-ascii?Q?jA3NImpS3uPI+Qg7R46yRkV6JDQWWpPZlIBME56mM8pt00YMdZ2zpVBmrd8C?=
 =?us-ascii?Q?tOeFXMVBROFkdiKnmobzsqV2thqbzUnPVwl/yAX3jjk91ns2FqtLYvuQAGDG?=
 =?us-ascii?Q?9avp6lF4/wV/YMvnONbf6Bd7RPyoRky8TZjDwPPfhqXDPG71gn8IGYbYgmx3?=
 =?us-ascii?Q?NyDNcBm+6+SQFloZcQV0xaWTi7ctdRCjOg7nGs4j1kCtGpRfej64taUKeBKa?=
 =?us-ascii?Q?15FdpIWFp7b71/aWO3EWpr3W9+MxEUZ0l1A3YIWYMntiWyTDIkw2UB6xsbD9?=
 =?us-ascii?Q?Fz3SwqNthqBWToX98EP88x/0FYV85EoOllODXIxrY7/Y3sAtj0f8baGndhrc?=
 =?us-ascii?Q?aoPOQZ5onCbCyvz1NJE=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CY5PR11MB6257.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4e47dd0c-747a-4f24-15c7-08db8f3160aa
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jul 2023 06:10:44.0551
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: RkYQhhrp7nkxHr+v4RufWJqR2FF1/PVysjDYYe62QFJp3j+co/aAAAwozWxCfkXVpnQZvv6n9Y1B2JiSvbygCQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB8705
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> >  static int max_98390_hw_params(struct snd_pcm_substream *substream,
> >  			       struct snd_pcm_hw_params *params)  {
> >  	struct snd_soc_pcm_runtime *rtd =3D
> asoc_substream_to_rtd(substream);
> >  	struct snd_soc_dai *codec_dai;
> > +	int i, ret =3D 0;
>=20
> Redundant assignment.
>=20
Will fix it in v4 patch.

>=20
> Maybe (maybe, don't know subsystem preferences)
>=20
> #define MAX_98390_DEV0_NAME	"i2c-" MAX_98390_ACPI_HID ":00"
> #define MAX_98390_DEV1_NAME	"i2c-" MAX_98390_ACPI_HID ":01"
> #define MAX_98390_DEV2_NAME	"i2c-" MAX_98390_ACPI_HID ":02"
> #define MAX_98390_DEV3_NAME	"i2c-" MAX_98390_ACPI_HID ":03"
>=20

Will include this change in v4 patch. Thanks for reviewing.

Regards,
Brent