Message-ID: <4725F254.700@garzik.org>
Date: Mon, 29 Oct 2007 10:46:44 -0400
From: Jeff Garzik <jeff@garzik.org>
User-Agent: Thunderbird 2.0.0.5 (X11/20070727)
MIME-Version: 1.0
To: Dirk Hohndel <hohndel@linux.intel.com>
CC: Greg KH <gregkh@suse.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pciserial_resume_one ignored return value of pci_enable_device
References: <20071029132817.GA20449@bigserver.hohndel.org>
In-Reply-To: <20071029132817.GA20449@bigserver.hohndel.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1200
Lines: 38

Dirk Hohndel wrote:
> [PATCH] pciserial_resume_one ignored return value of pci_enable_device
> 
> Signed-off-by: Dirk Hohndel <hohndel@linux.intel.com>
> 
> ---
>  drivers/serial/8250_pci.c |    5 ++++-
>  1 files changed, 4 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/serial/8250_pci.c b/drivers/serial/8250_pci.c
> index 0e35756..ceb03c9 100644
> --- a/drivers/serial/8250_pci.c
> +++ b/drivers/serial/8250_pci.c
> @@ -1986,6 +1986,7 @@ static int pciserial_suspend_one(struct pci_dev *dev, pm_message_t state)
>  
>  static int pciserial_resume_one(struct pci_dev *dev)
>  {
> +	int err;
>  	struct serial_private *priv = pci_get_drvdata(dev);
>  
>  	pci_set_power_state(dev, PCI_D0);
> @@ -1995,7 +1996,9 @@ static int pciserial_resume_one(struct pci_dev *dev)
>  		/*
>  		 * The device may have been disabled.  Re-enable it.
>  		 */
> -		pci_enable_device(dev);
> +		err = pci_enable_device(dev);
> +		if (err)
> +			return err;

ACK


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/