Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230727212157.2985025-1-ppbuk5246@gmail.com> <20230727215318.43455-1-sj@kernel.org>
In-Reply-To: <20230727215318.43455-1-sj@kernel.org>
From:   Yun Levi <ppbuk5246@gmail.com>
Date:   Fri, 28 Jul 2023 07:58:56 +0100
Message-ID: <CAM7-yPQEnppWQ4j7mc4WG3POKbjzOLynkFXsSw47GRhSUaTawg@mail.gmail.com>
Subject: Re: [PATCH v2] damon: Use pmdp_get instead of drectly dereferencing pmd.
To:     SeongJae Park <sj@kernel.org>
Cc:     akpm@linux-foundation.org, damon@lists.linux.dev,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Jul 27, 2023 at 10:53=E2=80=AFPM SeongJae Park <sj@kernel.org> wrot=
e:
>
> Hi Levi,
>
>
> Thank you for quick respin.
>
> I still hope the subject to drop the ending period, and start the subject=
 with
> lowercase, like other mm/damon/ commits.
>

Sorry to bother you, I should find why the ending period inserted..

> > As ptep_get, Use the pmdp_get wrapper when we accessing pmdval
> > instead of directly dereferencing pmd.
>
> Based on the usual git commit message line length recommendation (72
> characters), there is nothing really wrong, but putting 'instead' at the =
first
> line may look more consistent with other messages.

> Since this is the good place to put additional comments not suitable for =
the
> changelog[2], it would be helpful if you could put changes of this patch =
that
> made after the v1 here, from next time.
>
> Above comments are only my trivial and personal preferences, so I wouldn'=
t ask
> you to respin, unless you really want to.
>
> [1] https://github.com/torvalds/linux/pull/17
> [2] https://docs.kernel.org/process/submitting-patches.html#the-canonical=
-patch-format

Thanks for letting me know some details why I missed :)

Many thanks.

--------
Sincerely,
Levi.