Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
To:     Daniel Wagner <dwagner@suse.de>
CC:     "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        Chaitanya Kulkarni <kch@nvidia.com>,
        Max Gurtovoy <mgurtovoy@nvidia.com>,
        Hannes Reinecke <hare@suse.de>,
        Sagi Grimberg <sagi@grimberg.me>,
        James Smart <jsmart2021@gmail.com>
Subject: Re: [PATCH blktests v1 05/11] nvme/{041,042,043,044,045,048}: Remove
 local variable hostnqn and hostid
Thread-Topic: [PATCH blktests v1 05/11] nvme/{041,042,043,044,045,048}: Remove
 local variable hostnqn and hostid
Thread-Index: AQHZv79HJRql4wyHS068WCBIAtFTIq/O1lkA
Date:   Fri, 28 Jul 2023 08:10:09 +0000
Message-ID: <keqqev3paa2rtk5ysaitglnqfokeph7uvqh4z377atjlow65eh@buvr5azvul4s>
References: <20230726124644.12619-1-dwagner@suse.de>
 <20230726124644.12619-6-dwagner@suse.de>
In-Reply-To: <20230726124644.12619-6-dwagner@suse.de>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Q2cOeHyShw6walxfd6pMJqTAoDVfsiKteN4eawC8rIEM694ma+ZMUryHTV1Q?=
 =?us-ascii?Q?1QtZx+oUB3+PptGrsJc7GsT7AHcDQ4MgioeDzrHq3nFxl9TYxWtCpq3W348e?=
 =?us-ascii?Q?91H7yhKw50nBhnxSh44ET/biYQV48Nwtm24t5tJ+4F0zPu2Yr6CEEx/ZlI0c?=
 =?us-ascii?Q?01BL6HFqdSPt31A9ziNxSg4Wyvc5Zq61MFFAWOcw91VgPo9whoD0W8Uz6oyJ?=
 =?us-ascii?Q?CfFwgD5H9iaaYUYP9rGTthCmd2+1U25tzrzCj8op+HGyh+tPEqLp706F+g5L?=
 =?us-ascii?Q?T0yfVdJf/GxvT+mu9PJaNlLIFaE24dg507FHYY30FsMbGrXo3wIVQu2mOk74?=
 =?us-ascii?Q?rRJgOsABbl3pnNdnZqS/LonGR/vluWQPJLhDEpa0sMM5wE8bYTcp5Ga1m55W?=
 =?us-ascii?Q?2pQMFf8gD7mZdjNDZYAeKi14s8Lw3pSATxliTebs2jfHTkYlGsRLG8lt2cn9?=
 =?us-ascii?Q?SEL1IEX9MVNuMaeAs1DAh+mtt1jPQNqbD57/FIAXhnS3Y4jxzItYbNxYhRwD?=
 =?us-ascii?Q?LNdN+H2reLbZomFaecnUCAX/pBMYiUWbn4lXvo/p3p1cJOWlxP9GKCyvtFpM?=
 =?us-ascii?Q?Zio8tU7QwualMn4hBPXyXhDwpEBST57B1xrhM3rT39Oqp1B3J6Piv5tfeIPQ?=
 =?us-ascii?Q?bBWwzHIh8V10Dtq4O3R8v/rcLtv9RJ/kFyRQravji6VZ0FsLX7L+C87r2SVx?=
 =?us-ascii?Q?MSXi5XcbS/emsn+ZpkZ+3AZtSD3u9LjEkYHEgDLSqEE+i49+AMbJpo/UuGi4?=
 =?us-ascii?Q?sF7LSdEn3W5THmxDsnRTOQwWmFoOo1zSuu2Ca0gueNbm9X3czJHmd0pPrxD1?=
 =?us-ascii?Q?i1zOKWTcJ+SdUGSIzCp6RcjoumKBgBsv3ekLLkN/I7pO5Zpma86kSvhUEd26?=
 =?us-ascii?Q?KX9UXzSM9jD+uc61JzH+AbZA7e1/GSCK0412V/0mQLZ6Q61OKv+kykwrraxZ?=
 =?us-ascii?Q?RETTZVlaHIyctQ4/PLx/FKryHZlToWGaJkbUWR1AhUOKPpbghLrQwTFXCgWf?=
 =?us-ascii?Q?cESqQkoj8zK9nddH7jBAXEqt0kG08ktCI0C4NqGd+nOANkSY0TNmna61yE+r?=
 =?us-ascii?Q?hgf/mopF4ADj224YW3xiQXOntG2oGhSk/G4J2QOK9yOxDuWUM9kBYpR85kF+?=
 =?us-ascii?Q?p0xbWZOfeczBfJELpKDOsqExaMlFoEd4Wr5fhOB9UP5k1pPvW9NxLhkb+0uq?=
 =?us-ascii?Q?HQgMYV0pHEhpzXL27174J+cFBw84f25nh+pMRVqFmBe0RLfpJBh7qecnY7ns?=
 =?us-ascii?Q?OFVGtQoRWsk8kIObSioZ1BdmHTOKLNV0bMal3jcm4r6iuySjIgTI03ndlXlY?=
 =?us-ascii?Q?Gi4Bx/0M4dj3SVK7/emKz4fHUJtrepZTHWsa1gE7R7sT0bmVZKglMjVofiVi?=
 =?us-ascii?Q?1rD6qOHfF9xV+zCubgQaOxsqSPJuiPe+XvdQ1ytlUyCXj4JSldP1vLercME1?=
 =?us-ascii?Q?UNgm4K+MweYSU6/Vv+WzzFb3EDz2jRWAAlml8qPlpF1JlFIpC+s9D8h17CBS?=
 =?us-ascii?Q?GfXAZNzy8dqVCF2LnfM6OUziPL/fUdynytjI/9SfKkjrG+KnIOHTelvlsoO/?=
 =?us-ascii?Q?SIHisWIPNBgP+6IfWZNRdywtKYmuZHowyQlWt1q471o7syodznh1Gn4TXjRN?=
 =?us-ascii?Q?1+lO4QIDH/fy8V6leRAd260=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <73ACAA66A2869C46811EE935F1F1E7F4@namprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?oulO6/5YL4hBN4hH2iu7Mt0SLM39F1W1JJ/E1bs/iYLb+FjFSYd8qNzJlnlo?=
 =?us-ascii?Q?9kKLHglu4gA+HzBYBwcnKFjPz58Sn+jOA6wgkbcES+5ZrBhlSbAjajA4dd8j?=
 =?us-ascii?Q?cpsKUOGjcx5FBhHGWXG3woRtsk3/p7cm8S0GUnS3PH1ESOR97RjP5USUY1CF?=
 =?us-ascii?Q?I8ly4ujXq6QjKkU0O8EhYximtz7UiJuJBZ2705K8qHRN89u7/kQzxW4/9fs9?=
 =?us-ascii?Q?Jy8IoQUHq2RVwRFxs2xGh75YVJSXHQQDNlfR9DOn1bmXgLrvieiWb5YMvR7u?=
 =?us-ascii?Q?qkV9Yq+CxDyuuYDtzx40u6jFyLS+FnayP6hT95s9P+TIvOBvV0cl325hv818?=
 =?us-ascii?Q?1szZeSH19lV2ZQxnjI69M3XAoqi9xuEGLz70QLvhIWeZLIIH7/L9jugKwxTR?=
 =?us-ascii?Q?sQ/+vKPbQmNaEInFaQTcdccGcDTwd7/9EcvlROGAdAUM2TFtwrkA0hZlLvA7?=
 =?us-ascii?Q?CPKDcDa4JemKy4DSqDTnTCIya8gctiBx6x9tZi+uHMdglY17h1WqTfZvos8s?=
 =?us-ascii?Q?vPXasRZ7SyUArsVHBI2O22pXPWfQqSExQDGkrruWKghFAZKzWsZv7mn6cdM9?=
 =?us-ascii?Q?2rrvIfTMHe1fHe1XhBGN4MMPfYHfENChCHJcnTwraIIaGYiMb4S4ZI2t6srs?=
 =?us-ascii?Q?T1YAW3tRYTHchfgMeXY/vtG3A05mlcbrpzYbSgJzXdqteTPdDkgmfu8S6H6H?=
 =?us-ascii?Q?5em1kGKwPZ1wh/Y62ChQYuYj5vdfgrc1idi2gnlrweureXsayEuSOS95Zs4B?=
 =?us-ascii?Q?W1EW623rpzHk7w0snysSp0Izuhu9MPRLZjzGtDds4sWl+yGi+I3nRevQ0W65?=
 =?us-ascii?Q?bSHPmp1Q3zIKerA0lT0EjAGgY0Duiw1NXx4CMvqvfV/ikWAuUTKDDKSvu2uG?=
 =?us-ascii?Q?UWWlPYE0vPzpNZcle904Ny6306//0+6ZTY/gyd8OB3cgEs963wCm7MOWrEdC?=
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM8PR04MB8037.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cd5698b1-e2dc-4e57-dcd2-08db8f420f97
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jul 2023 08:10:09.4791
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: c8UvrVI28rwHmK+3SsxCWxrmCgPYsgKkFphHQWPhZZh5L50p3PCmNE+LKxUyu4+8uHNwwhX7r4l5lMNNoMTzMm44KQz95cujUbP2IshbPoA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR04MB8766
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,
        SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Jul 26, 2023 / 14:46, Daniel Wagner wrote:
> Commit acc408477e85 ("nvme/{041,042,043,044,045,048}: Use default
> hostnqn and hostid") switched the test over to use the default
> hostnqn. It missed the change to remove the local variable and
> use the def_hostnqn/def_hostid directly.

[...]

> diff --git a/tests/nvme/043 b/tests/nvme/043
> index 6392bd8b2492..5569a7a58ad5 100755
> --- a/tests/nvme/043
> +++ b/tests/nvme/043
> @@ -26,17 +26,13 @@ test() {
>  	_setup_nvmet
> =20
>  	local port
> -	local hostid
> -	local hostnqn
>  	local file_path=3D"${TMPDIR}/img"
>  	local hash
>  	local dhgroup
>  	local hostkey
>  	local ctrldev
> =20
> -	hostid=3D"${def_hostid}"
> -	hostnqn=3D"${def_hostnqn}"
> -	hostkey=3D"$(nvme gen-dhchap-key -n ${subsys_name} 2> /dev/null)"
> +	hostkey=3D"$(nvme gen-dhchap-key -n ${def_hostnqn} 2> /dev/null)"

As I commented on the previous patch, the left reference to subsys_name is
replaced def_hostnqn. It means that the -n option value changes. I guess
this change is fine for this test. Could you confirm it?=