Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
To:     Daniel Wagner <dwagner@suse.de>
CC:     "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        Chaitanya Kulkarni <kch@nvidia.com>,
        Max Gurtovoy <mgurtovoy@nvidia.com>,
        Hannes Reinecke <hare@suse.de>,
        Sagi Grimberg <sagi@grimberg.me>,
        James Smart <jsmart2021@gmail.com>
Subject: Re: [PATCH blktests v1 00/11] Switch to allowed_host
Thread-Topic: [PATCH blktests v1 00/11] Switch to allowed_host
Thread-Index: AQHZv79H0kZo7ej1zEeDwLGQZvn0C6/O2VsA
Date:   Fri, 28 Jul 2023 08:20:55 +0000
Message-ID: <hqi4yxhc3jc7v7ywf5qvy3u2th676irollqngbsh62rrlitkyy@rhl6axqsve5s>
References: <20230726124644.12619-1-dwagner@suse.de>
In-Reply-To: <20230726124644.12619-1-dwagner@suse.de>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?hYMFnLrvW43PgdfSJyI4Um4CQ7eRcrZGJNBpi4Un6GiZ0bpkhDb6BroJtoKO?=
 =?us-ascii?Q?d9k26ymFoIFF6H0lqvqiu2mzgzDJ/EPE56TWLjqEWkj3oPPrYcd12kpvA2dg?=
 =?us-ascii?Q?TlbHjx3sooUydzaPR8g0ivNL92GCqWfTOzvQLCCeOPuSFiXxCcMiivVJ9o7s?=
 =?us-ascii?Q?Fc13M5iXnrFytOhibn7DnYWfkA3zjfaN8U3Z/zSnVXx703Dbx+s6LK6C9YuY?=
 =?us-ascii?Q?azkkLERci8gduzwAZ/CNzVYfFYX8AXHiToPtq/Hlc5VNQ+WACtNoRdUEtVs3?=
 =?us-ascii?Q?exeKwiZCLHgtADakEbfi8YIe7xhOoubPb8sWc6lDZ/qydwNeojyQNFIIy8ss?=
 =?us-ascii?Q?4jeVqPn4aoFbQdjsJKlzSsTmPadkNpnjT1RJ0uXxtP6TQTksYYWiE/NFiYz7?=
 =?us-ascii?Q?cEex7raAdoLlahtXa8g2KUBP3V2JSqIu/5DcMNQ4A9Lhoh0wLtmGVnVNGDpd?=
 =?us-ascii?Q?yFb2QtCeXUPW3Egzsgml8SE4jnPQiqztJgiQEIdC/u5Lg4Mf0Ur14n2L0Npk?=
 =?us-ascii?Q?w8a9iSZhCvhVFoChGqrfqtumw64QJM9JNUzv2Lk1NBnKeazckNkoIVYCSBSz?=
 =?us-ascii?Q?mS6idCX3hGzflmooownpadqiZHqkG2MBmalVljRaNO0hglGR988UXBWNHTcc?=
 =?us-ascii?Q?j0Ozik6KU2UplJ79RNq0Lw9UgTujxqP8fdFEIjOmZR3IULZJrEskyRbW7Y9a?=
 =?us-ascii?Q?peLArLtxdtYgyK/Z2sCl2iB/E8FOpPzApkbAgRdLj6T6vbsjJzIyEab6OKdq?=
 =?us-ascii?Q?Mkrt1hjeln9IL7q7xrO2ZNTFA+5LQA1ypSFaJKYm4CjGOQn44qshn1JHWG0c?=
 =?us-ascii?Q?CKBe5Pte6OC09Ni9wf72Fx2AT9FjUVcs52IKumpsuWmriQmnkkiAEiUUWFer?=
 =?us-ascii?Q?o0VBOFH7OEdOXlPMfHYwVDhwmTxcmxyZnW4BXk/I8ZMneRy8vfX/7MDgFQ0p?=
 =?us-ascii?Q?j3NPDqEk5QW5Ph1H/tF7dk4GR9si2mEBDQetQJk9YAHBDM9Gi2E/XMIQrdU2?=
 =?us-ascii?Q?m1KX/voUnW1vrsQAlPl1ju/MOvBaV0QWTgvXCYLcclR/e4nfJp59DNCbY/dn?=
 =?us-ascii?Q?sEq+1rhxkZ00P+2klhzNNXsH78apIltg7rnsOhP5OVx3OSaHZ6mIykWtJmtB?=
 =?us-ascii?Q?AypTALxO01qwWisniv6xTSszuRVoBkZYv5ch2+OqUdAcK7spj7yfxriBGoOv?=
 =?us-ascii?Q?rWaFzD8XBfBPRI4MmItYsP5go3H59i11Q9uQqgDK8ZkAljBp536xOW4v/5xk?=
 =?us-ascii?Q?WRB9NkxdEWaEwTQDmD90g8C8CRBDfTrswuLZkn2FbpvZWKTCjA+HcGY/1jmZ?=
 =?us-ascii?Q?Ngf6313UuNAkBIia9iv9Fx8TP2tt2CHM8zGs58lOUZm+nP0mfk4nd5wQXva/?=
 =?us-ascii?Q?9W4pOkFo5TsDBAEg9KAnKIl9Nj5VqmhhwCxIGwNPsmF80Bj8NO3qDbga0E4n?=
 =?us-ascii?Q?qbf2dKtMxqjhmQpCt15Oee+jPJ5PeHT/Gew5kUnFJly/Lp1no/Q1U6i+ttka?=
 =?us-ascii?Q?+kTQNA2T/AbvN3W394mLVkD+eVpuc47G2uJKoRekJKTuz9mhKqKNlAelXn4f?=
 =?us-ascii?Q?doWGBiamiLZfikwhgYgT1oF8jfvQrxB6ekxUNxenYlP28mkXNyHKXIzexVLW?=
 =?us-ascii?Q?GPG3tp+yKAmaJWpQlQhMwWE=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <208E308F6039734D93A2BE8883CC827B@namprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?0D43FeAAmnDltIp/FKryKXoybMPh/tTdrrFgFERGD50SKAVyEAP9YC8t32an?=
 =?us-ascii?Q?8XkeBWGLYGhiMxOBARQ/VwBTjLLHqmUAejxXQPWeSX69c/0KhPV/vig9Ewb1?=
 =?us-ascii?Q?WxfyTyTsOtlmzn2bZd0pekpqZ8CmfbmVXSs/sBA+IAavanQdWBncs59iRbGx?=
 =?us-ascii?Q?NpY7NbI8J8yMvIjtd/0rNF3OEErh+tX4H3JAsH5Rj484TA1ejfpGWptRANU1?=
 =?us-ascii?Q?z1rPxA3NcoKfk0H7tpV5znbgc/vrLlPRDkexEpvO4NKgjgXnmpu5LKAlCHlm?=
 =?us-ascii?Q?XyVRAd39rydCGsjRWlKUvS3DpVNnMZPrhpqFdLq7esWZGjmhuxWnkHS6F2KL?=
 =?us-ascii?Q?YrHDs0Gkneln5lbvM8TBfbcYxPBL6ZEAIPfkHVsq0IyWt0WvxXcSjhBWOdRv?=
 =?us-ascii?Q?N8BPQJZPZY7jwN6P2irhlnqlMzleNsL8EqSeTvSSLzg/Be/aV5FuvQ45Ngv8?=
 =?us-ascii?Q?MPsaRU4Y0ahTftw8q3W4uVjc2u1yfvPpF+UdnDxhNCUD4jSePW0wOxLs1vGv?=
 =?us-ascii?Q?JGfyyyGGBdSwzMWik0+ixZ/wsavJSn0WK6picM258KkPPOROzaF6EpgRnv0F?=
 =?us-ascii?Q?RFcoqHSdaxKM0mhk7qThy9/8JhEH+TOVN7SEpSNWedjiEO4sa6ewJRe3ykyt?=
 =?us-ascii?Q?1mSoClDYQgDjHmAw50C1FkDXj7T55R320TuNIYqJKbI/Gji5Ey0DvSwpwoun?=
 =?us-ascii?Q?awLTQ3mp0lon11owH0krEXhIu8OC8IbrXyvk4ztcbRBhikQoBTn8BCuRroOt?=
 =?us-ascii?Q?40sWbug2i4Ri/ngi8FmIHcu83WW6nfDALzr0CXAuFM7OXhkJbou5tFpkmT73?=
 =?us-ascii?Q?wSm2q/QxXbXUqM+UbBFs4hH1tfe8oWTTuHFAyBdiPUIl5d7nFMziYMBZhWAW?=
 =?us-ascii?Q?ODUPu3uPFP9M/iT0UyWXiCDLr1AMjHc9mc3jH5ilbb01Pq++v+FDaZlk7FlF?=
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM8PR04MB8037.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 33b2e2b9-71c9-4d59-5d4b-08db8f4390bd
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jul 2023 08:20:55.6793
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 1vkP8JMEY5uxV1kUBZ8o2nGW5OH7JW4m9C3Mw+PE1FWm4MBnZWxy/5wEDrjy3LmYePxW50wrgeTy2YjJSm5aXB587vrWlnE3Nlcj7fc0+Mk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR04MB8173
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,
        SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Jul 26, 2023 / 14:46, Daniel Wagner wrote:
> Max asked me to replace replace the 'nvme/rc: Avoid triggering host nvme-=
cli
> autoconnect' feature with using allowed_host on the target side [1]
>=20
> So while looking into this new feature, I first started to refactor exist=
ing
> code so that it looks a bit more consistent. I think there is even more
> potential to make it smaller, by introducing something similiar to
> _nvmet_passthru_target_setup() and _nvmet_passthru_target_cleanup() for n=
on
> passthru tests. A lot of duplicated setup/cleanup code in many tests.

Thanks for this action :)

>=20
> Except the last two patches are just refactoring patches. So if we decide=
 to use
> common target setup/cleanup helpers, I think we could add them before the=
 last
> two patches, which would make the last patch way smaller.

I ran 'make check' and saw shellecheck complaints below. I added 'export' t=
o the
variables then they disappeared.

tests/nvme/rc:19:1: warning: def_subsysnqn appears unused. Verify use (or e=
xport if used externally). [SC2034]
tests/nvme/rc:20:1: warning: def_file_path appears unused. Verify use (or e=
xport if used externally). [SC2034]
tests/nvme/rc:21:1: warning: def_file_path appears unused. Verify use (or e=
xport if used externally). [SC2034]

I also ran nvme tests with the export fixes and saw no regression. Looks go=
od
from test run point of view.=