Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 28 Jul 2023 10:44:04 +0200
From:   Henning Schild <henning.schild@siemens.com>
To:     Hans de Goede <hdegoede@redhat.com>,
        Mark Gross <markgross@kernel.org>,
        platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     Tobias Schaffner <tobias.schaffner@siemens.com>,
        "xingtong.wu" <xingtong.wu@siemens.com>
Subject: Re: [PATCH] platform/x86: simatic-ipc-batt: fix reading in BX_21A
Message-ID: <20230728104404.0f7e4ef9@md1za8fc.ad001.siemens.net>
In-Reply-To: <20230728083651.19747-1-henning.schild@siemens.com>
References: <20230725093113.9739-1-henning.schild@siemens.com>
        <20230728083651.19747-1-henning.schild@siemens.com>
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?gDiVjVqIrgGPFY8QdBO8HgujrZ81BOvNKPshuBNfq2X/wlmnml/nHFk+dxBu?=
 =?us-ascii?Q?WIcTw2l+5c4l6KjDr7Bvc6VexVtmnGUDtZKrjIlrg6700KuHDWxwHHEhSCsu?=
 =?us-ascii?Q?3aHcNWX6rxrpSrFM64HYxIzB1C+cNeTjHcj3P9mxeIb4esp9xNFOJSAdbL51?=
 =?us-ascii?Q?2XOCjfb7cT7bYRYgIsQVKovgyFF2nbcWTKZoSegjLImEXkgByhsCa6hpDyqf?=
 =?us-ascii?Q?Mz7OUUKX20fmzWunMKHAWBUnoGNwoZjjDbldxTQStbGHvk4TraqeK6HPxNdh?=
 =?us-ascii?Q?tKNhLm0FDaBUXeJ7CIgvVYy8Ab7DHbzKWrHA3Jcc4h0/lzPKB7Ji5jfgjywK?=
 =?us-ascii?Q?C8ETuGdja3UT31B2y/HOGTlwr2bDdKi+tx9FTnjeDG9nmRT2YPk2Sx27uGe2?=
 =?us-ascii?Q?Gle520ZXbM3kszc4pefw5vMwWPoVPochSS7mhEdwQhP+T/1mqXndxaZPeuaI?=
 =?us-ascii?Q?0IoyBdOki5eYWIzxcE4ouFvB36mLSaSMHWyPoG4OybWqUaF5WgKA168npT51?=
 =?us-ascii?Q?6Ei6RRm+68QGGEyfBHTiuSR7mkgd0Zuic27eGLxBjTYV+nyF7bX82puorxMT?=
 =?us-ascii?Q?fFte1h1oM0GA2XYsVeT74MIbdumSiMRCn1dNNE0auWBqWwIfhHcUJcV7hK+o?=
 =?us-ascii?Q?XIeJdpntM/ISufhE6lY4z3cl09acmMzOVUtagNkMNFWUzLg0TyY9WVLSh1Lv?=
 =?us-ascii?Q?D3mexXZO0dk4aDZsuk4Q+DJxeNdUixgXsLFM97IkquWGgFxwhaanDRSlPtb7?=
 =?us-ascii?Q?G0o27w6qECRLGvE77oVqFKyOE8m/QisM2ef3OafT4/fnlldS/Xn1nVy3K5ic?=
 =?us-ascii?Q?2+SJMal6PiDZVisbL0iXKLrhoISuugeaPiXVG2JTCzK+TYOYF9vAjnUC1ny/?=
 =?us-ascii?Q?6HlmvEi6jkj7cEayXkNGwohZOCCSbmauQdpXPFKOs+LN90l4MwdwaGevgVbU?=
 =?us-ascii?Q?zDgqxggop/0gF6Aij4pfunF3yp8yt9toOxjsxmJIZPHbmn0zLBgsBFVvXBVJ?=
 =?us-ascii?Q?rdo9jtKwnYKIuzkRX4vfsUONNivqiPeWq+KdKlMWMB1xT04Ap2E6EJgkio+b?=
 =?us-ascii?Q?23IvFSsqvMYbZMdpEFPl9BRZMukexCS0YMtQN4dk5KbGK1M0ySSbG3VxYTZK?=
 =?us-ascii?Q?igrS2Km0Qlc71Q2g/ckBEPKjKtaRplLR027BCs2I095x1oBkk3gBqYZVMyQs?=
 =?us-ascii?Q?zPKG7f0pRZ3RQe32/Hee8qsyDeSQB65SXItUoSeMmZXpKG/r2CrxXrdj0UBL?=
 =?us-ascii?Q?tB3gS5an5U+zEG3+afHXCOUJfTlDtTHTZkhQ6fclN5ZY+8dHhM5jtAGE2V3I?=
 =?us-ascii?Q?cb0axv5J20p1g3MpReXF4lkLnJKd9UQa7mo0uvKnBOQu0xUnxZTtfTwnfwgf?=
 =?us-ascii?Q?tAR6P+Z6D8qzODo05o+o3sCe802yYryIPNylDhmzLpgs3FqOsscwxCML9My2?=
 =?us-ascii?Q?5JiYI9bdIBUvKyebiOkNtGptAxUyKGTPtsJKOTjnyr1PKyZg2iXh1+kKznEL?=
 =?us-ascii?Q?VcKa3EzOZCjHeecZcMrei9DtXzuwCp7Rrs2Dni2a/cxvZuf5SO0kIZgucn/w?=
 =?us-ascii?Q?XrK1Z34chx3+iTdpJxvORog1B0BSYLM0JRToEpsAeOma3uKgkZe9+4bwpFAL?=
 =?us-ascii?Q?Dw=3D=3D?=
X-OriginatorOrg: siemens.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f5005126-21ba-4982-ad6b-08db8f46d1b0
X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jul 2023 08:44:13.2800
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rIOsIgtrRqXCy6WXULld4KOvNQo8N2buIflWoar6yMSZyL1SvZf4iur39ix40OpsVFTRN17kHh+TS3Km0ofbkMM2mwFJ2ke4UrvA19MrAlA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR10MB5254
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_MED,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

This is in fact "[PATCH 1/2]", it needed to be send again because it
somehow did not make it out into the archives correctly. Sorry for the
noise if you received it multiple times.

Henning

Am Fri, 28 Jul 2023 10:36:51 +0200
schrieb henning.schild@siemens.com:

> From: "xingtong.wu" <xingtong.wu@siemens.com>
> 
> There was a case missing in a switch statement which lead to that
> model not actually reading the GPIOs. That switch statement got
> simplified now. Additionally on that model we need to initialize one
> pin differently. As a drive-by finding also add a missing newline.
> 
> Fixes: 917f54340794 ("platform/x86: simatic-ipc: add CMOS battery
> monitoring") Reported-by: Henning Schild <henning.schild@siemens.com>
> Signed-off-by: xingtong.wu <xingtong.wu@siemens.com>
> Signed-off-by: Henning Schild <henning.schild@siemens.com>
> ---
>  .../platform/x86/siemens/simatic-ipc-batt.c   | 21
> +++++++++---------- 1 file changed, 10 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/platform/x86/siemens/simatic-ipc-batt.c
> b/drivers/platform/x86/siemens/simatic-ipc-batt.c index
> d2791ff84f23..e34417ca9e13 100644 ---
> a/drivers/platform/x86/siemens/simatic-ipc-batt.c +++
> b/drivers/platform/x86/siemens/simatic-ipc-batt.c @@ -92,19 +92,14 @@
> static long simatic_ipc_batt_read_value(struct device *dev) 
>  	next_update = priv.last_updated_jiffies +
> msecs_to_jiffies(BATT_DELAY_MS); if (time_after(jiffies, next_update)
> || !priv.last_updated_jiffies) {
> -		switch (priv.devmode) {
> -		case SIMATIC_IPC_DEVICE_127E:
> -		case SIMATIC_IPC_DEVICE_227G:
> -		case SIMATIC_IPC_DEVICE_BX_39A:
> -			priv.current_state =
> simatic_ipc_batt_read_gpio();
> -			break;
> -		case SIMATIC_IPC_DEVICE_227E:
> +		if (priv.devmode == SIMATIC_IPC_DEVICE_227E)
>  			priv.current_state =
> simatic_ipc_batt_read_io(dev);
> -			break;
> -		}
> +		else
> +			priv.current_state =
> simatic_ipc_batt_read_gpio(); +
>  		priv.last_updated_jiffies = jiffies;
>  		if (priv.current_state < SIMATIC_IPC_BATT_LEVEL_FULL)
> -			dev_warn(dev, "CMOS battery needs to be
> replaced.");
> +			dev_warn(dev, "CMOS battery needs to be
> replaced.\n"); }
>  
>  	return priv.current_state;
> @@ -163,6 +158,7 @@ int simatic_ipc_batt_probe(struct platform_device
> *pdev, struct gpiod_lookup_tab struct simatic_ipc_platform *plat;
>  	struct device *dev = &pdev->dev;
>  	struct device *hwmon_dev;
> +	unsigned long flags;
>  	int err;
>  
>  	plat = pdev->dev.platform_data;
> @@ -196,7 +192,10 @@ int simatic_ipc_batt_probe(struct
> platform_device *pdev, struct gpiod_lookup_tab }
>  
>  	if (table->table[2].key) {
> -		priv.gpios[2] = devm_gpiod_get_index(dev,
> "CMOSBattery meter", 2, GPIOD_OUT_HIGH);
> +		flags = GPIOD_OUT_HIGH;
> +		if (priv.devmode == SIMATIC_IPC_DEVICE_BX_21A)
> +			flags = GPIOD_OUT_LOW;
> +		priv.gpios[2] = devm_gpiod_get_index(dev,
> "CMOSBattery meter", 2, flags); if (IS_ERR(priv.gpios[2])) {
>  			err = PTR_ERR(priv.gpios[1]);
>  			priv.gpios[2] = NULL;