Received: by 2002:a05:6358:c692:b0:131:369:b2a3 with SMTP id fe18csp956423rwb; Fri, 28 Jul 2023 02:26:34 -0700 (PDT) X-Google-Smtp-Source: APBJJlF7HkWUXvUCFj8zE4ajO54UEWpGpxOqAGoBp8pHU/ar9R2aU/tf4u9FlFT4JEWZAVT0Vr7D X-Received: by 2002:a05:6402:50c8:b0:51e:5206:d69e with SMTP id h8-20020a05640250c800b0051e5206d69emr5178184edb.10.1690536393700; Fri, 28 Jul 2023 02:26:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690536393; cv=none; d=google.com; s=arc-20160816; b=ofwIEoTmfpXhGOnY+iU+Xzj2yjRx2I3qCU8rwS3ZCadq6cB/jOPStX68Koi3u0l2iu ggE+Eb0icfHeoeB1Xc3zbUWLh9KqJ1eaxmyQOjH+Tdfu8kU17g/EsE17DdcZ9pENhxEL qP5RahPN3dNXqiE7jqknb3uppdQLH6R9MpfPc/mTELREmWfgXSRhnvQA1HFtz3nfC/Fr X0NGagTyZAFsvQ3A2AJdCkDGKF6+el+RNu/RNkAcDWBKcgleAzw6X8u9KeRz44ftTIdN 8hw70CZ4y3YAgN/sjO1VFjTIzI3eLMgpAQPSYzHNKINS2dR5rMqwwLPIqmrtX+uUjfdE Sg2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=UZjkkHDL7ZTA+1HGFOAIVhHEoIpWXGP8CKYmIiCzoRs=; fh=OJqJ4g6a2lwzd6BmNYZQ26mAZexgxB4b8diYWwpPA5I=; b=AlOEIDNpQsYhVy68bumiulAL3ZI7DuyPm/Y1THQYJkwrD1YeIUhAfwI96r9HymTHnf 6lAZn7V+1UVx49ARmusQb47XoGBhMQCEkaUFPMa6c1Wa2Ehs0hhLFBjPdjfnNa/R8K4S obJPa2d+r4+kVLVFpvtOPUpHRmslNnzZa40FPD7SosQngFbMyRDkcqvn8BQVN7LiXKuq RZZ3Ufk5EvlTEJHk5YuEZ+1SqxYule4L3ddICg/vJvKaXiHaVA1wcUdYPPeFo8GMVzTq CPoHDaJHas7oEmYQgZJGo6pdOaULzZqyMpjQWE1O6Uve2HQXNKD9V+rh1ejeOyVgJSoR NDNg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Jq54e2P2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f18-20020a056402069200b005222d141b53si2209275edy.29.2023.07.28.02.26.03; Fri, 28 Jul 2023 02:26:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Jq54e2P2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235025AbjG1JOI (ORCPT + 99 others); Fri, 28 Jul 2023 05:14:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33418 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235225AbjG1JMl (ORCPT ); Fri, 28 Jul 2023 05:12:41 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 19D593A97; Fri, 28 Jul 2023 02:10:38 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A8B1762088; Fri, 28 Jul 2023 09:10:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DFF74C433C7; Fri, 28 Jul 2023 09:10:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690535437; bh=jsukJ3h2ilmz083UcYGengZNcUIJYlLHWk6g/LKxW1A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Jq54e2P2vabTsv0/ZkCTu/TtAKcPA/986KlVzpTtjaLAFsettUVGxIIEhV012qHmY XjZnDjmAeW2ab1ZsUURkM7jE4L/524t63e/2b+AR7jZDEQXiyB3jMa2BRjo+JEpwRs l3QdUPJ8w/4urXWddV+VETsCyali7ZkVGVcRJ/K6g+RVz5T9C+bf9WioC+uygEDa9I Rh3AvZFW0PdulmDiZySwu0Xy2XsI/jHB3Xyi77hPM/dAwa7KUnEsd9+KEupPqjueWP u1x3RpBtfjI/oksjIHjYF89qn/jUU3ZW18drI+6RQKSDrQ5SYoMzV9cMfadNlCraZU lW9h48LazI1/g== Date: Fri, 28 Jul 2023 10:10:24 +0100 From: Lee Jones To: Rob Herring Cc: Linus Walleij , Thor Thayer , Manivannan Sadhasivam , Cristian Ciocaltea , Benson Leung , Guenter Roeck , Support Opensource , Charles Keepax , Richard Fitzgerald , Chanwoo Choi , Krzysztof Kozlowski , Matthias Brugger , AngeloGioacchino Del Regno , Tony Lindgren , Andy Gross , Bjorn Andersson , Konrad Dybcio , Matti Vaittinen , Orson Zhai , Baolin Wang , Chunyan Zhang , Fabrice Gasnier , Maxime Coquelin , Alexandre Torgue , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com, linux-actions@lists.infradead.org, chrome-platform@lists.linux.dev, alsa-devel@alsa-project.org, linux-mediatek@lists.infradead.org, linux-omap@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, linux-mtd@lists.infradead.org Subject: Re: [PATCH] mfd: Explicitly include correct DT includes Message-ID: <20230728091024.GE8175@google.com> References: <20230714174731.4059811-1-robh@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230714174731.4059811-1-robh@kernel.org> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 14 Jul 2023, Rob Herring wrote: > The DT of_device.h and of_platform.h date back to the separate > of_platform_bus_type before it as merged into the regular platform bus. > As part of that merge prepping Arm DT support 13 years ago, they > "temporarily" include each other. They also include platform_device.h > and of.h. As a result, there's a pretty much random mix of those include > files used throughout the tree. In order to detangle these headers and > replace the implicit includes with struct declarations, users need to > explicitly include the correct includes. > > Signed-off-by: Rob Herring > --- > drivers/mfd/ab8500-core.c | 1 - > drivers/mfd/acer-ec-a500.c | 2 +- > drivers/mfd/act8945a.c | 2 +- > drivers/mfd/altera-sysmgr.c | 3 +-- > drivers/mfd/arizona-core.c | 1 - > drivers/mfd/atc260x-core.c | 1 - > drivers/mfd/bcm590xx.c | 1 - > drivers/mfd/cros_ec_dev.c | 2 +- > drivers/mfd/da9052-i2c.c | 5 +---- > drivers/mfd/da9055-i2c.c | 1 - > drivers/mfd/da9062-core.c | 2 +- > drivers/mfd/hi655x-pmic.c | 4 ++-- > drivers/mfd/iqs62x.c | 2 +- > drivers/mfd/lp873x.c | 2 +- > drivers/mfd/madera-i2c.c | 1 - > drivers/mfd/madera-spi.c | 1 - > drivers/mfd/max77620.c | 1 - > drivers/mfd/max77686.c | 1 - > drivers/mfd/max77843.c | 2 +- > drivers/mfd/max8907.c | 1 - > drivers/mfd/max8925-core.c | 1 - > drivers/mfd/max8997.c | 1 - > drivers/mfd/max8998.c | 1 - > drivers/mfd/mt6358-irq.c | 5 ++--- > drivers/mfd/mt6397-core.c | 5 +++-- > drivers/mfd/mt6397-irq.c | 5 ++--- > drivers/mfd/palmas.c | 3 ++- > drivers/mfd/qcom-pm8008.c | 2 +- > drivers/mfd/rave-sp.c | 2 +- > drivers/mfd/rk8xx-core.c | 2 +- > drivers/mfd/rohm-bd71828.c | 2 +- > drivers/mfd/rohm-bd718x7.c | 2 +- > drivers/mfd/rohm-bd9576.c | 2 +- > drivers/mfd/rt5033.c | 2 +- > drivers/mfd/rz-mtu3.c | 4 +++- > drivers/mfd/sec-core.c | 2 -- > drivers/mfd/sprd-sc27xx-spi.c | 2 +- > drivers/mfd/ssbi.c | 6 +++--- > drivers/mfd/stm32-lptimer.c | 1 + > drivers/mfd/stm32-timers.c | 1 + > drivers/mfd/sun4i-gpadc.c | 4 ++-- > drivers/mfd/ti-lmu.c | 1 - > drivers/mfd/ti_am335x_tscadc.c | 2 +- > drivers/mfd/tps6507x.c | 1 - > drivers/mfd/tps65090.c | 1 - > drivers/mfd/tps65217.c | 1 - > drivers/mfd/tps65218.c | 1 - > drivers/mfd/tps6594-core.c | 2 +- > drivers/mfd/twl6040.c | 2 -- > drivers/mfd/wm831x-core.c | 3 +-- > drivers/mtd/chips/cfi_cmdset_0002.c | 3 +-- > 51 files changed, 42 insertions(+), 66 deletions(-) Applied, thanks -- Lee Jones [李琼斯]