Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <01f793eb-6373-e6c0-a712-9e08ee3c91c8@oracle.com>
Date:   Fri, 28 Jul 2023 09:17:14 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH v5 4/5] perf jevents: Add support for Arm CMN PMU aliasing
Content-Language: en-US
To:     Jing Zhang <renyu.zj@linux.alibaba.com>,
        Ian Rogers <irogers@google.com>
Cc:     Will Deacon <will@kernel.org>, Mark Rutland <mark.rutland@arm.com>,
        Robin Murphy <robin.murphy@arm.com>,
        Ilkka Koskinen <ilkka@os.amperecomputing.com>,
        Namhyung Kim <namhyung@kernel.org>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-perf-users@vger.kernel.org, linux-doc@vger.kernel.org,
        Zhuo Song <zhuo.song@linux.alibaba.com>,
        Shuai Xue <xueshuai@linux.alibaba.com>
References: <1690525040-77423-1-git-send-email-renyu.zj@linux.alibaba.com>
 <1690525040-77423-5-git-send-email-renyu.zj@linux.alibaba.com>
From:   John Garry <john.g.garry@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <1690525040-77423-5-git-send-email-renyu.zj@linux.alibaba.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c28zS0xwZ0g0RVJ4WUIxN3hTdVQ1a1JMQ0ppaUQ3Qk92QlE0UXRaMHFpb1pI?=
 =?utf-8?B?UlhDZVNHOUhTaGUrYkNVSTRuT2JNaVN2NldaWUIzV0E5cGlUdEV1L2hWcDBy?=
 =?utf-8?B?VVhiS3hqTGFuRjhYU0hxdFpMRzNiaUhLV0gwaDlzcmlMWk13WXNFUU5jMUZz?=
 =?utf-8?B?L21mMElRZnRIVS9zeU95bElBTHZTOXZYeDlIaXFCWk9IYUFhNHRxVkdrVVRp?=
 =?utf-8?B?L3pHRDRYemlHRUVwWmRyRzY3UWd5d25BTmdnWDVWTGI5TVdTNllVOTZQS2Nu?=
 =?utf-8?B?ZEhKbTdwUjdvSkxkOHZMMHhWdjR4TllNeStiRUZlbHpSYTFHTlpqVlFCVTgv?=
 =?utf-8?B?a0Jsc3RSTnFjREkyZ09ObmpjS2ZTdzc2MmJMTGJmRm5Jdkh3N1lxS0U0RFRk?=
 =?utf-8?B?SFFKeXdyRityOWl1dWlhUFBYbzRPV2tKODJTd0w4M0JFb3BSYTcwZTJqa2RR?=
 =?utf-8?B?QTBTb3pQb29MY0lWQW81ZWhlNXhDNVVHSTZ6VU9kRlNPWXI2dEFvUWlibFBa?=
 =?utf-8?B?bzk4SXhXL1RpT1NPZE43ZWEyQk0wcUJESVMvOUZJMlgvNDJKcXMySkVHaXFV?=
 =?utf-8?B?M1Iyclh5ZTJmTmRCZnQyaWh5ZHlHeExpOFNsUTVOK3pmc2VRSitTY0xHUmk3?=
 =?utf-8?B?UlRQRFpIV05rUXpmbUZtMUIvK0VPT0xJdGN3KzZUWit2U25BZWdYNzEwc2p6?=
 =?utf-8?B?RXM5NW9kckhIVlZCMUNHRkxzVmFIbnE3MFYzS0lvY1hZSUtmT0lxc2tGZnho?=
 =?utf-8?B?UDRSZGF5alFRTUYrZFhTQTcwNTJVdm9FaTlSOWM0MTRIK0Zid3pNazJOOVdo?=
 =?utf-8?B?Tk16Vy9pa2hZZzl4ay9zWTVFb0hMUGNNYlJocVVwYUhuSWFkRTk2SnF4OGNo?=
 =?utf-8?B?MVQ4MFh0UHVmM0I2R3hCMEEzZU9IVWlEVWpJTUM1dnlWL1dqd29ZTlZRWmc0?=
 =?utf-8?B?UUs3b3F5UVUyRDRkT1hJMElCRW1rQi9RVEFGck1GNjIweXRpN0h1a0NXMVpF?=
 =?utf-8?B?SXVCVWtBeS9uaklPMFlxUkZTcC9hSnVqbWV1TWhQaE9VYmRtNEwyYndVNHRY?=
 =?utf-8?B?MXVNaDFwTitITVhEdmRCYzgrdU1hZHNXaHBVSmlVZlBEbk1XbUM3RkNVbThl?=
 =?utf-8?B?Rm9WMDJVWWNZR1c3dSsrWGRObHR4a1YvRXZkaHFHMVRtdjA3ZEhydEZSQW94?=
 =?utf-8?B?bXNNUXBmN1duRHV2YzlJWTZFeEdubTVvRURhOEo1QXZoQTBUQlVPbGdyY0ZG?=
 =?utf-8?B?ajJaK3UyZi9KelZDZWpMTEw3b212Z0pXSExhWFV5YWFDRzQxVDZJK1ZSS3gx?=
 =?utf-8?B?N0xrNStYeGlXOE9vcWJLZ09vSERMZXVWd0NVOXQvZjNjWXVuYjFXM2NNTlZY?=
 =?utf-8?B?d0x4ejd1MjFMK0tURGhYV3hlMnMrM2ljZW9OWUNmUm91enRLN25NSUZFb2Zu?=
 =?utf-8?B?N1VSQXJhdTViVHFtN2dmeDJIZ1ZlZENhamR2TDlKVEdBa3U5Y3dWN1VYYk1l?=
 =?utf-8?B?eGpxZVdhM1FNOXpTeEZpTzR4cGlOMHZNT04zTElvY0F6M3VWZEorZ3kzRnhx?=
 =?utf-8?B?TnRWWUdLd0dMWEVPSWpKbkU3MzA5elE3b0NLWFRabHF1SHhPeHYrWHYxQnFw?=
 =?utf-8?B?ZU1qRnUvMkF0UWJIOXUySmtwTXlFMlZWQzZnUFFHRStpZm4zWjQwblZRYWJV?=
 =?utf-8?B?Y1ZLY09ycUxTMjBVYWJVTGp4VExpOUx0TGRxMGZ4NkZVNVAvRXpKU0R3bnRF?=
 =?utf-8?B?R1hKNUNXeXZGWHdKaFFNS0lsWEc1N3hJTFE5NDZqekpHYmhrVmZrTzZyQkd2?=
 =?utf-8?B?VUZBN0dQdXo3THVySHkycEF2VjhLbnZzdUlyWlVteHkveUk0OWptdEZBMlZt?=
 =?utf-8?B?MjVjWkc3eExTY0w1akFPTEJvQ3VyL2pGMzRDckk2Mk82VExmVTlmQVlHRHRJ?=
 =?utf-8?B?eVYwODZEWVpyb0k2YTN5WCtSNmFEc2x2TzFiOTdnSDNiUVEzeWpLSXA3U0c3?=
 =?utf-8?B?UzFyL3g3MnVDOTFjT01ObUo5MCt5TnZKTStBR0FadVFEdEVJbFNYVWpSWWY1?=
 =?utf-8?B?NVFSUFZUSDZHbC9Rd3RhMWVlb2g4OXg4NmlYV3gvTkFGck8rZXlKeUsvSnhV?=
 =?utf-8?Q?kD/MtT6t5iqOeZNTU2YatG0o1?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?N0tFckRXaTlBM0FWMVFONWtHb241MG5FK0MrclcwaDlEeVRxcXIrNkp6VDdU?=
 =?utf-8?B?UWw5R3pHSXRVVUJPa3FuaDVWSEMzN1YvcGJqZkZ0dytMbzNmWTdrYVVVbkJi?=
 =?utf-8?B?ZVZ3S25pc0ZUS0FZY3AyQ2JSazF4REVTRERNTnYwSTc2VytURW5qTXJPL3V0?=
 =?utf-8?B?cE5zU3FkQUhqaVNkRVJrSVEwajlIWlVNZ25ZazM2emYwa3Y4YjF3bm02Vm10?=
 =?utf-8?B?Q3Fub2RmcDg2Z1Rmcyt5OU9LQnVwL3UrbDNDVjJaSUg1eE9sNHZRalBESzNB?=
 =?utf-8?B?bEtDTFZXYll0UURhS1cybkdFRFRsS3hlQkh2bHQwVkJiZ203UzM1eVl1Ylor?=
 =?utf-8?B?cnpqU3JDVWFESTRaWDBkT0RacnVRQkExT0p4YXFEQzd5clJwZzVCVkFBT1lV?=
 =?utf-8?B?WElTNFJJT29qeG5KclBWd21nUUhxelZxeFFCa3B6c3BlM1p6Wkh1N2RWU3Rx?=
 =?utf-8?B?UzhheVFyWlBsK0dtQkZXSFBHMlpiMi9rdS9UbXRCQWJyd0N0N0lvK3hOaXp1?=
 =?utf-8?B?UmpjQXlqeVZSZjQxcmNENWxGZ2thMVEybTVjRUlYODgvajdVYk5jUzRndk9v?=
 =?utf-8?B?M0ZNT3VXZmxGUkFvNTlubFJkTmlMNzJ4ZnBCTFN3TUJmbmk2aVpJU1hUbTNr?=
 =?utf-8?B?bEVsTGh3dGVXZkRCWWhIRUpleklOMUNmMmdxQlE0NndnTmxqZjZ2SHdFTXNX?=
 =?utf-8?B?Z000Rm9oNDFqNzFpbFg0SVVnOHgxV1V0cWcvWkpKMi80eHo3cG95NUFLSnVy?=
 =?utf-8?B?TkwyV2thZU9rTGE2bHFrNCtUNlBOMERKRXMwVzZVZGlYLzMzMkpReXZObkw1?=
 =?utf-8?B?WjY2MTliN0VCaHVEUW9IMnVHcUx3K1UvVGVPK1NkaldiSVZqMEtlS1ZxT09h?=
 =?utf-8?B?ZElPSzB2UkozcklrTjJxSkEwUzZzUmdaU3p0ZlUxdDV4WVhTOTh1K0FsSXJt?=
 =?utf-8?B?TmplRUNOc3BUVUJWaENSNkpCV1VmcHU2REdYV25CWVcydXlMLzByWFNuN0xN?=
 =?utf-8?B?MXhma2JXOEdORVdVQ3Z4Zy9LZ3E5anpoaXN6Z2huRXFiNnpWS3pzSGs4T2lP?=
 =?utf-8?B?ZzE2Y2hPcEhhQllNRXNpYTlieDZlTHhaczBXMUplUUVFYkdZWjNMa0wrOXFN?=
 =?utf-8?B?OHBhU0xKMndOOElxSEp4cDErcEt2eUpjRjNEMWxGVmJpdE1pWC9PMU9OSGVR?=
 =?utf-8?B?dlFScERTREc0bElYUlh5RmdXSmRQYUtTVnBCZHVTT3lJa3VLMmNEWlJkbGFo?=
 =?utf-8?B?MS9WR3NvaG9NUkk3M3VzRUl1Q3hPaUh1MGpzNmU4b2hsVVZiNkoycllUS1Zm?=
 =?utf-8?Q?tdqsxzN29e74Fer+wS9EqsCp/6N0P7JP5C?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 612f94f4-a7c3-4742-a657-08db8f430efb
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jul 2023 08:17:18.1869
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: feHMNLX8GME0C7YJRWmEgFIjsS2ahFxm7N8F8pgO00zPdqO2ECGkXh3bIL+3Jgln0nwIN7xfnRkzGq9HoLGlPQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR10MB4886
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26
 definitions=2023-07-27_10,2023-07-26_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 phishscore=0 bulkscore=0
 malwarescore=0 mlxscore=0 spamscore=0 mlxlogscore=999 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2306200000
 definitions=main-2307280074
X-Proofpoint-GUID: kx19H3ZiBzmIjFgj5kP1EBCuiRMlWmeX
X-Proofpoint-ORIG-GUID: kx19H3ZiBzmIjFgj5kP1EBCuiRMlWmeX
X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 28/07/2023 07:17, Jing Zhang wrote:
> Currently just add aliases for part of Arm CMN PMU events which are
> general and compatible for any SoC and CMN-ANY.
> 
> "Compat" value "434*;436*;43c*;43a*" means it is compatible with all

As mentioned in patch 1/5, a comma-separated list seems a better 
delimiter to me

> CMN600/CMN650/CMN700/Ci700.

It would be good if you could provide a link to where you got these 
events. I think that it is the publicly available CMN TRM document.

> 
> Signed-off-by: Jing Zhang<renyu.zj@linux.alibaba.com>

Apart from comments, above:

Reviewed-by: John Garry <john.g.garry@oracle.com>