Received: by 2002:a05:6358:c692:b0:131:369:b2a3 with SMTP id fe18csp977995rwb; Fri, 28 Jul 2023 02:54:14 -0700 (PDT) X-Google-Smtp-Source: APBJJlHJqAv6YjpBpz8fmPnfS2SidHyCz68A8RMDvnINpZH7eYMY0kJAJST5I45rB99xto5EL8/O X-Received: by 2002:a05:6a20:3d02:b0:12c:e3c8:8c7 with SMTP id y2-20020a056a203d0200b0012ce3c808c7mr1196799pzi.41.1690538054201; Fri, 28 Jul 2023 02:54:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690538054; cv=none; d=google.com; s=arc-20160816; b=hB2FkS9rwFI9OnbESze5Vk+sAjX7l9siDP6x1bgC7AQyXDYhy7Aru4UIBBPhsQqW72 ocCh55uMtFOMA/qTp1ZOcqRXlntQbVmFrSHffOf5viyeKNqyGxCe/XaRvfjb0SribN+w JFuKqAj0tYSblnKB2s+n7pQhsMVUAFYSn6vERH2qbOEz4xUT0ty8JPMazzDJtsekCj/2 f3oexDYW0Od5YJpdWSeQ7H9AcsE3qQjXCj/16rX9m6haLAKlXsxf8BqLIoWOLZ3sRgr7 BO7LpCsQyKGzbihw8kbbjgTYuFgGFi88C3VgTeRej2Pnkvieh6FA/7232hImR2yuhHyh Aw/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=eEXDOg8FLRF0KyVi32PAZbtHry6lLqLMGmBKMcsXwAs=; fh=qlGNfjOuzCa/l2toUC+STTwH1z+npHd+NH9mes1TmWw=; b=HLd2PNXPnqLA74li8a+DEjRREg0UkwglDcRUoapJRKj1w+Yo9+WNMN5vU0wyxQJGIp hcL3C2/yXrxpwGC4Z9J0xKQdXKip4dO7726WAu7czRfM0fnIWhq1ZGus6etmrg6WcC2O 6ONRWf0/bv4ZsA+sFmBwAwa87XNpBHIpcx1an/7m+wD6Sl7j/IuIr81UmZtzkyKEh/+M 8uY2VhUGlfXb8RcADhtpRgsc+Z5W5x3mScJ9KbeNenTejLZnq9zsULKAdBB4HnrDtcTo 3nKhA+5/ix3IY6EUH/iQ6TYm+Smm46jVW9Dksp2m7eyRNFEF1j18ZT1GN4e0UWcRc+6C 6Mlw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e5-20020a17090301c500b001bb40ba3ab2si2923277plh.213.2023.07.28.02.54.02; Fri, 28 Jul 2023 02:54:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235126AbjG1JXu (ORCPT + 99 others); Fri, 28 Jul 2023 05:23:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43484 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235736AbjG1JX0 (ORCPT ); Fri, 28 Jul 2023 05:23:26 -0400 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:237:300::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0DC4C59EE; Fri, 28 Jul 2023 02:18:02 -0700 (PDT) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1qPJal-0001Mm-8P; Fri, 28 Jul 2023 11:16:59 +0200 Date: Fri, 28 Jul 2023 11:16:59 +0200 From: Florian Westphal To: Daniel Xu Cc: kadlec@netfilter.org, edumazet@google.com, fw@strlen.de, kuba@kernel.org, pabeni@redhat.com, pablo@netfilter.org, dsahern@kernel.org, davem@davemloft.net, alexei.starovoitov@gmail.com, daniel@iogearbox.net, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org Subject: Re: [PATCH bpf-next v6 1/5] netfilter: defrag: Add glue hooks for enabling/disabling defrag Message-ID: <20230728091659.GA15474@breakpoint.cc> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Daniel Xu wrote: > We want to be able to enable/disable IP packet defrag from core > bpf/netfilter code. In other words, execute code from core that could > possibly be built as a module. > > To help avoid symbol resolution errors, use glue hooks that the modules > will register callbacks with during module init. Reviewed-by: Florian Westphal