Received: by 2002:a05:6358:c692:b0:131:369:b2a3 with SMTP id fe18csp978656rwb; Fri, 28 Jul 2023 02:55:13 -0700 (PDT) X-Google-Smtp-Source: APBJJlFQPlCByI2Hhl5JSO8u7yxJZ4S1HQrSVWyNG7yqhN5N7p2PpgxqxsjQAVkzOll21HQ2BeVe X-Received: by 2002:a05:6808:1a05:b0:3a1:c93c:6d28 with SMTP id bk5-20020a0568081a0500b003a1c93c6d28mr3506896oib.23.1690538113308; Fri, 28 Jul 2023 02:55:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690538113; cv=none; d=google.com; s=arc-20160816; b=PAj2Ri85zJp4W7Sj75GiAuPF98gNXJR2rzQfPF9q6uYWqVgDChp263q0uE1TclHGj+ r2lo0DtKTOaF1yGpTvHavCWHMZXhkCZnl48NnD6BSBPtnThcKB2o2MXJZ3w2fRNVDnYO fzbZeuE0mAKXGQ60Ys13S+V7am88t57Nws5McccNIUbLkhs0BSk33GIytpBtbL6pciwl v6u+PhtyhnbT464GwgVjB6ZqswluO74gXo6/c/NiU2QdNLpyrRlx/gYKSPydQCjKkE1O m4ZPN+VrCOLb7NhXO/Vs7M8Ag4Iw3Uc53KLzxY4ze5/WeFIzv4Kwyyq91Anoynf6i8R2 gCbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id; bh=rQzNxNUZCqF5UiJyJq9W2uV3Eo4aXp2G/6YChOu6k7U=; fh=6ykKgdH0/l4nB3th0tYHe+NHk79qziXz+1uqoXzDZS8=; b=DvUtOnFm5xNIgQAb2CJi+J0nBKFaIQIHGwsfGnySmk5bZ4Nr9Hfzn+BByrQhPsPbOG FO6dWuyR2nEGuzoseVjydw3DoErdh1grGBNOfUGbuIzvvW/HjSMccOVcvI6Mh0f17l7p sQ0dKuK8FaSFBlYp6JxtsKqK4h14ZsyFuIFDt/reYc3CRgdCU3DSeLwn1X50AFLnhSXP 6b30FldSfMnLcNGA+MWPzb/xmQd3bzF1frgMgfsZROeLMqSjpCxg/iWoh/AR/AfwMUTP PrL31/OOOcLNU1E7ACajDIRjpIIcsYaI51HS7C8JRllYdMLn5T2L5ht+2u8Nv03fSw3Z RDjw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l15-20020a170903120f00b001b9eb5d1e39si1788277plh.114.2023.07.28.02.55.00; Fri, 28 Jul 2023 02:55:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235063AbjG1JDH (ORCPT + 99 others); Fri, 28 Jul 2023 05:03:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55336 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235100AbjG1JCr (ORCPT ); Fri, 28 Jul 2023 05:02:47 -0400 Received: from ex01.ufhost.com (ex01.ufhost.com [61.152.239.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C5F252D5E; Fri, 28 Jul 2023 02:02:43 -0700 (PDT) Received: from EXMBX165.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX165", Issuer "EXMBX165" (not verified)) by ex01.ufhost.com (Postfix) with ESMTP id 27C6624E31A; Fri, 28 Jul 2023 17:02:40 +0800 (CST) Received: from EXMBX068.cuchost.com (172.16.6.68) by EXMBX165.cuchost.com (172.16.6.75) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Fri, 28 Jul 2023 17:02:40 +0800 Received: from [192.168.120.59] (171.223.208.138) by EXMBX068.cuchost.com (172.16.6.68) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Fri, 28 Jul 2023 17:02:39 +0800 Message-ID: <23769fc1-69cb-f237-6488-f2322368e309@starfivetech.com> Date: Fri, 28 Jul 2023 17:02:37 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v5 2/3] spi: cadence-quadspi: Add clock configuration for StarFive JH7110 QSPI Content-Language: en-US To: Conor Dooley CC: , , , , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "Emil Renner Berthing" , Ziv Xu References: <20230719092545.1961401-1-william.qiu@starfivetech.com> <20230719092545.1961401-3-william.qiu@starfivetech.com> <20230728-retread-starch-3399b921718a@wendy> From: William Qiu In-Reply-To: <20230728-retread-starch-3399b921718a@wendy> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [171.223.208.138] X-ClientProxiedBy: EXCAS064.cuchost.com (172.16.6.24) To EXMBX068.cuchost.com (172.16.6.68) X-YovoleRuleAgent: yovoleflag X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023/7/28 16:58, Conor Dooley wrote: > Hey William, > > Since you pinged things, I had a quick look. > > On Wed, Jul 19, 2023 at 05:25:44PM +0800, William Qiu wrote: >> Add JH7110's clock initialization code to the driver. >> >> Signed-off-by: William Qiu >> Reviewed-by: Hal Feng > >> Reported-by: kernel test robot >> Closes: https://lore.kernel.org/oe-kbuild-all/202306022017.UbwjjWRN-lkp@intel.com/ >> Reported-by: Julia Lawall >> Closes: https://lore.kernel.org/r/202306040644.6ZHs55x4-lkp@intel.com/ > > These, as pointed out on the last version, should not be here. > kernel test robot complaints about un-applied patches do not get a > reported-by etc in subsequent versions of the same patchset, just as > comments from human reviewers do not require reported-by tags. > > These tags should only be used when the code has been merged & you need > to create a new patch to fix the issue. > > Hopefully, if the code is otherwise fine, Mark can fix this when he > applies the patches. > > Thanks, > Conor. Hi Conor, Fine, I will drop it in next version. Best regards, William