Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 28 Jul 2023 10:52:23 +0200
From:   Daniel Wagner <dwagner@suse.de>
To:     Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Cc:     "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        Chaitanya Kulkarni <kch@nvidia.com>,
        Max Gurtovoy <mgurtovoy@nvidia.com>,
        Hannes Reinecke <hare@suse.de>,
        Sagi Grimberg <sagi@grimberg.me>,
        James Smart <jsmart2021@gmail.com>
Subject: Re: [PATCH blktests v1 05/11] nvme/{041,042,043,044,045,048}: Remove
 local variable hostnqn and hostid
Message-ID: <rqcyq6qhhiulveoi5t3sp3tkcwlyhwmh4qpvplskssfd6d2cr5@u53vr5xlizyo>
References: <20230726124644.12619-1-dwagner@suse.de>
 <20230726124644.12619-6-dwagner@suse.de>
 <keqqev3paa2rtk5ysaitglnqfokeph7uvqh4z377atjlow65eh@buvr5azvul4s>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <keqqev3paa2rtk5ysaitglnqfokeph7uvqh4z377atjlow65eh@buvr5azvul4s>
Precedence: bulk

On Fri, Jul 28, 2023 at 08:10:09AM +0000, Shinichiro Kawasaki wrote:
> On Jul 26, 2023 / 14:46, Daniel Wagner wrote:
> > Commit acc408477e85 ("nvme/{041,042,043,044,045,048}: Use default
> > hostnqn and hostid") switched the test over to use the default
> > hostnqn. It missed the change to remove the local variable and
> > use the def_hostnqn/def_hostid directly.
> 
> [...]
> 
> > diff --git a/tests/nvme/043 b/tests/nvme/043
> > index 6392bd8b2492..5569a7a58ad5 100755
> > --- a/tests/nvme/043
> > +++ b/tests/nvme/043
> > @@ -26,17 +26,13 @@ test() {
> >  	_setup_nvmet
> >  
> >  	local port
> > -	local hostid
> > -	local hostnqn
> >  	local file_path="${TMPDIR}/img"
> >  	local hash
> >  	local dhgroup
> >  	local hostkey
> >  	local ctrldev
> >  
> > -	hostid="${def_hostid}"
> > -	hostnqn="${def_hostnqn}"
> > -	hostkey="$(nvme gen-dhchap-key -n ${subsys_name} 2> /dev/null)"
> > +	hostkey="$(nvme gen-dhchap-key -n ${def_hostnqn} 2> /dev/null)"
> 
> As I commented on the previous patch, the left reference to subsys_name is
> replaced def_hostnqn. It means that the -n option value changes. I guess
> this change is fine for this test. Could you confirm it?

This change should be in the previous patch as you commented in the previous
patch. This is an artifact from my devel steps.