Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <43bbd12b-4754-92d1-4000-1ba928d2a8d4@amd.com>
Date:   Fri, 28 Jul 2023 09:48:31 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH 2/3] drm/scheduler: Fix UAF in
 drm_sched_fence_get_timeline_name
Content-Language: en-US
To:     Asahi Lina <lina@asahilina.net>, alyssa@rosenzweig.io,
        Luben Tuikov <luben.tuikov@amd.com>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        Sumit Semwal <sumit.semwal@linaro.org>
Cc:     Faith Ekstrand <faith.ekstrand@collabora.com>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        linux-media@vger.kernel.org, asahi@lists.linux.dev
References: <9c0cff84-45b1-268f-bdad-38c16316dbc3@amd.com>
 <20230714-drm-sched-fixes-v1-0-c567249709f7@asahilina.net>
 <20230714-drm-sched-fixes-v1-2-c567249709f7@asahilina.net>
 <bef7ef62-3cd9-6ceb-5eb4-5ae0c0236778@amd.com>
 <de502b41-2864-db1e-16a0-8a5d5e0e4ad3@asahilina.net>
 <d9dc2fd5-d054-dbf3-72b7-fe9deaa46350@amd.com>
 <236422117088ca854a6717114de73d99b2b9ba2f@rosenzweig.io>
 <a42bd218-6eb5-6ddb-bbb4-d25118c59f40@amd.com>
 <7b564e55-a9b7-0585-3cf1-d1f132f9a918@asahilina.net>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
In-Reply-To: <7b564e55-a9b7-0585-3cf1-d1f132f9a918@asahilina.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cExDWitDTTN6Q0Rmc2Z2SkUyVU92bTVDSVhLZDVQc3VycVB3VW50cm1zbDlq?=
 =?utf-8?B?ajJBMFZVUXdtVm8wU1FON1MwRWlpMHpUTFBDNTNGODlDVE4yc21sNmpXTWNB?=
 =?utf-8?B?bGlrRjNuOC80U0tuV2dUbDhSWWQ0d29jTVJJRnArbStyUjZpeUU1Sk85bGky?=
 =?utf-8?B?WjlHQzUyWnZ4ay9lNzZZb1BJMDhydGxJSlBlVm1Ka2pMMXRSa2k4Nm1ITVZs?=
 =?utf-8?B?aUFwZ2tpVEFpNWpZOG1BWmpOSUxPOExpTFhWK0Y2NjkvZEQzZ3lRbXNvRDky?=
 =?utf-8?B?TUJPaWhGK2l6VG85VXhwT250djNMcDNvbFdYei9QTXQ5OExlZzFKdDRXS0xu?=
 =?utf-8?B?Ym04SDIxVzNBUHZsS2dEczlZWGZlSllHMktWOFRPQktUbFBTTHlQd29lTDhz?=
 =?utf-8?B?dDdna1gyZ1NRZ29MSm9VWlBCZ3A4Uk1EajZtQXpKU0tMOFlzS09OT0xCZmNU?=
 =?utf-8?B?MVVuYmJSR2ZWS3NKNnp6VnNWeXljUGNKZXBOMEo2MWFEQnVCMUtFLzdiTE81?=
 =?utf-8?B?dTNmcU5OY0F5d3dsRzhwb0tHbWVMV0xybXhCd3ViMWJLeVc0YTZBZUd2a21m?=
 =?utf-8?B?VkFEdnRlUGJwNGxCU2s5SCtwY3F5M1ZLdFJ4TExOR0xMU05OdkwwaWc3bVQy?=
 =?utf-8?B?WkM0bVRITEhoUjN5R3pNYVZ5K3FEMk1SbzZGK3hldmNFY2ZWSW5oNWR1OU1a?=
 =?utf-8?B?eVhXMlBIZnZKL1FkVU9nNjFGM1pvR1ZxUVdKVFV6K0l0TEFKSmtBK3RTYXRB?=
 =?utf-8?B?V0VraTlxUmh4Y2Vxd0k0Qm5qZkNVZGIxRTcrS3VFODh3ZkJIcHFQSmNDeVo4?=
 =?utf-8?B?MVdDaWliU2h2Z2N3cnRlekszeGQ3K0NKeUV1U2xKalJoOVRwVVBFMERqckJF?=
 =?utf-8?B?S01lU3dLbnZYOUpocnZjUFZjdWNZaUNYTlhaL0dmQXdqcVVhNVJjcTVKV0Rm?=
 =?utf-8?B?OTNBSk96N3dtWHc5ZlBkNjR5ZlhxVk4vdEk2MzF6b25WNXNNT3NtN0ZwZm4v?=
 =?utf-8?B?c1pGTXVIU2hTcFBTaUtnU2hkZ1lVUXlKS3FkbDBONW43dnFIZUhCOW9nS2Fk?=
 =?utf-8?B?TC8zdVBtQUVsdHlXMzFudkxyd1I0TEZBb1FEc0k2d0U0YkZMcGZncTZPK3J4?=
 =?utf-8?B?bGNkU0wvOGlLcDZyNzJldk50L25lWlNvSUhHSGQyMEtieHhiUFF2Skh5UXIx?=
 =?utf-8?B?c1VHVUd2ZHkzTjhxQXl0eHB6aDdacVExb1hZaEYxYTlRQWRjMG5tV0VYUTlU?=
 =?utf-8?B?R2JCZDZFOEtxbEZkeEtrMzFGSlNtSjRtdXQrWG8zNk8xNVdpTmpnMmh6d1Nw?=
 =?utf-8?B?bUg4ZjJZMWpDNytkakxDNXpaUmp3Y1FNam82MTd1N1BoYmFuZno0M0lZYXJw?=
 =?utf-8?B?M04vUmp2Z2ppNHo1OVhXT0VTR3kvMkJPemlBZk90ZUJXWDVEK0Y3dUxKRkdG?=
 =?utf-8?B?QmdFcm83b0NoMWxRc3BWdHM3MHJLS09hVCtLZWhLQ0syVmFlR05rQS9sWkhi?=
 =?utf-8?B?dkhxQmk4TUdqY0paZ2k4ZGU3ZDg3RTQ0cnh5WTExQk1UMnFvaHRxSVFwZkkr?=
 =?utf-8?B?bndSV0Jpc3RjWHVNMERob0QwTy9iQ09nc0lBMHFqbE9Cc3FJaHJnNTB1eTJS?=
 =?utf-8?B?MUNidjZhUEtTMmRiL0VTa0grRkxRdlcwdHJZcGFMTWlXemZBdkE0anEvblJk?=
 =?utf-8?B?UFNLYVRGZWVzd0tpcCtOdkZhVWZWZWtWdWs3SzNYd3NiZ0JpNXBUUmErR0RY?=
 =?utf-8?B?cTRwYVBiSGVmZmdpQ3MxQ2dxWEdtUXQrL1hEZ2Y5TDBpTzhOL1BoYWJ2R3ZX?=
 =?utf-8?B?ZkpYQkZOVFFMTVZ3bUNXdktFemtwQ2ZFMm96Q1cvU1h2bGcvNTg4NXllQVQ1?=
 =?utf-8?B?VTd0aDFzZEJWTjJlZzY2UEVrSkYrMVNaVFVUSXRhbUtyWlNCT2IwOWFWYXgx?=
 =?utf-8?B?cnVXS3N2MkJucUU3cVUzMHZLNGlTdUdMajJTQmF4YXU5U1NDQ2ExOHdwN0R5?=
 =?utf-8?B?djdib1lEdDVwRThreE0wV2txRnFhMlZMcjRBVUlRMUcwdUl2TUlRRGNBYkp4?=
 =?utf-8?B?TW1ITmtVOUs1MU5QVjlBUlZiRm9rWU9rVHdsQnBzZW5sQ0w4alhnWmNJdGFS?=
 =?utf-8?B?NFQwS0hIMEJwV0tCZHVFRkhRUENpS2s3SExFTUkrMk0xWU9hREppalRBR3Fm?=
 =?utf-8?Q?4qRhexDC1i7ZMBGtqDtLZZ84o/dC32xmpw1EWn2YGJWE?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2b72c003-ce33-4dae-c304-08db8f3f0cdb
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3587.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jul 2023 07:48:36.7282
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iEG6lPIx0Kb59e+dn1Jr6z24CZHg6fpPchrFtKLR9/kJjjYba5cjBdoAVUxLeQbd
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB8169
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 18.07.23 um 04:35 schrieb Asahi Lina:
> On 18/07/2023 00.55, Christian König wrote:
>> [SNIP]
>
> I give up. You are ignoring everything we say, and rejecting 
> everything we suggest. We've already explained why drm_sched doesn't 
> work for us. I'm tired of repeating the same explanation over and over 
> again only to be ignored and told I'm wrong.

I'm not telling you that you are wrong in any way. What I'm pointing out 
is that your solution won't work upstream and you need to take a step 
back and think about why this won't work.

>
> I'll start working on a new, much simpler Rust-native scheduler based 
> on the workqueue Rust abstractions which are in review.

Please note that when you are implementing a dma_fence interface you 
also need my acknowledgement to get this upstream.

Additional to that Dave and Daniel might have objections to this as well.

Regards,
Christian.

>
> ~~ Lina
>