Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4b2db6b2-bbb5-77d9-4e7c-148b33882a85@oracle.com>
Date:   Fri, 28 Jul 2023 09:18:47 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH v5 5/5] perf vendor events: Add JSON metrics for Arm CMN
Content-Language: en-US
To:     Jing Zhang <renyu.zj@linux.alibaba.com>,
        Ian Rogers <irogers@google.com>
Cc:     Will Deacon <will@kernel.org>, Mark Rutland <mark.rutland@arm.com>,
        Robin Murphy <robin.murphy@arm.com>,
        Ilkka Koskinen <ilkka@os.amperecomputing.com>,
        Namhyung Kim <namhyung@kernel.org>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-perf-users@vger.kernel.org, linux-doc@vger.kernel.org,
        Zhuo Song <zhuo.song@linux.alibaba.com>,
        Shuai Xue <xueshuai@linux.alibaba.com>
References: <1690525040-77423-1-git-send-email-renyu.zj@linux.alibaba.com>
 <1690525040-77423-6-git-send-email-renyu.zj@linux.alibaba.com>
From:   John Garry <john.g.garry@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <1690525040-77423-6-git-send-email-renyu.zj@linux.alibaba.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T2ZiNE55SmR0bE5BdFI2bWNEdlNhRmN0MkxheDRiS1BQemowbXFTRVE3K1E5?=
 =?utf-8?B?VDY2OTlxb3hCRDFwTVJzc2pqOFpvYnFQRGVvbDMvV3BRL0gzS20wNXFsZXlL?=
 =?utf-8?B?cXRoblZkbUwvZlFNbmNranErUzJqZWhmeWowLzh3L0Z2YS9NdzRZTU1wWjly?=
 =?utf-8?B?L1lKd2hmVngyNDVJNHVNdFpyUDhsa1N0eVhFUTA5TkJGcnBvbGdpSE0wUkdL?=
 =?utf-8?B?Z0dHeEJiWnlXaVlEak94U3lEU25PK1BhK0ZjQVRMMWRBZXF3bEp3WXVWdkJt?=
 =?utf-8?B?ZDErbjZvOHd0UURFSnFkZGtuZ1ZCdmxXa0F2UTBNQjNibERMNnRJekN5Vnkw?=
 =?utf-8?B?Z3JZbjc1QlVHQjJzcU81TjRXUUFnWTlhY2pibCt1cThoVkJtRmd3Q2dOMTkz?=
 =?utf-8?B?eDNSU05uRXVlZUVHTWJlRTZadFloWEc1YTg3Nllac2lLY2NpUkVuYUZFczJs?=
 =?utf-8?B?QWpIOGZteXNjVFJvK2Z0QjNmb2swRHN0Rittb0M3MElKZXJOdW9ZRktydVg5?=
 =?utf-8?B?UWc4aXkrcjhHVkc1dHFGSC9rNmlrSTBqMkJrZmhDRlQ5V0ZqNFhnQzlkR2xa?=
 =?utf-8?B?R3QwOHdFYWtQZlkxY3lQUnZYMGtUUGNDN2ExSkM2bURGQ3BSbGM4NGZYcElq?=
 =?utf-8?B?RUQzbUMweWlyRXV4cUZZdEVMNjVDYXNYdlpCa1JQNlhuQ1EzMVN5eVBIb1RS?=
 =?utf-8?B?SjVqQnhmdEsyNVpIaHYrQml0U3BQUlRMa2xnY2wyL1VPazVHSWMxR3JBRlN4?=
 =?utf-8?B?N1E2aUNmSUZQRlVEL0VhS2s0N2RQVDh5d1dXM2M1bi9oWFVLbVlVaUs1OHpt?=
 =?utf-8?B?bkxNNk5UZW5PMDBvOWxHVk1KaEJ3R2x5dGwyTU55SHYwYTBIcmJmUlBjR0J6?=
 =?utf-8?B?WWhyemZHMDNNQ1FDZndlN3MwcThicHRrV1dSUVFBMisxdXpXVHQ4cWIxYzVw?=
 =?utf-8?B?NnBYeXd5bHdjVnI0YkpkK0tSeTgzTDRDM01MS2hyRFZXUXozRE4wSGc5YzY5?=
 =?utf-8?B?V1N2NERhN0NqbE0zQlo5Q1g2U3pSMXlZek9JSmsvWUNJYnhpYWlUSkVyS2JK?=
 =?utf-8?B?bmxpRFErMWxTMEhKWjQwYzN2bHFlN2d2WVpOSVBMTnBWaTQ0NWdGUUV1NUoz?=
 =?utf-8?B?OFgvWnpwUWhPbXpOVGt4WkhCZngxVDFXOUFxNE9ZNitNeUFFSmwzcnloaUNF?=
 =?utf-8?B?STBpWEtpYlh2dExMbDFuZ01EOCtob0NuTjN3ajFva1Bpbk90U1BjdTYvLzVa?=
 =?utf-8?B?SHVmVHBGOUYzbi96UW1PRFpsMGhJL2o0ME40aWdoWGtNL21IZ0ZabVQ2VDlI?=
 =?utf-8?B?dXBldVZTQW1YZkxtTlJqQ1MyczB0STQ2TlV1N1RvOGFSamZnYUFUMlVvYU40?=
 =?utf-8?B?NWsrZnZwanArMzE4NG1xM3BoWklqZGhmeTdPZ25sL1J6T1FpOTYwaUhubkxQ?=
 =?utf-8?B?bXlFWWF4Z1FVWGpCNUNENllIQXFWQlhVVnBHZkJ0UEtSUHJQRlZXRXBKOFc3?=
 =?utf-8?B?Ly9QL1lub1U5dHE1UFJWK3RtQkJUQ2NBMU9iUkVJQTUwOHZrNFdkNXpuNHJw?=
 =?utf-8?B?Y2N5WnNTZWgvNUhMU2J2V054QllxdDlLdEtja3ZjeDAzKzJ0TEtJSExkWDhD?=
 =?utf-8?B?eWJqTVZYeXJBSWVTUFlGWnBRL1dWVFIyRHdSVkpzeERxWWJXVXZlb0FDNEZp?=
 =?utf-8?B?NUh4RkVtdmJVY2FvdkpLQStkeHJ2M1k4eHFFQUZURkhRU1ZsYUErcWk3K0k0?=
 =?utf-8?B?TEZVVEoxNlZVVEtQUFk4M3NCSlRWU3o2cUMxVmdBUGJucWRJRENEaTlPS1Ri?=
 =?utf-8?B?bk80MVQ2OVl0RndLWWh5Q201aS9OWkMwc3hVVFBCTmdPQ2VOTkdPOVlJaGpz?=
 =?utf-8?B?MVpCazBIOVNnWnpmZkI4YmVLaWFZU2lJd0NGbGEwSlgzWVQ1NDFWVWszWFkz?=
 =?utf-8?B?dGlFTFdUMW9oRWc4MW0vNlBNWXZNMkRPTXUyRWFZa0ZrRlNOaUhKLytMcW9O?=
 =?utf-8?B?d0JTWVdvNVFualJPMyt2THBzajJta2xkZDlKeXAydjJvenZaejFoakhmdXFu?=
 =?utf-8?B?NnBrM2tsWG1BTVVDU3M1akRuVHgxSFQvM2t3UnpzeUcxRUpyNnk3M0FkOVR3?=
 =?utf-8?Q?NCEb+HarXYY4gm3zFTkgZCuMI?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?ZS9UaHRzQThucnAwOUNFc3lwalBJYnlhaTVZeHoyeHVLb1ZmMmdtS3IrZGlG?=
 =?utf-8?B?OXdJcTZrTGhOaFlRVVA4TitVeUVzVWxDL0tnNHROODhzR09WQVNJYWxKT1pC?=
 =?utf-8?B?M2VEeDh2ZG9LTTcwRExzTURYdXk3Y2x1MjNEQnRvNmkxcDJDYkhhWmVudzhF?=
 =?utf-8?B?Qnd4WnVnVTNvMmlreHhWOFJubnBQb09OcUNkempWRllWeWQ1amJsY3BDcTNV?=
 =?utf-8?B?QU84c1JnTGVzL0t5endEWDl2QThxWUxGYzcvNUJIVW5abW81QWdIOHFTK1ZC?=
 =?utf-8?B?VUluRnFQRjdWMmVlMEVrVEhNbFE2MUlYVmlXN2hHeVJnQVVuRGsyZlJGdkoz?=
 =?utf-8?B?Vk1mRXpnV0VTTGFoZ2RyaENYcndLSHU2Tms2a2VxS3NaOTB5OHVpTWZRMmhS?=
 =?utf-8?B?eG9HTlJSUVpqSHlzcFFreVBHMTkyRVUzaTJjekcydE9QbTBESkQ1dHhvMzFy?=
 =?utf-8?B?TmxlZUFrNzZUaE8rYVNFNElaZ1Jkcnh2SXNDMytlRmJJT0dsU2diSHdSYXRz?=
 =?utf-8?B?bWRCU3BzRWZsVU0xQjBBWjlQMCtwSkg4MFNwNjZjc09qSGhzWm9yMU5Ya3Mr?=
 =?utf-8?B?NnBRZnJ2QUJvTmRTZmNCblk2VWpsS2lJRVpiSEw4aWdzcUowVkNLREE3T29v?=
 =?utf-8?B?WHRQOCt6M1ExdDJFdGt2YkpiMzIzQ1kzaWZuOUVwcGNYcGlrSjF0aG1NaThw?=
 =?utf-8?B?S0VOSDV2VXVLaytKODV0bmJNU2VYdExpMDZKMXprWGM4OStEZy92V0lnTGg2?=
 =?utf-8?B?dEI4U204czJydlUrMFZXWmY0clJkMnNUcWJIcTFpUXlpZThtQXFkcERndWdB?=
 =?utf-8?B?THFsMFFRZWZOaUZtRWxiamFsc2gzVXMxdHRoRkxldGVXUFBrbDZnOE9sOTFO?=
 =?utf-8?B?T20yZ0FBQ216V3F6bVJwUy9EVzIvOUlOdTQxbEVRUjFpRzlPUFpOY3NWVVg4?=
 =?utf-8?B?eTBKY09BNEI1SGpvaXBmUm9hcDBNZlBENjUxRlZHV0RlZnlaYS9oNjBPLy9I?=
 =?utf-8?B?RzVKYzFiREVjdVRVRVNyNklaVTJ5QXg4Mnk2VFZvdERXQ0Y1dTlsOGwwbFJT?=
 =?utf-8?B?Y2xRUUMzK3NnRUNoTkxDcWpIclpCK3FVOUMwdVNoN2YwajRuWkRyOXFoakp3?=
 =?utf-8?B?N2NoRmxPM3dZNFF4VTBRdUpmM3lhWnllcjJQMjQ1ZGwyR2xqbzBtSkhzK1dJ?=
 =?utf-8?B?MklhSWcvMzd0UVcwcGZ6UlZHMUNQR1BZeVo4VWM2NXR1SnNwYkxkbThBQ0to?=
 =?utf-8?B?WmNoVFlHZWtCQjVtTzM5VndyVkFQR2J0dW9sM0doWHF3bUFiY1RkVG9YUjBK?=
 =?utf-8?Q?/SN9yR2wwNkr5VrlVf2LL2da816ZZHmKIk?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 95b8bae5-2bba-4d84-402e-08db8f434652
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jul 2023 08:18:51.0278
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: dRlXNJ4zX1ojAqCeEsiGbtakgvwPbsbKJtD944B6LmW0dv7uUOIkN89lS6fduEIVwMQSoTKdWtFEDguPxHmWwQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR10MB4886
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26
 definitions=2023-07-27_10,2023-07-26_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 adultscore=0 bulkscore=0
 mlxlogscore=999 suspectscore=0 phishscore=0 malwarescore=0 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2306200000
 definitions=main-2307280075
X-Proofpoint-ORIG-GUID: z_jadhjSK55JMRqIFAhU7b1Pg4OWy22k
X-Proofpoint-GUID: z_jadhjSK55JMRqIFAhU7b1Pg4OWy22k
X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 28/07/2023 07:17, Jing Zhang wrote:
> Add JSON metrics for Arm CMN. Currently just add part of CMN PMU
> metrics which are general and compatible for any SoC with CMN-ANY.
> 
> Signed-off-by: Jing Zhang<renyu.zj@linux.alibaba.com>

The same comments apply here as patch 4/5, and, apart from that:

Reviewed-by: John Garry <john.g.garry@oracle.com>