Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20230727154108.308320-1-umang.jain@ideasonboard.com>
References: <20230727154108.308320-1-umang.jain@ideasonboard.com>
Subject: Re: [PATCH 0/2] media: i2c: imx519: Support for Sony IMX519 sensor
From:   Kieran Bingham <kieran.bingham@ideasonboard.com>
Cc:     Lee Jackson <lee.jackson@arducam.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Sakari Ailus <sakari.ailus@linux.intel.com>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Hans Verkuil <hverkuil-cisco@xs4all.nl>,
        Shawn Tu <shawnx.tu@intel.com>,
        Nicholas Roth <nicholas@rothemail.net>,
        Mikhail Rudenko <mike.rudenko@gmail.com>,
        Marco Felsch <m.felsch@pengutronix.de>,
        jacopo.mondi@ideasonboard.com,
        Umang Jain <umang.jain@ideasonboard.com>
To:     Umang Jain <umang.jain@ideasonboard.com>,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, linux-media@vger.kernel.org
Date:   Fri, 28 Jul 2023 09:52:08 +0100
Message-ID: <169053432818.137962.5791887898514618663@Monstersaurus>
User-Agent: alot/0.10
Precedence: bulk

Hi Umang,

Quoting Umang Jain (2023-07-27 16:41:06)
> Series adds driver support for Sony IMX519 sensor.
>=20
> Lee, can do add S-o-B tags please to these patches
> since I've updated your email IDs at various places from
> info@ to lee.jackson@.

Can you dig and find out what your start point was here please?

This series should already be numbered at least v6, there are 5 previous
postings. The most recent of which was already Signed off by
'lee.jackson@arducam.com' So that makes me weary that v5 was not used as
the start point for this refresh.

Previous versions are identifiable here:

- https://patchwork.linuxtv.org/project/linux-media/list/?series=3D&submitt=
er=3D&state=3D*&q=3Dimx519&archive=3Dboth&delegate=3D

Could you check through any previous review comments and make sure they
have all been addressed too please?

It would be useful if the cover letter or patch described a changelog
from the previous version too to identify what has been updated.

I see the kernel test robot reported failures based on missing
dependencies.

It's helpful to list any dependency information here in the cover
letter too.

--
Kieran


>=20
> Thanks!
>=20
> Lee Jackson (2):
>   media: dt-bindings: imx519: Add IMX519 DT bindings
>   media: i2c: imx519: Support for the Sony IMX519 sensor
>=20
>  .../bindings/media/i2c/sony,imx519.yaml       |  113 +
>  MAINTAINERS                                   |    8 +
>  drivers/media/i2c/Kconfig                     |   11 +
>  drivers/media/i2c/Makefile                    |    1 +
>  drivers/media/i2c/imx519.c                    | 2134 +++++++++++++++++
>  5 files changed, 2267 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/media/i2c/sony,imx5=
19.yaml
>  create mode 100644 drivers/media/i2c/imx519.c
>=20
> --=20
> 2.39.1
>