Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 28 Jul 2023 12:32:41 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Sergey Shtylyov <s.shtylyov@omp.ru>
Cc:     Paolo Abeni <pabeni@redhat.com>, Jakub Kicinski <kuba@kernel.org>,
        Zheng Wang <zyytlz.wz@163.com>, lee@kernel.org,
        linyunsheng@huawei.com, davem@davemloft.net, edumazet@google.com,
        richardcochran@gmail.com, p.zabel@pengutronix.de,
        geert+renesas@glider.be, magnus.damm@gmail.com,
        yoshihiro.shimoda.uh@renesas.com, biju.das.jz@bp.renesas.com,
        wsa+renesas@sang-engineering.com, netdev@vger.kernel.org,
        linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
        hackerzheng666@gmail.com, 1395428693sheep@gmail.com,
        alex000young@gmail.com
Subject: Re: [PATCH v4] net: ravb: Fix possible UAF bug in ravb_remove
Message-ID: <ZMOZSeUaVIaZzZph@corigine.com>
References: <20230725030026.1664873-1-zyytlz.wz@163.com>
 <20230725201952.2f23bb3b@kernel.org>
 <9cfa70cca3cb1dd20bb2cab70a213e5a4dd28f89.camel@redhat.com>
 <607f4fe4-5a59-39dd-71c2-0cf769b48187@omp.ru>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <607f4fe4-5a59-39dd-71c2-0cf769b48187@omp.ru>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?34g8gikSAchuxECgW1KsQeG1MWSctBh+rr9lXjikkQjUVNIPIshb1+izyMo/?=
 =?us-ascii?Q?ZETfTRThlpxaRrFeCpPPiNcTYgkUW/8OiBsQcjKpBn3vAgo0bOY1zewMFXrd?=
 =?us-ascii?Q?sVSYqkPAIU23PuCIMXCfuG+l6xwyy4rJDVoTL63NaISfZtspnPqJPrmWbnWD?=
 =?us-ascii?Q?vWGH72/wXuj95HcBB1SATH15eCA6GwTMt0BSIVs5zfcdI8KejRiZccqDxefd?=
 =?us-ascii?Q?/0OTC7Rh4tYzlF8ORuGktLU6cKo+/soetP7EQ4v1GprGOr++6RvJNlol3VoD?=
 =?us-ascii?Q?JXLgxSpwbVil+fyLiJU7PHWvC4ZlOUa3UVNCOqH1IFVQpcNlw6YkSYiGTeOW?=
 =?us-ascii?Q?Fj2fKy79g1sRNlBxdaDG8tJpus65Od2zgIzC1jPugtf+9TYnqsT0l9Lnpz+W?=
 =?us-ascii?Q?RGWnC8e715t4tdt+46DGrlh85w3ij9UPUpCZIkuciMgdMkE0Ycej3YrjbPwS?=
 =?us-ascii?Q?dvvv4YE1v+JJZK8M2Rq+Pj8iSOjjld4xPO8mtfO3mhsnXiNvqRH+Ztw9FEkD?=
 =?us-ascii?Q?aMqSR4gFlC/nG5uCHyPRR0GUTMeJHg92nPzbdK6TwLjr2F4oFlrpGqHH90Wb?=
 =?us-ascii?Q?v/Kn0bQmRrFmTP9b5gfEnz8uL7qXLG0dzr4+a/mZ6juFc2QGAKB86tIfme6d?=
 =?us-ascii?Q?O7YQbkmV1ZKieFa+K1Q4KDYc/22oYabViqeXyPtRvxaP+FS7CvnNMGJx560u?=
 =?us-ascii?Q?U/ZvHY6MAyAjq5mJewjsG4F7pzFAU4iY8++s/gkjwKRQhXml8FcdxtwSaWbr?=
 =?us-ascii?Q?6qhzPqHAkrFx+z+hVRyxlbAyH+CJdfAbGbFnS1ugWAu4it2rngLyBHpT+WMN?=
 =?us-ascii?Q?GYH/YCk3XRCosxh2Le5ge/k5/eqSvNd988/HcX47GsAFAKvlyG5BEX5rnKm2?=
 =?us-ascii?Q?/tqfB4u29yw3xiVm21Zjudj8/Va0ecd5YWhNj6oF9q+fU96y89oyPuWmrVab?=
 =?us-ascii?Q?0AOTmtXkG7ZISh3feC0dxPAvvTxMneba5gnYPtJVJUYjLcCdVcct+svQOw8N?=
 =?us-ascii?Q?MFwlsZoE6pVSx2niTQD+RCFf0MxtsUjM0QDwxRcC7CeVlCvPcv0wAqQDAlBC?=
 =?us-ascii?Q?jreCimU/k/3JBpE7BXMFKhMKIJj2io9oXGYlX21kgSnHwopAcGCp4J/X6Lm9?=
 =?us-ascii?Q?Y2uPLWvF4O8riMnW+ynKqAeZRWVGMapSrGSsVtjnCBHnLnE8WTHW2dpMyJt1?=
 =?us-ascii?Q?UfiG4Y3roZQwHsF4YtXTAU1TNKax8tSCsgDkDPCMkEow+juCFTQjefYImghi?=
 =?us-ascii?Q?6GGweWPSGamH6WbulAhpiJ/6coRrt5i5kOqh9fp7dkUZK0TSKttnP4xDZyhD?=
 =?us-ascii?Q?lSoMGs/CiC7VLg/MNDLJSGZ6kkCU852kgWAKUJzxo/QSmxQMkY1oodX7eDFq?=
 =?us-ascii?Q?HkAtPCZD8kvf1EOhBeSAOa7uZCvlmS0IQLqQl2T7q1TNwZgrodkC+V3ieLIN?=
 =?us-ascii?Q?qW9RWJFeJxwY9L6BBiIwPqAjx3rFRIuEO63t4KNoE7hrgr4H+gA5c19RBxjA?=
 =?us-ascii?Q?dnIGvKELdyYBF1bSNB97PjKBPXFekL1CMeR6gnHTLDbdk79Utl4O6SEnN50m?=
 =?us-ascii?Q?SKvfNcEex3cqO7vcm5zRbQLHUUoT/aUVVJa1+f5QEEJRePWvzIOUFD4MhCXQ?=
 =?us-ascii?Q?JE6AfoBDaRkVQMrsBp4+pLPxW/xnNrdL3unQ0bsWyuc9Myl7740aotQi4Dho?=
 =?us-ascii?Q?rv2u8w=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 70480a06-6ffd-4179-31c7-08db8f55fd4d
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jul 2023 10:32:48.9809
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YEGULMCnDIM9WrqCcJA1aAuXdj6ckq0lZu7RlHOMFhHMv8PZHUaAfhkFcSMYWetCknM0Wk38aB/73ee/1AnVj39FzpB8QiFf3b5Nt4JlL8E=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR13MB3878
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jul 27, 2023 at 09:48:41PM +0300, Sergey Shtylyov wrote:
> Hello!
> 
> On 7/27/23 11:21 AM, Paolo Abeni wrote:
> [...]
> >>> diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c
> >>> index 4d6b3b7d6abb..ce2da5101e51 100644
> >>> --- a/drivers/net/ethernet/renesas/ravb_main.c
> >>> +++ b/drivers/net/ethernet/renesas/ravb_main.c
> >>> @@ -2885,6 +2885,9 @@ static int ravb_remove(struct platform_device *pdev)
> >>>  	struct ravb_private *priv = netdev_priv(ndev);
> >>>  	const struct ravb_hw_info *info = priv->info;
> >>>  
> >>> +	netif_carrier_off(ndev);
> >>> +	netif_tx_disable(ndev);
> >>> +	cancel_work_sync(&priv->work);
> >>
> >> Still racy, the carrier can come back up after canceling the work.
> > 
> > I must admit I don't see how/when this driver sets the carrier on ?!?
> 
>    The phylib code does it for this MAC driver, see the call tree of
> phy_link_change(), on e.g. https://elixir.bootlin.com/linux/v6.5-rc3/source/...
> 
> >> But whatever, this is a non-issue in the first place.
> > 
> > Do you mean the UaF can't happen? I think that is real. 
> 
>    Looks possible to me, at least now... and anyway, shouldn't we clean up
> after ourselves if we call schedule_work()?However my current impression is
> that cancel_work_sync() should be called from ravb_close(), after calling
> phy_{stop|disconnect}()...
> 
> >> The fact that ravb_tx_timeout_work doesn't take any locks seems much
> >> more suspicious.
> > 
> > Indeed! But that should be a different patch, right?
> 
>    Yes.
> 
> > Waiting a little more for feedback from renesas.
> 
>    Renesas historically hasn't shown much interest to reviewing the sh_eth/ravb
> driver patches, so I took that task upon myself. I also happen to be a nominal
> author of this driver... :-)

FWIIW, that matches my recollection.
Although it may be out of date by now.