Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.9.0-alpha0-592-ga9d4a09b4b-fm-defalarms-20230725.001-ga9d4a09b
Mime-Version: 1.0
Message-Id: <569a1c8e-234a-442f-9b9e-956f5bac26dc@app.fastmail.com>
In-Reply-To: <20230728074944.26746-3-zhuyinbo@loongson.cn>
References: <20230728074944.26746-1-zhuyinbo@loongson.cn>
 <20230728074944.26746-3-zhuyinbo@loongson.cn>
Date:   Fri, 28 Jul 2023 12:46:37 +0200
From:   "Arnd Bergmann" <arnd@arndb.de>
To:     "Yinbo Zhu" <zhuyinbo@loongson.cn>,
        "Rob Herring" <robh+dt@kernel.org>,
        "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
        "Conor Dooley" <conor+dt@kernel.org>, linux-pm@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        "Ulf Hansson" <ulf.hansson@linaro.org>
Cc:     "Jianmin Lv" <lvjianmin@loongson.cn>, wanghongliang@loongson.cn,
        "Liu Peibao" <liupeibao@loongson.cn>,
        loongson-kernel@lists.loongnix.cn, "Liu Yun" <liuyun@loongson.cn>
Subject: Re: [PATCH v5 2/2] soc: loongson2_pm: add power management support
Content-Type: text/plain
Precedence: bulk

On Fri, Jul 28, 2023, at 09:49, Yinbo Zhu wrote:
> The Loongson-2's power management controller was ACPI, supports ACPI
> S2Idle (Suspend To Idle), ACPI S3 (Suspend To RAM), ACPI S4 (Suspend To
> Disk), ACPI S5 (Soft Shutdown) and supports multiple wake-up methods
> (USB, GMAC, PWRBTN, etc.). This driver was to add power management
> controller support that base on dts for Loongson-2 series SoCs.
>
> Co-developed-by: Liu Yun <liuyun@loongson.cn>
> Signed-off-by: Liu Yun <liuyun@loongson.cn>
> Co-developed-by: Liu Peibao <liupeibao@loongson.cn>
> Signed-off-by: Liu Peibao <liupeibao@loongson.cn>
> Signed-off-by: Yinbo Zhu <zhuyinbo@loongson.cn>

Adding Ulf Hansson to Cc

Ulf has recently split out the "genpd" framework and split out
drivers/genpd from drivers/soc since I'm generally not that involved
in the pwoer management side.

Can you have a look at whether this driver should also be part
of drivers/genpd rather than drivers/soc, and/or converted
to use the genpd infrastructure?

Thanks,

       Arnd