Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 28 Jul 2023 12:14:26 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Ard Biesheuvel <ardb@kernel.org>
Cc:     Masahisa Kojima <masahisa.kojima@linaro.org>,
        Jassi Brar <jaswinder.singh@linaro.org>,
        Ilias Apalodimas <ilias.apalodimas@linaro.org>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: netsec: Ignore 'phy-mode' on SynQuacer in DT mode
Message-ID: <e61f2781-45bc-4928-8a84-e80e3543cf47@sirena.org.uk>
References: <20230727-synquacer-net-v1-1-4d7f5c4cc8d9@kernel.org>
 <CAMj1kXH_4OEY58Nb9yGHTDvjfouJHKNVhReo0mMdD_aGWW_WGQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="N2aIURLae8eqFiup"
Content-Disposition: inline
In-Reply-To: <CAMj1kXH_4OEY58Nb9yGHTDvjfouJHKNVhReo0mMdD_aGWW_WGQ@mail.gmail.com>
Precedence: bulk


--N2aIURLae8eqFiup
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Jul 28, 2023 at 07:45:44AM +0200, Ard Biesheuvel wrote:
> On Thu, 27 Jul 2023 at 23:52, Mark Brown <broonie@kernel.org> wrote:

> > As documented in acd7aaf51b20 ("netsec: ignore 'phy-mode' device
> > property on ACPI systems") the SocioNext SynQuacer platform ships with
> > firmware defining the PHY mode as RGMII even though the physical
> > configuration of the PHY is for TX and RX commits.  Since
> > bbc4d71d63549bc ("net: phy: realtek: fix rtl8211e rx/tx delay config")
> > this has caused misconfiguration of the PHY, rendering the network
> > unusable.

> Wouldn't this break SynQuacers booting with firmware that lacks a
> network driver? (I.e., u-boot?)

> I am not sure why, but quite some effort has gone into porting u-boot
> to this SoC as well.

Yes, it'd be break them.  I wasn't aware that any other firmwares
existed.

--N2aIURLae8eqFiup
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmTDoxEACgkQJNaLcl1U
h9DRGQf/Yz8ze1JwwcnvNBbJMrRkJxjbXPDtWcHPUHch9LjBwLY2LO7zEAz9Mp9K
6idj6J5RcdvRXAbgAA/Zq4H1OHcvwGGlppKuyVvi9Q79yQZtZSVHXr3kiwyYiyxa
VNqCgVhCkYR5FQbvrH4/9/cv7F8w3fweznRDSF0rBNd8GQHG5N7id/AHrOqhg7K4
mxzdMsAVDfO5wU+JNrziF+v979F76t1PkvrNkCmbvqcAYcWyXWMFekjIYil82Y18
zrNqaWWMRJmycVR9Rr1UQvWNhqWyKVHz5IUBaP3mIpV53qplr17FiJkfwrw5gM6q
8IRIOf5vI9mcQeCoByDoCbVQKu1z4g==
=7npc
-----END PGP SIGNATURE-----

--N2aIURLae8eqFiup--