Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Ratheesh Kannoth <rkannoth@marvell.com>
To:     Petr Machata <petrm@nvidia.com>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>
Subject: RE:  Re: [PATCH v2 net-next] dissector: Use 64bits for used_keys
Thread-Topic: Re: [PATCH v2 net-next] dissector: Use 64bits for used_keys
Thread-Index: AQHZwTuY9Nej4qKeHEmjz6gTMb2yUQ==
Date:   Fri, 28 Jul 2023 10:09:29 +0000
Message-ID: <MWHPR1801MB1918661082BC3328EAE37071D306A@MWHPR1801MB1918.namprd18.prod.outlook.com>
References: <20230728022142.2066980-1-rkannoth@marvell.com>
 <87mszgfjai.fsf@nvidia.com>
In-Reply-To: <87mszgfjai.fsf@nvidia.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?3thZ/QwspeUiD5/AtgZzsWsMOne1KLZNTE/ks6MskJi0fCszeGF4b+Fl5oHS?=
 =?us-ascii?Q?51WUEmYjhAtE7IEsdQR03fuVzgsGHvc/5OzmXd1nC3lPBxIBqz2OkF8Y+UWu?=
 =?us-ascii?Q?hhR8mTvt7pULoClj3iico8Bm5tozFXlIU4XiOuKO75FeiXdtkUHNfYrbagwS?=
 =?us-ascii?Q?0Mp3O+/Pg9o1lu6041dd+qEhmA1Yo7KxDCJGowB1OSG22/yXPMm6oyyd0Ata?=
 =?us-ascii?Q?mDTL66qURNAtg8gHhrpzC6yMlbAQzXsACa81Bvk/SO3n75BsY/wqYXW49h1L?=
 =?us-ascii?Q?0XghQLdCNFUXwZfkfjYmxFTefFYdcJ2GlQj6/PcuE55mVc9/7K3z2tL6Xov2?=
 =?us-ascii?Q?Rqin/YI5xET1N2+XV8hQJOI0x10N4Rj91s/n/dSoLtuDz0KxvxJmqocB2wuT?=
 =?us-ascii?Q?otUr2No7uFmh981BixL5Gdr8V38TKYYAKHaHpMmzDnx8qdCMYwAnlQkiIVOa?=
 =?us-ascii?Q?Xny9UY37Dt5GbYqNjwt4GJfY39dJCrTlU2sjaVvEqakhtq8RwO4AVVH6vd3E?=
 =?us-ascii?Q?UVAXe7kWAIkU3EDy/Y9W2zPqOOghQLQlooMMUDER2xl2K23Bus5o+qWMVn8j?=
 =?us-ascii?Q?f6QA7CHuC8IzpnswoiCnGltn6hxdy8iOt/AQITGXTKYUco8hubh8V3qJ4V80?=
 =?us-ascii?Q?f/BdTl1pCgvfgUqs2VcHzB5+lQF3I62xZzZwLrWLtwW3S4Q59PpE3Ih/BEgh?=
 =?us-ascii?Q?a08T5LSVQ1qxcshWkV4zD4nk2K0BA5ffuZ0+PyIvhVShKnsUyDAM5qwWoWFb?=
 =?us-ascii?Q?Fcav3YuJ2OfjSLLD0d6C3xAEDWK4Oe41ZYPtgxzI9CzbbnaGV0zUcJ+pd5Ea?=
 =?us-ascii?Q?Q0umE6nZSaV97oEme9RhP3cd884vU81yYNS3izTKDqU53QGtqSske2jDOkJ0?=
 =?us-ascii?Q?AtXBIWMbblQlg0pB2e/KcH+UGhjKuvva+VSto18h1HIW/pqYb6Rm83ZsexfS?=
 =?us-ascii?Q?LMKFo9eHgYlDO20/B0JREgKNRL4JhyeGnEQTK0vGZLWJxUTZMT3+D38+TQAq?=
 =?us-ascii?Q?SswpbJXkI1Zy2DWvMlfIUSeKNm46VcsfJpdtfUbgebaLIfQKErGXU9DtrXfz?=
 =?us-ascii?Q?IA0cUTXdkxiSGCkbp06DOY5qPYdtrZK7deD4Q8lk8Qjxhx/RRTKDOqHSYENT?=
 =?us-ascii?Q?XqZShwuMJaQLcn4GkTz16n+HrOBOs6VQd9RrQwiUAQo6lyYHUYceWjlvsB4q?=
 =?us-ascii?Q?5ijiLd7p6laqKKIwVIJu8wtHfQtFo8luzPTtMnMBpeE+Phv+r7Nm0QnPbzWI?=
 =?us-ascii?Q?IQk0MXk4HJE7VCNbzxk23N3Sjx+7K4fYTdR4KSIGUS1ng6o7j1VSyXRikEqX?=
 =?us-ascii?Q?RoxA1OdZXlCPu9Vgc9KtjuEcMC4VOpUKI8fAmBoyanoUZnchiFwiFVIz3CGP?=
 =?us-ascii?Q?IAoNRoOiQpf/IRvElTX1WvKhgb7rk4N6e3UhupnxgaNrTpNbOqZpkeTOgD8J?=
 =?us-ascii?Q?ao+WQjzjgFctcoUsIlPOdJFtAbplE8kJgU5PjU5PR/xFADfCBR551SpUkvkd?=
 =?us-ascii?Q?IXpctJlKFD5kGyKM/6qWJd7j6qVScx49ms3MoDychetrfcis04XyyK4y7xQW?=
 =?us-ascii?Q?xp8cQqwaqsnCsASYfwY0eHlv2VyNfItMCw/DJ9mf?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1801MB1918.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: da2eed4c-b1b4-444f-025f-08db8f52bb29
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jul 2023 10:09:29.2753
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: QB8FcDRDDvjB3W2e100kUxGzUKTcQx/Io+KDH9Gw3aTkjbjhMSC71RxrmF88jeI2U/rIl8VEAHezh3qsUrO0Qg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR18MB5094
X-Proofpoint-GUID: lEfEYOkCCQX8IpF__ZEcYpjG1b0i6Gsp
X-Proofpoint-ORIG-GUID: lEfEYOkCCQX8IpF__ZEcYpjG1b0i6Gsp
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26
 definitions=2023-07-27_10,2023-07-26_01,2023-05-22_02
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Petr Machata <petrm@nvidia.com>
> Sent: Friday, July 28, 2023 3:00 PM
> Subject: [EXT] Re: [PATCH v2 net-next] dissector: Use 64bits for used_key=
s
>=20
> > Signed-off-by: Ratheesh Kannoth <rkannoth@marvell.com>
> > Reviewed-by: Petr Machata <petrm@nvidia.com>
>=20
> This makes it look like I reviewed the whole thing. I think I wrote
> this:
>=20
> 	Reviewed-by: Petr Machata <petrm@nvidia.com> # for mlxsw
I did not see any  instances of adding like  # "text".  If it is valid styl=
e, I will fix it in next Patch.=20

> Also, you either missed or ignored my proposal for subject line update.
> I do think that "net: flow_dissector:" would be a better prefix, because =
that's
> how the component is called, and it's in the net namespace. It's OK not t=
o
> agree, but in that case please argue to that end.

My bad.  I missed it. I will address in next patch.