Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 28 Jul 2023 13:31:01 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Yinbo Zhu <zhuyinbo@loongson.cn>
Cc:     linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
        Jianmin Lv <lvjianmin@loongson.cn>, wanghongliang@loongson.cn,
        Liu Peibao <liupeibao@loongson.cn>,
        loongson-kernel@lists.loongnix.cn,
        Andy Shevchenko <andy.shevchenko@gmail.com>
Subject: Re: [PATCH v13 2/2] spi: loongson: add bus driver for the loongson
 spi controller
Message-ID: <67b74e69-f660-43e3-831f-47dbe0fea6fa@sirena.org.uk>
References: <20230613075834.5219-1-zhuyinbo@loongson.cn>
 <20230613075834.5219-3-zhuyinbo@loongson.cn>
 <3822f248-39dc-fb8d-321a-7b6c833cbb3e@loongson.cn>
 <2264c9bd-76fb-4a99-b655-f4c7bc2a1d45@sirena.org.uk>
 <8ad55123-fbf2-2b0f-faba-f71bb89c7fb1@loongson.cn>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="7U7txTj5uibwo7Uy"
Content-Disposition: inline
In-Reply-To: <8ad55123-fbf2-2b0f-faba-f71bb89c7fb1@loongson.cn>
Precedence: bulk


--7U7txTj5uibwo7Uy
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Jul 28, 2023 at 11:36:48AM +0800, Yinbo Zhu wrote:
> =E5=9C=A8 2023/7/27 =E4=B8=8B=E5=8D=887:37, Mark Brown =E5=86=99=E9=81=93:
> > On Thu, Jul 27, 2023 at 11:09:16AM +0800, Yinbo Zhu wrote:

> > > Friendly ping ?

> > Please don't send content free pings and please allow a reasonable time
> > for review.  People get busy, go on holiday, attend conferences and so
> > on so unless there is some reason for urgency (like critical bug fixes)
> > please allow at least a couple of weeks for review.  If there have been
> > review comments then people may be waiting for those to be addressed.

> Sorry, my community experience is poor.  How many weeks does the
> community usually take to review ?  and this time that I waited for six
> weeks and then ping.

The delay here is probably fine - the above is a form letter that I send
whenever people ping so it tries to cover all eventualities.  How long
to leave things depends a bit on what the change is, an urgent bugfix is
going to be different from a spelling fix in a comment.

> > Sending content free pings adds to the mail volume (if they are seen at
> > all) which is often the problem and since they can't be reviewed
> > directly if something has gone wrong you'll have to resend the patches
> > anyway, so sending again is generally a better approach though there are
> > some other maintainers who like them - if in doubt look at how patches
> > for the subsystem are normally handled.

> Sorry, I don't got it, that free ping usually only needs to be sent to
> the subsystem maintainer?

> Not recommended to use free ping?  or resend the same patch.  If the
> patch does not need to be modified, does it require sending the same
> patch ?  And the version number remains the same?

I'm saying it's generally better to ping by resending the patch.
Typically keeping the same version number makes sense when doing that -
people normally say [PATCH RESEND vN] in the subject line.

--7U7txTj5uibwo7Uy
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmTDtQEACgkQJNaLcl1U
h9D8Igf/ZpPacjeh9QRNEG3bvMLlU/a3Vdbx4DdcpupG1gSpuhy2lizUJfwHaVK/
76xQ+6RxZFWPcDI+ByRA6BHOwAtTDL9GftStWiY5o5UlgKgZPiJmWMN6D3LzSGfo
F0vERJH+30RbApNL8/uRBI87BT91ntltfFGYHdy/p03HDbcW+QP8iq4SaxI9rJ/h
SXSWcqWMU+rs+5o1S/G+skY9mF4WFWNbKQ/WGgK96sunSwbUnOzzWveYjuPp57ye
Apo16/DPTT9sAzVTUD2VggxdJQ5W/aFrVpU/cfexHJ7MWaeClizbSRBq5LpGDwbS
wajz6MmqKfb1SDsu6z7z6TLvLGN9bg==
=66ff
-----END PGP SIGNATURE-----

--7U7txTj5uibwo7Uy--