Received: by 2002:a05:6358:c692:b0:131:369:b2a3 with SMTP id fe18csp1212335rwb; Fri, 28 Jul 2023 06:27:46 -0700 (PDT) X-Google-Smtp-Source: APBJJlG6r92+g3JIfZv2BupvHirNgEzWh9dEl0vnLoPXxGzMfgIBdyTgljcYWUVHXtxvTT7FGVPa X-Received: by 2002:a05:6a21:338c:b0:13c:b7e9:7a22 with SMTP id yy12-20020a056a21338c00b0013cb7e97a22mr1564605pzb.13.1690550866049; Fri, 28 Jul 2023 06:27:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690550866; cv=none; d=google.com; s=arc-20160816; b=dH2JVYrBMUuPyPHoiTvj4qVzIO1BpOGl4pUqActaU0NfTb0+gftnF6jONTmxzlU9r3 m3fdFEZpdb7fFuU6UtNueOQXOgEE8nwuEZC+9yjybhoXEoJsN9/MGeeYhJ0HWeoY5jyr EVyq7TrJCBF6f2YPhJ5qrKRCkVoAfFvHB7sJGBotL4kgerPN0QURXMKC0/jOsPs8KYpA u08GvzxxiuoyDjgF6SQIs8oKVbwuyAzHXCo2MbPKhAWQZlGixZ5v59IjPYdDpOgaGiYM clvfgd2qNg1J7GxOj0ZC0vt6AhCxnWfFzAlO8rCdkqxzfeIlIUgcxBk3mSMA99VwzQCq Y0eg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=P0Y3LgXeUrABp33LMbUEmoFteLOOEzsqd8YqOZfUyBo=; fh=M/OrNaMH0A10IaUPd6lpDfO7RMDtAzFddNCG76fL5hc=; b=AmBRCWzg6YjFoge2ER/63YZ4D5Jxxf7mLtoM8FAUzYl5g6b1Bm6pCSS8ciLmtGpR9L 2YfjwwDaqrlueJM4dF3dIx2x2drZbLfvBeUka/QX18LALAh+zdwIAoy9JK9cvZmSBIZR 6kwAJ/c8AgHcz640NlwtsmCAYgqi0Da3C230KJv8Wfa7XEZn5ux92qW/lUXuOkgDO0DK wazljgBbZxjzq5J1MNrkiSkQFOSgoJE9XjnsXuHW0gM/DgrQOanh+ERJH0kcYaAvLbh8 59keNfoxB6PMvt9DcOcmfA6NE/xulIA8Om8Dz6RelzDP2PtRQyqcfFG9w4+ILAkcyc1J IMZQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=cEXwOWhR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w184-20020a6382c1000000b0055ab9bb07fbsi2998449pgd.395.2023.07.28.06.27.32; Fri, 28 Jul 2023 06:27:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=cEXwOWhR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236635AbjG1MWN (ORCPT + 99 others); Fri, 28 Jul 2023 08:22:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37306 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236346AbjG1MV5 (ORCPT ); Fri, 28 Jul 2023 08:21:57 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2385149C6; Fri, 28 Jul 2023 05:19:38 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3BC14617A1; Fri, 28 Jul 2023 12:18:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 19337C433C7; Fri, 28 Jul 2023 12:18:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690546730; bh=gQurcQuCxiDt0SBlMwFfwQnLQiDNL6w3VdbHaWWy1Bw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cEXwOWhRje/2/MMOu5YHNslDYmqDxXyXLCSWjZeIB7hWVlL49Fl8JmndUR6cBZ6go 85Ff5S60I8ohbVozgj8omXYlqBdN4Mf0QEiB46KvkF9Ze4LQN3ex3CteHgy135w4Xq rotf8YltM7XjsM7GsFuIh6rmXFbah2OdjS/BTfXg9s0pB0twCfAYx+Db/Zd0h6Dz2o VBEksIhi8TN6eiS8apERvZ0chyjJOHWZdqdNuMayuhmVS8M1lOIGEdrUdy/Y4W7kF9 IiQMOXIl15OXpJPdAwTfZyd/XROYtVulGercHZXMmpRaC6EA4PfPBs5OBrFShAcu5f aL8wPFRw6Go0g== Date: Fri, 28 Jul 2023 14:18:40 +0200 From: Andi Shyti To: Paul Cercueil Cc: Wolfram Sang , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 09/22] i2c: img-scb: Remove #ifdef guards for PM related functions Message-ID: <20230728121840.tdzwsf4zwrdywvkz@intel.intel> References: <20230722115046.27323-1-paul@crapouillou.net> <20230722115046.27323-10-paul@crapouillou.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230722115046.27323-10-paul@crapouillou.net> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Paul, On Sat, Jul 22, 2023 at 01:50:33PM +0200, Paul Cercueil wrote: > Use the new PM macros for the suspend and resume functions to be > automatically dropped by the compiler when CONFIG_PM or > CONFIG_PM_SLEEP are disabled, without having to use #ifdef guards. > > This has the advantage of always compiling these functions in, > independently of any Kconfig option. Thanks to that, bugs and other > regressions are subsequently easier to catch. > > Signed-off-by: Paul Cercueil Acked-by: Andi Shyti Andi