Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <cefa57cf-2ff1-22f1-5cb3-ce0c04a30c57@infradead.org>
Date:   Fri, 28 Jul 2023 05:17:33 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH v5 2/2] soc: loongson2_pm: add power management support
Content-Language: en-US
To:     Yinbo Zhu <zhuyinbo@loongson.cn>, Arnd Bergmann <arnd@arndb.de>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>, linux-pm@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     Jianmin Lv <lvjianmin@loongson.cn>, wanghongliang@loongson.cn,
        Liu Peibao <liupeibao@loongson.cn>,
        loongson-kernel@lists.loongnix.cn, Liu Yun <liuyun@loongson.cn>
References: <20230728074944.26746-1-zhuyinbo@loongson.cn>
 <20230728074944.26746-3-zhuyinbo@loongson.cn>
From:   Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <20230728074944.26746-3-zhuyinbo@loongson.cn>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi--

On 7/28/23 00:49, Yinbo Zhu wrote:
> +config LOONGSON2_PM
> +	bool "Loongson-2 SoC Power Management Controller Driver"
> +	depends on LOONGARCH && OF
> +	help
> +	 The Loongson-2's power management controller was ACPI, supports ACPI
> +	 S2Idle (Suspend To Idle), ACPI S3 (Suspend To RAM), ACPI S4 (Suspend To
> +	 Disk), ACPI S5 (Soft Shutdown) and supports multiple wake-up methods
> +	 (USB, GMAC, PWRBTN, etc.). This driver was to add power management
> +	 controller support that base on dts for Loongson-2 series SoCs.

Kconfig help text should be indented with one tab +2 spaces, as documented
in Documentation/process/coding-style.rst.

thanks.
-- 
~Randy