Received: by 2002:a05:6358:c692:b0:131:369:b2a3 with SMTP id fe18csp1377805rwb; Fri, 28 Jul 2023 08:34:24 -0700 (PDT) X-Google-Smtp-Source: APBJJlFTCaP8lsZklWaJPOWQxs+GIvYXsDsZftkk0IE5iJdQ9id6flMy2ggkhQ0wuMw1Xitpzx3v X-Received: by 2002:a05:6a00:1741:b0:686:de6c:a9e5 with SMTP id j1-20020a056a00174100b00686de6ca9e5mr2889455pfc.31.1690558463800; Fri, 28 Jul 2023 08:34:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690558463; cv=none; d=google.com; s=arc-20160816; b=aky2Jn8tWQBb3HM8O+SqIDl7cGoU2x3kp6lYkylhCKb0mzBTG7vF7vW40RmmY8wzar +UoNlF9gsozL/kpWg2fY1TDyDb2g8HwxfNN9t7NQhaJLH83Uf3I9FOY7gTcIqnkqJag1 8m0xwSYdigkmCRDrRN1gOZeBnlC/IZZBeYftEMASVaqQyo+mkBKaIGm9mEyUs0DRg34K 0gaPS1/1AvHsHwpUqAJSVCuHnlJ8VufHJSrzFbyfMAdWVIehejcuTnf6UmUuXom2xpQk mM9f2y++Tz869aMjWWBnUZdP7larollTLFPhIPOgGaGH43jkOHMBseGkdLO9FX0u5CNz IS6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:to:content-language:subject:user-agent:mime-version:date :message-id:dkim-signature; bh=gedJLHyl9jYC/USPCijx0sE3um9fSLBbzPsw2ixUmqY=; fh=0qovr6wWFag+QdOOTfRI5/GJkGddk4+2EaBiI4x/9aA=; b=m1Op33ibcvbzKuLNx+ECqZfSA7AXkmYcPoULOt20uNbcUXZ++g+C8z3Y9qiPgKJHyY hT3ybt6sBaCWDm27YPclMHbE5TmkC12ZVNSAu6tNjI+IyMc7GsPPl1GpizYlJtPYM823 t8qgkMABS2lWTVrA7j4jP7ZnkUC3XCpkBunpt4KLqP4AcIy7iprLbEz4GiGCG+Yp8nUS eaX41i0oQaGagx/ni3iC5BOVq2Sg7IXMTjM57GVz7LroI3ci93e8iAZahZcwHo0xoHYN h+e/rVgCxYepDkZ3u4yyHlaa+QDSxBnLHeAtIRR72TyXNz3IWfgjlxPfJXbJ7fOJaN1i NFWg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=wZkbNGqQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y21-20020a056a00191500b006825e062715si3352543pfi.228.2023.07.28.08.34.11; Fri, 28 Jul 2023 08:34:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=wZkbNGqQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232693AbjG1Mvd (ORCPT + 99 others); Fri, 28 Jul 2023 08:51:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58968 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235304AbjG1Mvb (ORCPT ); Fri, 28 Jul 2023 08:51:31 -0400 Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6CEF2187 for ; Fri, 28 Jul 2023 05:51:30 -0700 (PDT) Received: by mail-ed1-x52b.google.com with SMTP id 4fb4d7f45d1cf-5221e2e69bdso2664904a12.2 for ; Fri, 28 Jul 2023 05:51:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1690548689; x=1691153489; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=gedJLHyl9jYC/USPCijx0sE3um9fSLBbzPsw2ixUmqY=; b=wZkbNGqQ3uw7mcIwc1dl7W5fqIdyvKuQUlDtB8gOcchltE1RNPokOIfX3a/CvA/g5t mw2xEn50S9OLn2pNFVCuTMP86YFrvZKsDIBDutAbKKuSiTQPY8/b4MCrKdJQYFfOKVv/ Ty3Lw8A0HAfx+lgEd/6uJxOqks62xu8+dJP4KoIOWfeIZFIK1rb2giVKIpibsczYWqqU 7k0zJTnEguhscCH+pXhGphDy2A0CNjWyoqyxlXMi54Vl+hVfx6m9a3Zt8jdwrObAQcnt S/tQrXjg6JBJYzZih7sFc1ERLc5iEP5Uq26CzNJrJcWUunD0PCgjfVnRAEgG4GAUcgk3 KGSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690548689; x=1691153489; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gedJLHyl9jYC/USPCijx0sE3um9fSLBbzPsw2ixUmqY=; b=OqjpCX4Wf0fkcC4tycx8w/xrhSpDV+ffAOinJcgv0hnZoSTsKYfgl36RHN3rZ2BoIv hctQCtDZ8kSf4IhDhx7z5YZOsNRTTEQeY3Lh/VAE8UlH5hH53hHGC70hkrGGL5lfxAx6 YCnz8YAlQRM0P+7aXNdAO81JP/e4ViXVB4v/k8jyrZj0v7lXfSH00PEzpQPO//pdypFT +DVZnMEnOCX3irITYjGljsNze4NTfW1i6cp2NwjjPYM6UeHb3teAHhSbBiF/H23TrDRX k8HxAgCkMH+vO7aXb/T6Heek6wLDkLoUTxLIeR0LpwNrc2fy5PY90G593+rXwiQVC7Fo Nrgg== X-Gm-Message-State: ABy/qLbxnes1nzLRXjKJlYSMAJVM4OrGpHyAoPgXwSlL64XeMpjkZJtJ YK8KEiS2FriUohCrXgkmFHUc+A== X-Received: by 2002:a17:906:319a:b0:994:34a2:8727 with SMTP id 26-20020a170906319a00b0099434a28727mr2157378ejy.41.1690548688933; Fri, 28 Jul 2023 05:51:28 -0700 (PDT) Received: from [192.168.1.20] ([178.197.223.104]) by smtp.gmail.com with ESMTPSA id sd26-20020a170906ce3a00b0099bc08862b6sm2054522ejb.171.2023.07.28.05.51.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Jul 2023 05:51:28 -0700 (PDT) Message-ID: Date: Fri, 28 Jul 2023 14:51:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v3 6/6] ASoC: dt-bindings: mediatek,mt7986-afe: add audio afe document Content-Language: en-US To: Maso Huang , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Jaroslav Kysela , Takashi Iwai , Trevor Wu , Arnd Bergmann , Mars Chen , Allen-KH Cheng , alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: <20230728090819.18038-1-maso.huang@mediatek.com> <20230728090819.18038-7-maso.huang@mediatek.com> From: Krzysztof Kozlowski In-Reply-To: <20230728090819.18038-7-maso.huang@mediatek.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28/07/2023 11:08, Maso Huang wrote: > Add mt7986 audio afe document. > > Signed-off-by: Maso Huang Thank you for your patch. There is something to discuss/improve. > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - clock-names > + - assigned-clocks > + - assigned-clock-parents You should constrain your clocks per variants. I doubt that they are really so flexible/optional on each SoC... or maybe missing clocks are result of unimplemented parts in the driver? But then this should not really affect bindings. Bindings still should require such clocks. Your DTS can always provide a <0>, if needed. > + > +additionalProperties: false Best regards, Krzysztof