Received: by 2002:a05:6358:c692:b0:131:369:b2a3 with SMTP id fe18csp1422677rwb; Fri, 28 Jul 2023 09:10:25 -0700 (PDT) X-Google-Smtp-Source: APBJJlF8iya+M2GuvG14sGEVdcd5NpkQkXbN+BJnR8LDaDjPWD2brQpYR7vClmKLDbU7K9vRKTfj X-Received: by 2002:a17:906:3058:b0:99b:8c6e:ec18 with SMTP id d24-20020a170906305800b0099b8c6eec18mr2438866ejd.48.1690560625693; Fri, 28 Jul 2023 09:10:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690560625; cv=none; d=google.com; s=arc-20160816; b=DTfFyQiPtv646auQ9YV9LYUChAPh/cyJfP4gHVEkuAJqkuByrd76rEyRe46YUUOkyA h/XKJyqbqdVtywJcS1NKe7kG7zht5UT9T3UzuBSXu3Tuh7TgB4LO+0F3byZqSXwAJzpX jOqhKxwKPoxtmi66mjYPFGq0a9EOY9kz59WEqSxDcDAkFaukiIvlbpmGIqp+FhNnTa8t zQk0nb/1MKtLEjTYXAnlQnDqtlzi7SpTlL0b8X01czgtuaOTEu86euE4872S49OSfiBw bWOI+MR8Fe6P2+8PJbMkUN42U6cBb/RxFT1kk0usNLT0Uc/by72biCc2pI99u8xdUCC7 Li2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=7DFCo6qeekzwuWPEKZAyczH1RGTzlysIXVLTrOCoYTo=; fh=9td/jw969iLpLAYGpdhxsAlo+Zsj+pcV/J0+kv/1e8Y=; b=YBCpg4zP6r1F8Yq1nyj4lFXnd8EKEyZ+3b8kwsoAZHJf6B6xOLF1CAX9YV6Bo6nLNc J/OKYRVh4AUW1vdvqvqxhaWeXS+VgBWnYfKZQWgLYu3sDu09GSVwV/eabaKDALiEIcCm 9Q72iduj0O/71do4RLc73MgUwlxYmJXJq5Jsj0h26OOKEJs1PmjSKZhAmIXENqc29azu K6CT9KhylRZHdzaOhXTZ7PvMQarA31pz2ettx2SfO8KGcU/c9xH5erJgxmBm0mB8FiVV tNmrIkkZqDyZcZGDotHd8FSqTlHW9TlepPAnQLXdUu9XYEdEEs9AAubgRa0Djsbz4vMH WJwQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ssPs83Qc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j17-20020a170906279100b0098dd7b3684csi3278258ejc.994.2023.07.28.09.09.59; Fri, 28 Jul 2023 09:10:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ssPs83Qc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236716AbjG1Pup (ORCPT + 99 others); Fri, 28 Jul 2023 11:50:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38180 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236096AbjG1Pum (ORCPT ); Fri, 28 Jul 2023 11:50:42 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4902F44A8 for ; Fri, 28 Jul 2023 08:50:26 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DB47562186 for ; Fri, 28 Jul 2023 15:50:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CE92CC433C8; Fri, 28 Jul 2023 15:50:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690559425; bh=7DFCo6qeekzwuWPEKZAyczH1RGTzlysIXVLTrOCoYTo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ssPs83QcERvNqi05t+eltoSHZrWBX+5yll8ocUoJ5tvrPyVGdOXmXSQXX34MKYMAS LJiEvvM8hZ47UKOV98143/z8syV08krfaTGFRfL9VWmwP7UKoAyxSvn49lx0hZD+NO daHvXpoDM8PKR9rqNPoFHkdhRaiHZtE4fo26pkSRYONbtb8xKdZNzpffbZDPm6eqU0 f8t/atlEuugkpwJg/iTYxvJUs2oyV/ixdPn52u01abGmUY7WgkBwrMS9enDx5Q2dSn uSPVpM/m1gNIhyrxexWWFlUZaHZVFt7CxkqSc+T5AAeADGk2BarQoeEbzdRiOzt9ZS KzO31UWDItj+A== Date: Fri, 28 Jul 2023 08:50:24 -0700 From: Jakub Kicinski To: Alexander Lobakin Cc: Yunsheng Lin , "David S. Miller" , Eric Dumazet , Paolo Abeni , Maciej Fijalkowski , Larysa Zaremba , Alexander Duyck , Jesper Dangaard Brouer , "Ilias Apalodimas" , Simon Horman , , Subject: Re: [PATCH net-next 5/9] page_pool: don't use driver-set flags field directly Message-ID: <20230728085024.684970ba@kernel.org> In-Reply-To: <6f8147ec-b8ad-3905-5279-16817ed6f5ae@intel.com> References: <20230727144336.1646454-1-aleksander.lobakin@intel.com> <20230727144336.1646454-6-aleksander.lobakin@intel.com> <6f8147ec-b8ad-3905-5279-16817ed6f5ae@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 28 Jul 2023 16:03:53 +0200 Alexander Lobakin wrote: > And it doesn't look really natural to me to pass both driver-set params > and driver-set flags as separate function arguments. +1