Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <5ba84af2-51d1-de5d-14cc-752c08e5371f@intel.com>
Date:   Fri, 28 Jul 2023 15:58:58 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH net-next 2/9] net: skbuff: don't include
 <net/page_pool/types.h> to <linux/skbuff.h>
Content-Language: en-US
To:     Yunsheng Lin <linyunsheng@huawei.com>
CC:     "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
        Larysa Zaremba <larysa.zaremba@intel.com>,
        Alexander Duyck <alexanderduyck@fb.com>,
        Jesper Dangaard Brouer <hawk@kernel.org>,
        "Ilias Apalodimas" <ilias.apalodimas@linaro.org>,
        Simon Horman <simon.horman@corigine.com>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20230727144336.1646454-1-aleksander.lobakin@intel.com>
 <20230727144336.1646454-3-aleksander.lobakin@intel.com>
 <f283dfa9-d599-7311-1c2f-4317c2f7957d@huawei.com>
From:   Alexander Lobakin <aleksander.lobakin@intel.com>
In-Reply-To: <f283dfa9-d599-7311-1c2f-4317c2f7957d@huawei.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TlJyQXZ6dkdybUJ0c3ZhcFY3Q0VPMGtEWFRIaGp6TE9rMEhjWVVjTkZEdG84?=
 =?utf-8?B?aHVEWmo4dlRXRUJPN1g4eEsxS2tGNU1Ba2NtN3AvTmlZck0wWC9odzhONjF2?=
 =?utf-8?B?V2RGYlJsdGF2ODhyanI2T3dPcElBOW9mQXBRakhrakcxYWFEV0lNakEyVkhG?=
 =?utf-8?B?YkYrdU5QQ0dqVnVUSmtRSXVIRjJ3Z1NuV0xOL0s1RHBzRy9iaWlxSi9jQkpK?=
 =?utf-8?B?TURpMS8vbUoya1hzN3FuWXJQbG5MU0I4dTQ0YjRzc0FaNy91NmhzQ0M0MHBq?=
 =?utf-8?B?dWVSQThRaGZ6dXg2MzlOK2ZoRU9RMDJERU9PQkZPODRIc2xkQjZBb3pSKzhw?=
 =?utf-8?B?TWNhWDZnWXAvRTJzb0xsbEFMTHdrWGdMVitxNXZNVFpkK3Vyb0NrWVpNT1Fs?=
 =?utf-8?B?Z3NyNm13bUVacGxxNEg3ZWRrNGpQOHlYSXpzU1krSk5SSTRvUUdjNXlldjhO?=
 =?utf-8?B?NU9IamY3NU1EbzNNemEwbVlBYkFGRDJ1WFoyQlRLRzY3cnFGQ0RDdW84bVdK?=
 =?utf-8?B?TmY2b05nNTFMK2VWeEtnUENVUFdUb2FFL1N6eWxZMVdyVTZ5NkxtYUJvcHNJ?=
 =?utf-8?B?NDRlWkpEL05GLzUwbklkbzVDbTNhbUhGZkFlK25DRS9tdlNIRTh1VXNUSWRU?=
 =?utf-8?B?aVJoY0lYZHFsZGdUZXJlaDVMNUVRNnV3ZFZpN1grRW8zdzNmZklkVHJPSC9v?=
 =?utf-8?B?RzVYVUJYRjYyeERiTXJZdU5ONDVhT25zbG5ZYlZxemFHclMwdFZpTFhOSGdF?=
 =?utf-8?B?c0NTNjg0V2VYWkZJTjJlVUQzek9NQ29vZnp4Q2FPaHU0RGk5TE5LcjVBQmxU?=
 =?utf-8?B?Q2VpcWR2aS96N3FnOS9heUZ6aHNoMTNHZ3FYVTMxdWJESG0vbGlyRHF1WmJK?=
 =?utf-8?B?RjlidXJPZHBJcUpmNEdkcm44NUNxYkc0YlFhenA2UFJKL0ZwMUx1TFh5Ykw1?=
 =?utf-8?B?WUltYmZjY29LYnAxcHZrbTdRenRteTFHeCsvb3lVcDNjTnVGbnZTK1ZNcHRX?=
 =?utf-8?B?dVRSSTMvTjdCUmhtN0RDc2EyV0tIWk5qbWo5VEFYRk0wbzZJbEpuVlhTbWQ3?=
 =?utf-8?B?RmdTZFVwWW9qeWlTZlJIdityWEVhaWRIMks2M2FWUERIK1JzY1JzYnhmQlFP?=
 =?utf-8?B?RTdsODh4UXdUVnJpOU9LY3RLWTN4NENoaU1FeUZmZko5c1lwOEJlMW5RaW1z?=
 =?utf-8?B?TVI0ZUxqamhPaFlDU3NJUnRqbXgyaHgwWklsWWZqc1J3L1ArVDBoclBoK0o5?=
 =?utf-8?B?bWVDb3Vnd0phem52SnduOEVUN0Fnc2FYMkJsaDRPcU1URlIyZW9md1FmSmVq?=
 =?utf-8?B?SHVOU3NxcURSVndGa3NwSW1TRzBJVXhkTkIyTnB4bkQyeGpTRWY5T3gycHRn?=
 =?utf-8?B?QlU2WXFoNEwzUXl4R0NlN2sxbjJCN00wWW5KSklhNkI2N1U0Y2hxd2c5aHFu?=
 =?utf-8?B?OGVJenJodHZjV3NibTc2MTVUbXNrY01KWURQMTZFNzhZaFpTTHN4cnFZOHF1?=
 =?utf-8?B?eEJmSFdmbGoraUJCc0tPUWFWVTRoWlVjcXFwLzJ2Nm8zRW5NMnJOaVBpN2FJ?=
 =?utf-8?B?TE9FSG9oejNuT0R6bUJNNldXMDdXNDU1bUl0YkxXT3FwcDB3WkNGWElqNFA2?=
 =?utf-8?B?ZG5nbUdlSEhUc0dyTXcrVVdWRFdjenBoeWdjcmExZUhrSDk5dTFtajZRRzdO?=
 =?utf-8?B?TGJmYWhpa3F6a290OVQ5eHlKYnBnUWQvOHhtTzVkWS9LbHFxL3VLWS9TSnY0?=
 =?utf-8?B?LyswQUk5UHRwNi8vcjZuRDY2ekRaMW52SnFPY3BMNU1HWU5hN3dYZlZmMWIy?=
 =?utf-8?B?ekVmUjV3aWNwRFR4WkJ6TXBsV2RrUnE3dzhqeXkza1dxV0U2ejlYRllZc3Bs?=
 =?utf-8?B?aThraTlKdmc2Nmthc05QNERlb0Y0cWNldCtCaE1LZjVLbVF5anNTeHFpZ3dn?=
 =?utf-8?B?TVJUQStaTUZtMjhWRnpRTXBZbVZnZ09oeXBsWXQ1MGkzanZnNlVIZUl4Z3ZF?=
 =?utf-8?B?N0h2c0xMdXhBbzJjN0RiY09EdnM0UzRTbmhXa2tTMjE1bTFpYVlRdklDeU4x?=
 =?utf-8?B?M2xPM1RkSWtIVE1sbU82YWpCZnZic3BZUmx2bUQ4U2hPYUltZUFVSFFvUlAw?=
 =?utf-8?B?dmNwSmtzbWlBU01WRDIwWFg2ZjkybU1SMWhMV2hLRHhaRjBPVGQ3TzZoeVpL?=
 =?utf-8?B?Rmc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: cd442594-d5a2-4979-f330-08db8f73064d
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3625.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jul 2023 14:00:39.5715
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PZrBhCUgoeUvPP8GpAV5/zX5vgbJvi/9zsWdUKEPyMs8oMLl3iSuS2k+bUhsKtAVGiEbJ82Vxk2Adj0TUqTQLCRrolmuLnM37uzCcJDQNWY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB8740
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Yunsheng Lin <linyunsheng@huawei.com>
Date: Fri, 28 Jul 2023 20:02:51 +0800

> On 2023/7/27 22:43, Alexander Lobakin wrote:
>> diff --git a/net/core/skbuff.c b/net/core/skbuff.c
> 
> ...
> 
>> +bool page_pool_return_skb_page(struct page *page, bool napi_safe)
> 
> Still having the 'page_pool_' prefix seems odd here when it is in the
> skbuff.c where most have skb_ or napi_ prefix, is it better to rename
> it to something like napi_return_page_pool_page()?

Given that how the function that goes next is named, maybe
skb_pp_return_page() (or skb_pp_put_page())?

> 
>> +{
>> +	struct napi_struct *napi;
>> +	struct page_pool *pp;
>> +	bool allow_direct;
>> +
>> +	page = compound_head(page);
>> +
>> +	/* page->pp_magic is OR'ed with PP_SIGNATURE after the allocation
>> +	 * in order to preserve any existing bits, such as bit 0 for the
>> +	 * head page of compound page and bit 1 for pfmemalloc page, so
>> +	 * mask those bits for freeing side when doing below checking,
>> +	 * and page_is_pfmemalloc() is checked in __page_pool_put_page()
>> +	 * to avoid recycling the pfmemalloc page.
>> +	 */
>> +	if (unlikely((page->pp_magic & ~0x3UL) != PP_SIGNATURE))
>> +		return false;
>> +
>> +	pp = page->pp;
>> +
>> +	/* Allow direct recycle if we have reasons to believe that we are
>> +	 * in the same context as the consumer would run, so there's
>> +	 * no possible race.
>> +	 */
>> +	napi = READ_ONCE(pp->p.napi);
>> +	allow_direct = napi_safe && napi &&
>> +		READ_ONCE(napi->list_owner) == smp_processor_id();
>> +
>> +	/* Driver set this to memory recycling info. Reset it on recycle.
>> +	 * This will *not* work for NIC using a split-page memory model.
>> +	 * The page will be returned to the pool here regardless of the
>> +	 * 'flipped' fragment being in use or not.
>> +	 */
>> +	page_pool_put_full_page(pp, page, allow_direct);
>> +
>> +	return true;
>> +}
>> +EXPORT_SYMBOL(page_pool_return_skb_page);
>> +
>>  static bool skb_pp_recycle(struct sk_buff *skb, void *data, bool napi_safe)

(this one)

>>  {
>>  	if (!IS_ENABLED(CONFIG_PAGE_POOL) || !skb->pp_recycle)
>>

Thanks,
Olek