Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759593AbXJ2SI5 (ORCPT ); Mon, 29 Oct 2007 14:08:57 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754172AbXJ2SIs (ORCPT ); Mon, 29 Oct 2007 14:08:48 -0400 Received: from ebiederm.dsl.xmission.com ([166.70.28.69]:35697 "EHLO ebiederm.dsl.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754895AbXJ2SIr (ORCPT ); Mon, 29 Oct 2007 14:08:47 -0400 From: ebiederm@xmission.com (Eric W. Biederman) To: Kirill Korotaev Cc: Linus Torvalds , linux-kernel@vger.kernel.org, Linux Containers , Andrew Morton , Oleg Nesterov , Pavel Emelyanov Subject: Re: [PATCH] pidns: Limit kill -1 and cap_set_all References: <47259BE9.4050904@openvz.org> Date: Mon, 29 Oct 2007 12:07:29 -0600 In-Reply-To: <47259BE9.4050904@openvz.org> (Kirill Korotaev's message of "Mon, 29 Oct 2007 11:38:01 +0300") Message-ID: User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 948 Lines: 26 Kirill Korotaev writes: > I dislike this patch: > it's not scalable/efficient to travers all the tasks > while we know the pid namespace we care about. Well the unix way is to implement it simple and stupid and then to optimize, where needed. We don't currently have a per pid namespace list of processes or tasks. This is a trivial bug fix patch, and I wanted the review to be as simple as possible. I don't expect people are doing kill -1 all that frequently as it is a bit rude. I have no problem doing find_ge_pid and then looking in the hash table like we do in /proc. It likely will have fewer conflicts, but that is a bit harder to review, and is actually more code. Eric - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/