Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d1e720a1-d52c-a14b-3389-a2fb830c208e@amd.com>
Date:   Fri, 28 Jul 2023 21:45:04 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH 1/2] selftests: mm: ksm: Fix incorrect evaluation of
 parameter
Content-Language: en-US
To:     David Hildenbrand <david@redhat.com>, akpm@linux-foundation.org,
        shuah@kernel.org, pasha.tatashin@soleen.com,
        zhansayabagdaulet@gmail.com, tyhicks@linux.microsoft.com,
        raghavendra.kodsarathimmappa@amd.com
Cc:     linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
        linux-kernel@vger.kernel.org, Narasimhan.V@amd.com,
        Santosh.Shukla@amd.com
References: <20230728060109.4403-1-ayush.jain3@amd.com>
 <8e4d9fa7-7550-87a9-ead1-2d2a8691cdab@redhat.com>
From:   Ayush Jain <ayush.jain3@amd.com>
In-Reply-To: <8e4d9fa7-7550-87a9-ead1-2d2a8691cdab@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OWxwSGlHOGwveEZNVE44c2ZlUTJsc0lRRk9yZzZrLzdGd3JqNCtsUU9wQXJv?=
 =?utf-8?B?Qk1kbE5wSlpPN04xdEZGNW1jQ01SRHNEVnBGL0FaVW1oMDJjR3NuQ2JQYXBx?=
 =?utf-8?B?SVRLanVmaG5zRjd4a3YvVGNqZHJKYmRDVWxRUDJ4dG1sclVTckRYWm4xejQ4?=
 =?utf-8?B?WGZ6Ump3aVQ3c3JHMmV3d1hOQUF1SjdDeHBvSHQvaXg1QjhCRklMRWF2UUds?=
 =?utf-8?B?OW1qbS9jdGx4ZnhZSGdBM2F2YlFTelkvU1QyVVk3dGV6cm9sWXcrKzI4OHN1?=
 =?utf-8?B?ZzBmNDF2ZEo2YXpLRVVwOWl4TktNeHordjBxdVFyVXBudThoYzVCV29wVFhJ?=
 =?utf-8?B?TlRROU1QbEsvRVdlWlB6YjZHaE1NTEE0MVZSTkVzNUN5c0l4SDhwM3NaU3E2?=
 =?utf-8?B?S3B2MVpYK3FxY3piSkQ5eVZPSGpUOW9xQXhOVlY1TnZTUXNaOHdEcUV3NVVQ?=
 =?utf-8?B?eUtaRnZST2VGOGRRbHE0eVVaZG1BVk5YQVdrTFFkdVRRcUM3RUswZC9mSW9x?=
 =?utf-8?B?RnFsbFdkb0JnV2hBUTNQc3ovZjIxQ2ZwOENsWWM2VUowVFQ0Y3llTDcvdVFL?=
 =?utf-8?B?NzJRUzFxTldhNFoyekdBYTJac1EybTl4M0xHRWFaVzd1Q280cUM1V3A3QlF0?=
 =?utf-8?B?V2l0RkovN0ZEbnVBRnplOEs2bkJUTU43WTlhY2hqOGowM2JNRjA4Q2FrZGM0?=
 =?utf-8?B?NUo1YXphbm9zTVAwcHc3VW5PaEJDMEtuQnkyZ2VQN2ZmT0Nhd1VRZGRCZi85?=
 =?utf-8?B?YnhxQ3g1TTlHV0d0TmhhNEJROFZFUGttOTJuYUlHMVU2Vk9vZEZpOVMzODNI?=
 =?utf-8?B?eVFJK2lLUmhuZWF5RzZ0R0pmT21zMjlHWjlvcWd6d1lacVRrZTBMcDQvYUJM?=
 =?utf-8?B?aUlFeHd0NkFXZ1ptUHNDaUhjbUFteldZQ0hvK05PVkxYZ25lUzROY1NzR092?=
 =?utf-8?B?Q053ZUp2QjlldmpoV243MXAxOVZnajVVa0tkcEVza1RyblA5Q2dmeitiZmo4?=
 =?utf-8?B?YXVwaUZScHFCTGhqNXBjbXVkUExmUENqWXVHTnNnQjV3Z1M2TEZNYzhwRHhD?=
 =?utf-8?B?TVBsT1RzN2hRR0pJRjQ4d21icnNpYUg3ZTR2N0M4aXNCWTYwMzlKTjlvcnBG?=
 =?utf-8?B?aENkOVhtNVRpWHR1WUM5Kyt6OE90RjFSN1dxcGdaTm1tTnFhUnhxbENnUFB0?=
 =?utf-8?B?cml4QmtwbVlqNlRVTFg5MXNYL0d6aGZTbjhuUnoxWGl0eHRzWjB2UVJYSnRQ?=
 =?utf-8?B?OVVJYzFabVhvYzhQZTRHbjlIeU9RY0VKajlrbzVhYk1oZkphWWxHdWl0ek45?=
 =?utf-8?B?eEFvRjMyRDdndGI5elVrREdNWlowNkpXUCtKTjdUc3VXbUZjZlhIUHhJRW9D?=
 =?utf-8?B?UkMwamlXWERzanBjTWN2ZmNsbmxsZWxJOUE4VisxenV5K0JOVXdsOEFadGxt?=
 =?utf-8?B?eFV1Ry9QSVJwNCt3dmE1YnlXZ1VmdEY4TmxXYjE3dUFGdk9Pb2NUQUJGYVpS?=
 =?utf-8?B?ZnZtRWtBZ3l1cVZ1YzBacnJObmozM1JOaU1GT0VlZGwvT05RRTBuV1lXM1Nr?=
 =?utf-8?B?NGpFSWVJcVIza2lCQlZGWFBJdU5SeGdVYlo2MkNmV2grZmV4aGYxb01kS0Ji?=
 =?utf-8?B?MnBBZ2kvaWdnOTBmR0ZBQWNMVHJUNkpaWmcrVWJSdFhGaFFSWm9GVlVSTUts?=
 =?utf-8?B?OXMxdjBoN1IreGpNNkwzcXRvSEJtcnQyZk5MNER4MzA5RFRqQ1VtVnlzTkpU?=
 =?utf-8?B?c1ovcDQ2bU1pTlBFVEZCNU9tRWR2dmw0a3NPRGE0cFhNbEszU0lydnh6WUh6?=
 =?utf-8?B?a01DY3NJelV3WUNidFA5dFcrZEYxdXhRWkFUM0liSksyMklMQ3JzdHd1Zi9m?=
 =?utf-8?B?dVZaRmlHajcxbkh5VlFuSnAra3FHVm1RWW5ONDBpS2hLWGJ0SFRVN25CSHZ5?=
 =?utf-8?B?MTNjeThIOUEyK1BBU3BFWVhHa09yWHFmOG5Ydi9VUEc5Wjlnc3JvNEFvZWVJ?=
 =?utf-8?B?T2dieVRZKy9OOCtMQ0ZQS2VndStYdjh6WThjYm1kczVkMVh5a011OFRWazFL?=
 =?utf-8?B?cDRaNit3V3hOczRJTWZmVkRXM0NBQnNMSm1GbjlFKzVodGhSV3hCNVZXZWow?=
 =?utf-8?Q?/Kyt+fs/JcYA2RieUMG6jHwtC?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 42ccd3ab-02a2-4e56-6e48-08db8f85d5ed
X-MS-Exchange-CrossTenant-AuthSource: IA1PR12MB6137.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jul 2023 16:15:18.7751
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kdNQkdl3o2jC47u2PU5w7QwauOLWMkoGZ2QGGGRAdW2xo5XZt5z82r4lMUd9Q9kSGHb3DEKy2Dso6n8ZlXUpsg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4249
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello David,

On 7/28/2023 8:05 PM, David Hildenbrand wrote:
> On 28.07.23 08:01, Ayush Jain wrote:
>> A missing break in kms_tests leads to kselftest hang when the
>> parameter -s is used.
>> In current code flow because of missing break in -s, -t parses
>> args spilled from -s and as -t accepts only valid values as 0,1
>> so any arg in -s >1 or <0, gets in ksm_test failure
>>
>> This went undetected since, before the addition of option -t,
>> the next case -M would immediately break out of the switch
>> statement but that is no longer the case
>>
>> Add the missing break statement.
>>
>> ----Before----
>> ./ksm_tests -H -s 100
>> Invalid merge type
>>
>> ----After----
>> ./ksm_tests -H -s 100
>> Number of normal pages:    0
>> Number of huge pages:    50
>> Total size:    100 MiB
>> Total time:    0.401732682 s
>> Average speed:  248.922 MiB/s
>>
>> Fixes: 9e7cb94ca218 ("selftests: vm: add KSM merging time test")
> 
> I think this actually fixes 07115fcc15b4 ("selftests/mm: add new selftests for KSM") that added the "t" parsing.
> 

Sure will update in v2.

> Reviewed-by: David Hildenbrand <david@redhat.com>
> 

Thanks,
Ayush Jain