Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 28 Jul 2023 18:09:45 +0100
From:   Conor Dooley <conor@kernel.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Michal Simek <michal.simek@amd.com>,
        Rajan Vaja <rajan.vaja@xilinx.com>, linux-clk@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        stable@vger.kernel.org,
        Shubhrajyoti Datta <shubhrajyoti.datta@amd.com>
Subject: Re: [PATCH] dt-bindings: clock: xlnx,versal-clk: drop select:false
Message-ID: <20230728-geologic-vending-836dbceeee87@spud>
References: <20230728165923.108589-1-krzysztof.kozlowski@linaro.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="n2nes34cEsEA2WN1"
Content-Disposition: inline
In-Reply-To: <20230728165923.108589-1-krzysztof.kozlowski@linaro.org>
Precedence: bulk


--n2nes34cEsEA2WN1
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Jul 28, 2023 at 06:59:23PM +0200, Krzysztof Kozlowski wrote:
> select:false makes the schema basically ignored and not effective, which
> is clearly not what we want for a device binding.
>=20
> Fixes: 352546805a44 ("dt-bindings: clock: Add bindings for versal clock d=
river")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Thanks for spotting it!
Validation of the other patch seems to function as intended with this
applied.

Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Conor.

>=20
> ---
>=20
> Cc: Shubhrajyoti Datta <shubhrajyoti.datta@amd.com>
> ---
>  Documentation/devicetree/bindings/clock/xlnx,versal-clk.yaml | 2 --
>  1 file changed, 2 deletions(-)
>=20
> diff --git a/Documentation/devicetree/bindings/clock/xlnx,versal-clk.yaml=
 b/Documentation/devicetree/bindings/clock/xlnx,versal-clk.yaml
> index e9cf747bf89b..04ea327d5313 100644
> --- a/Documentation/devicetree/bindings/clock/xlnx,versal-clk.yaml
> +++ b/Documentation/devicetree/bindings/clock/xlnx,versal-clk.yaml
> @@ -14,8 +14,6 @@ description: |
>    reads required input clock frequencies from the devicetree and acts as=
 clock
>    provider for all clock consumers of PS clocks.
> =20
> -select: false
> -
>  properties:
>    compatible:
>      oneOf:
> --=20
> 2.34.1
>=20

--n2nes34cEsEA2WN1
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZMP2WQAKCRB4tDGHoIJi
0nUpAQDumoe1TTNjt3WHWnwpEOmwvvRlQd3uIYODGU7sxqwBjQEAyHtoosnaKD8l
93WfbkVIvBKL3Di0Md8yGLm0yjxbyQc=
=+FoO
-----END PGP SIGNATURE-----

--n2nes34cEsEA2WN1--