Received: by 2002:a05:6358:c692:b0:131:369:b2a3 with SMTP id fe18csp1551544rwb; Fri, 28 Jul 2023 11:02:19 -0700 (PDT) X-Google-Smtp-Source: APBJJlFQjIC03e41FbRCqhMOTVvVG9nGa3S6iqJQHB8dnt3z6oQzrXqUGcV+X9BT+Nl67M2cin0g X-Received: by 2002:a17:90b:1b51:b0:263:f435:ef2d with SMTP id nv17-20020a17090b1b5100b00263f435ef2dmr1878430pjb.10.1690567338693; Fri, 28 Jul 2023 11:02:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690567338; cv=none; d=google.com; s=arc-20160816; b=I961ZtqiFUGRs4JS/RoxE+B3PnzZRVx7Ul2B7zbQD/6C05AA8WG1dxlsY6wp3VUBl3 JAKw1+Xp6WbHRTn4FeTDgHeL0KPlMlW7n4QM4DgJ/6+T5kpe66rYS/W8B9oLazz76s7t HfzN9E/Z8nEbmdJvw4kmVaUnpWcKlorCxwRf3axLNR3QsWxXv9fxX7ZYdy72rCY9S8EK auC1KX5CV79kKy/qBiA59T7iAdwa//bO/r50GwD3RmJNHU8IA7nAbIPjoBir+RD/IYvc dbxYqc0+Yxtgt/lWN8AEkCDhVve4SzSwaQWoXsp7QYSLpuww+FQNQzB1bW/7eHj2+IeR lXMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=9DPcgcn7pzaeyR23aOkzMKbj+QF+0Iy5kf7XOtyyU1Y=; fh=444hKYbcBCWu8jAbol9HzhHorc/GMxQ1VUh/bykMZ/A=; b=NDTwVR/+3lYxn04dUh/4Vp0q7L+meV0sE6b/J1jm9T1ipZ/ja++qhnCSou7UzmgAtT 9JLqjBDDOxLnIyxIQ2OJocMm5/x7dHGYNBaLfz6OlYcXjpAIiCUTBbiM37JUYdoLu4NH VeuIJ2WAIL2j25Pnc9uxJdYqQMoiqF6xCnytCdoRMhczIul4McKZzK4GBZdiDv05Lp/3 CT5VQe7cWqPLpmyPesJQqpvKHNfRP3otf21WeOywktqXyLw6/zgyIU3sR8DWXaAbxMBx 8XV75rxrAro+ttUTBukVqMiFk7/UlPYjFFU3piCFfjFymeA67bi/dEWOnTcOxb23vNCJ Np9Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=L1PBr6Tc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h70-20020a638349000000b00563e904db64si3362776pge.385.2023.07.28.11.02.04; Fri, 28 Jul 2023 11:02:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=L1PBr6Tc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232463AbjG1RlK (ORCPT + 99 others); Fri, 28 Jul 2023 13:41:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37000 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229530AbjG1RlI (ORCPT ); Fri, 28 Jul 2023 13:41:08 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4BF4C10CB; Fri, 28 Jul 2023 10:41:06 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D2605621BE; Fri, 28 Jul 2023 17:41:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BC7C8C433C8; Fri, 28 Jul 2023 17:41:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1690566065; bh=9DPcgcn7pzaeyR23aOkzMKbj+QF+0Iy5kf7XOtyyU1Y=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=L1PBr6Tcnx3CaNQEzImZCiiC8GGuMXX0uCH/dKs0aevRVD6d5JIu6YMxG+VYk+KCZ WVk2deNn3J0NjN2Fq5eR6pBv5NTHGQv74VdNC900ARvpokqXhRTa1hlYR5Fx0p0OdZ 2TzU7RRdMzMlUG7kOF8e/GG1Udvzh0bEMGtaGvbE= Date: Fri, 28 Jul 2023 10:41:03 -0700 From: Andrew Morton To: Yin Fengwei Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, willy@infradead.org, vishal.moola@gmail.com, wangkefeng.wang@huawei.com, minchan@kernel.org, yuzhao@google.com, david@redhat.com, ryan.roberts@arm.com, shy828301@gmail.com Subject: Re: [PATCH 2/2] madvise: don't use mapcount() against large folio for sharing check Message-Id: <20230728104103.1357b394f9be6352a7c54c79@linux-foundation.org> In-Reply-To: <20230728161356.1784568-3-fengwei.yin@intel.com> References: <20230728161356.1784568-1-fengwei.yin@intel.com> <20230728161356.1784568-3-fengwei.yin@intel.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 29 Jul 2023 00:13:56 +0800 Yin Fengwei wrote: > Fixes: 98b211d6415f ("madvise: convert madvise_free_pte_range() to use a folio") > Fixes: fc986a38b670 ("mm: huge_memory: convert madvise_free_huge_pmd to use a folio") Having two Fixes: for one patch presumably makes backporting more complicated and adds risk of making mistakes. So I have split this into a three-patch series and I've fixed up the patch naming: Subject: madvise:madvise_cold_or_pageout_pte_range(): don't use mapcount() against large folio for sharing check Subject: madvise:madvise_free_huge_pmd(): don't use mapcount() against large folio for sharing check Subject: madvise:madvise_free_pte_range(): don't use mapcount() against large folio for sharing check I haven't added cc:stable at this time - that awaits the description of user-visible effects.