Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <202307271413.eb0fd426-oliver.sang@intel.com>
In-Reply-To: <202307271413.eb0fd426-oliver.sang@intel.com>
From:   Ian Rogers <irogers@google.com>
Date:   Fri, 28 Jul 2023 10:36:30 -0700
Message-ID: <CAP-5=fUAcG+CzneUx0M0+3bxCvs6iTb=roaLp_qxi3j_KsUVpg@mail.gmail.com>
Subject: Re: [linus:master] [perf map/maps/thread] bffb5b0c09: perf-sanity-tests.probe_libc's_inet_pton_&_backtrace_it_with_ping.fail
To:     kernel test robot <oliver.sang@intel.com>
Cc:     oe-lkp@lists.linux.dev, lkp@intel.com,
        linux-kernel@vger.kernel.org,
        Arnaldo Carvalho de Melo <acme@redhat.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Ali Saidi <alisaidi@amazon.com>,
        Andi Kleen <ak@linux.intel.com>,
        Athira Rajeev <atrajeev@linux.vnet.ibm.com>,
        Brian Robbins <brianrob@linux.microsoft.com>,
        Changbin Du <changbin.du@huawei.com>,
        Dmitrii Dolgov <9erthalion6@gmail.com>,
        Fangrui Song <maskray@google.com>,
        German Gomez <german.gomez@arm.com>,
        Ingo Molnar <mingo@redhat.com>,
        Ivan Babrou <ivan@cloudflare.com>,
        James Clark <james.clark@arm.com>,
        Jing Zhang <renyu.zj@linux.alibaba.com>,
        Jiri Olsa <jolsa@kernel.org>,
        John Garry <john.g.garry@oracle.com>,
        K Prateek Nayak <kprateek.nayak@amd.com>,
        Kan Liang <kan.liang@linux.intel.com>,
        Leo Yan <leo.yan@linaro.org>,
        Liam Howlett <liam.howlett@oracle.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Miguel Ojeda <ojeda@kernel.org>,
        Mike Leach <mike.leach@linaro.org>,
        Namhyung Kim <namhyung@kernel.org>,
        "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Ravi Bangoria <ravi.bangoria@amd.com>,
        Sean Christopherson <seanjc@google.com>,
        "Steinar H. Gunderson" <sesse@google.com>,
        Suzuki Poulouse <suzuki.poulose@arm.com>,
        Wenyu Liu <liuwenyu7@huawei.com>,
        Will Deacon <will@kernel.org>,
        Yang Jihong <yangjihong1@huawei.com>,
        Ye Xingchen <ye.xingchen@zte.com.cn>,
        Yuan Can <yuancan@huawei.com>, linux-perf-users@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Jul 26, 2023 at 11:43=E2=80=AFPM kernel test robot
<oliver.sang@intel.com> wrote:
>
>
> hi, Ian Rogers,
>
> we noticed this is a fix commit, and we really found some perf-sanity-tes=
ts
> can pass on this commit now.
> however, probe_libc's_inet_pton_&_backtrace_it_with_ping started to fail =
on this
> commit.
>
> 1981da1fe2499823 bffb5b0c0976aa46aaa961dd19a
> ---------------- ---------------------------
>        fail:runs  %reproduction    fail:runs
>            |             |             |
>            :6          100%           6:6     perf-sanity-tests.Check_bra=
nch_stack_sampling.pass
>            :6          100%           6:6     perf-sanity-tests.Cumulate_=
child_hist_entries.pass
>            :6          100%           6:6     perf-sanity-tests.dlfilter_=
C_API.pass
>            :6          100%           6:6     perf-sanity-tests.perf_pipe=
_recording_and_injection_test.pass
>            :6          100%           6:6     perf-sanity-tests.probe_lib=
c's_inet_pton_&_backtrace_it_with_ping.fail
>
> below is detail.
>
> Hello,
>
> kernel test robot noticed "perf-sanity-tests.probe_libc's_inet_pton_&_bac=
ktrace_it_with_ping.fail" on:
>
> commit: bffb5b0c0976aa46aaa961dd19a47c9d6301cfe1 ("perf map/maps/thread: =
Changes to reference counting")
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master
>
> [test failed on linus/master 18b44bc5a67275641fb26f2c54ba7eef80ac5950]
> [test failed on linux-next/master 0ba5d07205771c50789fd9063950aa75e7f1183=
f]

Is this failing at head or is this another please use my time machine
and go fix the past request? The most recent fixes in this area were
in May by Thomas Richter:
https://lore.kernel.org/r/20230503081255.3372986-1-tmricht@linux.ibm.com
This isn't failing for me either in 6.5-rc3 or at perf-tools-next
head. The test output doesn't contain an indication of what the error
is. I don't think there is anything actionable here.

Thanks,
Ian

> in testcase: perf-sanity-tests
> version: perf-x86_64-00c7b5f4ddc5-1_20230402
> with following parameters:
>
>         perf_compiler: gcc
>
>
>
> compiler: gcc-12
> test machine: 224 threads 2 sockets Intel(R) Xeon(R) Platinum 8480+ (Sapp=
hire Rapids) with 256G memory
>
> (please refer to attached dmesg/kmsg for entire log/backtrace)
>
>
>
>
> If you fix the issue in a separate patch/commit (i.e. not just a new vers=
ion of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <oliver.sang@intel.com>
> | Closes: https://lore.kernel.org/oe-lkp/202307271413.eb0fd426-oliver.san=
g@intel.com
>
>
> ...
>  88: perf pipe recording and injection test                          : Ok
>  89: Add vfs_getname probe to get syscall args filenames             : Sk=
ip
>  90: probe libc's inet_pton & backtrace it with ping                 : FA=
ILED!   <---
>  91: Use vfs_getname probe to get syscall args filenames             : Sk=
ip
>  92: Zstd perf.data compression/decompression                        : Ok
> ...
>
>
> To reproduce:
>
>         git clone https://github.com/intel/lkp-tests.git
>         cd lkp-tests
>         sudo bin/lkp install job.yaml           # job file is attached in=
 this email
>         bin/lkp split-job --compatible job.yaml # generate the yaml file =
for lkp run
>         sudo bin/lkp run generated-yaml-file
>
>         # if come across any failure that blocks the test,
>         # please remove ~/.lkp and /lkp dir to run from a clean state.
>
>
>
> --
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki
>
>