Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Shenwei Wang <shenwei.wang@nxp.com>
To:     Andrew Lunn <andrew@lunn.ch>
CC:     Fabio Estevam <festevam@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Neil Armstrong <neil.armstrong@linaro.org>,
        Kevin Hilman <khilman@baylibre.com>,
        Vinod Koul <vkoul@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        Samuel Holland <samuel@sholland.org>,
        Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>,
        Jose Abreu <joabreu@synopsys.com>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        dl-linux-imx <linux-imx@nxp.com>,
        Jerome Brunet <jbrunet@baylibre.com>,
        Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
        Bhupesh Sharma <bhupesh.sharma@linaro.org>,
        Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>,
        Simon Horman <simon.horman@corigine.com>,
        Andrew Halaney <ahalaney@redhat.com>,
        Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
        Wong Vee Khee <veekhee@apple.com>,
        Revanth Kumar Uppala <ruppala@nvidia.com>,
        Jochen Henneberg <jh@henneberg-systemdesign.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-stm32@st-md-mailman.stormreply.com" 
        <linux-stm32@st-md-mailman.stormreply.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-amlogic@lists.infradead.org" 
        <linux-amlogic@lists.infradead.org>,
        "imx@lists.linux.dev" <imx@lists.linux.dev>,
        Frank Li <frank.li@nxp.com>
Subject: RE: [EXT] Re: [PATCH v2 net 2/2] net: stmmac: dwmac-imx: pause the
 TXC clock in fixed-link
Thread-Topic: [EXT] Re: [PATCH v2 net 2/2] net: stmmac: dwmac-imx: pause the
 TXC clock in fixed-link
Thread-Index: AQHZwJ6ZmPtrsmRv9UGenRTta+C4Xq/PBDcAgABC5ICAACBXAIAAAQnQ
Date:   Fri, 28 Jul 2023 17:01:46 +0000
Message-ID: <PAXPR04MB9185168AEBA2FD0F7D5885028906A@PAXPR04MB9185.eurprd04.prod.outlook.com>
References: <20230727152503.2199550-1-shenwei.wang@nxp.com>
 <20230727152503.2199550-3-shenwei.wang@nxp.com>
 <CAOMZO5ANQmVbk_jy7qdVtzs3716FisT2c72W+3WZyu7FoAochw@mail.gmail.com>
 <PAXPR04MB9185945F7E5B1A36ADF4F3E28906A@PAXPR04MB9185.eurprd04.prod.outlook.com>
 <f6c78350-e668-455f-bae5-731dbef633de@lunn.ch>
In-Reply-To: <f6c78350-e668-455f-bae5-731dbef633de@lunn.ch>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?MTKuyRdQY56rhUrnsfeeS7GjqBnsGajI0XCeWjxJJOPm+098rNaYzeiCcMIU?=
 =?us-ascii?Q?k1dQ0YyWxSE2gJQtl9qDIhnE2MeMvBeYtQSCzvytievFuKxPURENcdnxWIwE?=
 =?us-ascii?Q?mT10Tf2lb53cd2M7yoM86woVPRK4KwwXlGB8djgBLEDkIWXjRMNFRWNGkxot?=
 =?us-ascii?Q?LZR9l9hHYaQFt6gxDxcQUNFUoM1P+fdwLqBM2XKf/JuZw5ZFEo7ZfYDJRPg0?=
 =?us-ascii?Q?sp5KanZDxcUDD3i4S2R9+IYGBG85BIFM1ARiarUL5Ub5B/wzInHZADqMwj2C?=
 =?us-ascii?Q?ACSFaUU9ow4bAKDFAidvsBvubwl+0c3t0DKV4hCkipz2Wp2foolGUF1K5sRx?=
 =?us-ascii?Q?sRyWgbJWgOYA4iE27mdCiHTKmAEuBc5dJgRfbRYswi3d82+3FmHNkYNLw3fB?=
 =?us-ascii?Q?QpylX5l+o95USY0quhy7B2KupxInAgPc66EhLqLktCtLYRNGplvwjOlZGltR?=
 =?us-ascii?Q?Xo/hcBqlAe+8HdnzDWpGQcN+8tLYBVpOye3t5vjA497ZFLpbSZuJ2W0dM5AW?=
 =?us-ascii?Q?XKsjpVkMxL5Sx2Jy+9HAkorxLH5+xeDQx4Q1xFc6dt/OFgsFA5Ibv6usjZM7?=
 =?us-ascii?Q?ep0LMF4o6IbdtT3Pz/vqgRQ/qU0glbtpnXTWq3EYl8Hwr0x1E8dAqDQc/mJe?=
 =?us-ascii?Q?vFEUZ1KR8hxzyCh2JTNQT9N9QgEe8l80KeU1A2qQ5gs5NAs1BT3PhGHZNUEG?=
 =?us-ascii?Q?GCJiuGDAuUdKMGnAD0II7vrJNKs+Js22mLaJ8+JaB5EqCG9AI32HGxRtq3A0?=
 =?us-ascii?Q?KiBtjEQUhbqpj/4C78NNySY4Rlbf4YGI730aIKNG72HBblugLAta2OZwmcs/?=
 =?us-ascii?Q?WwL2Nr0ICQKrABIsxwMwXShUrcePPDv8/Wzo7JI/HD9gi5H2LN7/lR/zU3Wf?=
 =?us-ascii?Q?RDdd4qmaPAVCShKjiCTvbctPl+Zrr5IrR/Hqwn78fU+bvfCXmajZC4DRQbvA?=
 =?us-ascii?Q?OOwkAurvCka7Ywb8FgxjHXLSJKiOVMeVuyd6t0Ze/LKlkA5ZaIeElvWVdfJ1?=
 =?us-ascii?Q?VS5FTIckrrZt89vlxacuG7I0PFbOuQbbktIhPRSYiDgHYr00TU0qfvnfuC9r?=
 =?us-ascii?Q?I3aaT3x7Jjz1VNyD2nG99sp7WbrrPzxklreLqiXMn8pZm6PaOcL/RCWlXjE7?=
 =?us-ascii?Q?HRgsZDCYL+Du+DZhw4un5lKEKqb0Ibky3Y6ZDnjH2B16kPc2tlgr8TZ2wmkS?=
 =?us-ascii?Q?1614QTauWzRDObyitL0dUOvkvhU96YLhCa/Bz6VYvKO62Eic7qD4B8ZRfGoB?=
 =?us-ascii?Q?orJWu/NGuWdwYN0LGysNmWllpdowvJz0fSL2crplPQpoL4VM5/G9j0FvkgeR?=
 =?us-ascii?Q?ooxGUS3tAq0g87qqg04rzyfH3Q1M5huKtbYVgdvBcKzMLwpswZ557hFNg7BB?=
 =?us-ascii?Q?Ol+yodou3bx4j/jsBN6BHcKRtjE0MQFTcoYEBuUKPNcQ0TegOTQF9qOChlwT?=
 =?us-ascii?Q?P946MfE9h5CiFibPlmTmGgGTQIiu0oFkESxNv3MymNySJKDfSfLhJX622ANt?=
 =?us-ascii?Q?Q9ndSuYJMVlYdOpXqZzqnwGxYwAoxNuV5FZm2PfwriFH7944FjbdoplxWm4W?=
 =?us-ascii?Q?KzcY/FW3hM/DM3UVhfThMBzZvbiqDExc2okPc+Pr?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9185.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a192947b-4105-4b81-88ad-08db8f8c53bb
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jul 2023 17:01:46.5642
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: FNdiOtHxKOVzeLZ4nMBPGFN/IwW0az/Qurx7krTf/rn4j1tiNVyCGBoKwClv/c6VBU4gCtP9NDxNy+4AHKOLgQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8766
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Andrew Lunn <andrew@lunn.ch>
> Sent: Friday, July 28, 2023 11:56 AM
> To: Shenwei Wang <shenwei.wang@nxp.com>
> Cc: Fabio Estevam <festevam@gmail.com>; Russell King
> <linux@armlinux.org.uk>; David S. Miller <davem@davemloft.net>; Eric
> Dumazet <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo
> Abeni <pabeni@redhat.com>; Maxime Coquelin
> <mcoquelin.stm32@gmail.com>; Shawn Guo <shawnguo@kernel.org>; Sascha
> Hauer <s.hauer@pengutronix.de>; Neil Armstrong <neil.armstrong@linaro.org=
>;
> Kevin Hilman <khilman@baylibre.com>; Vinod Koul <vkoul@kernel.org>; Chen-
> Yu Tsai <wens@csie.org>; Jernej Skrabec <jernej.skrabec@gmail.com>; Samue=
l
> Holland <samuel@sholland.org>; Giuseppe Cavallaro
> <peppe.cavallaro@st.com>; Alexandre Torgue <alexandre.torgue@foss.st.com>=
;
> Jose Abreu <joabreu@synopsys.com>; Pengutronix Kernel Team
> <kernel@pengutronix.de>; dl-linux-imx <linux-imx@nxp.com>; Jerome Brunet
> <jbrunet@baylibre.com>; Martin Blumenstingl
> <martin.blumenstingl@googlemail.com>; Bhupesh Sharma
> <bhupesh.sharma@linaro.org>; Nobuhiro Iwamatsu
> <nobuhiro1.iwamatsu@toshiba.co.jp>; Simon Horman
> <simon.horman@corigine.com>; Andrew Halaney <ahalaney@redhat.com>;
> Bartosz Golaszewski <bartosz.golaszewski@linaro.org>; Wong Vee Khee
> <veekhee@apple.com>; Revanth Kumar Uppala <ruppala@nvidia.com>; Jochen
> Henneberg <jh@henneberg-systemdesign.com>; netdev@vger.kernel.org; linux-
> stm32@st-md-mailman.stormreply.com; linux-arm-kernel@lists.infradead.org;
> linux-kernel@vger.kernel.org; linux-amlogic@lists.infradead.org;
> imx@lists.linux.dev; Frank Li <frank.li@nxp.com>
> Subject: Re: [EXT] Re: [PATCH v2 net 2/2] net: stmmac: dwmac-imx: pause t=
he
> TXC clock in fixed-link
>=20
> Caution: This is an external email. Please take care when clicking links =
or
> opening attachments. When in doubt, report the message using the 'Report =
this
> email' button
>=20
>=20
> > > Andrew Lunn gave the following feedback in v1:
> > >
> > > "The SJA1105 has the problem, so i would expect it to be involved in =
the
> solution.
> > > Otherwise, how is this going to work for other MAC drivers?
> > >
> > > Maybe you need to expose a common clock framework clock for the TXC
> > > clock line, which the SJA1105 can disable/enable? That then makes it
> > > clear what other MAC drivers need to do."
> >
> > I have been considering this plan for some time. The idea should be
> > implemented across all i.mx8/9 platforms. I am going to start to work
> > on it in the following month, and it will take some time to implement i=
t.
>=20
> So you don't think anybody will use anything else for driving this switch=
? Vybrid?
>=20

Vybrid or i.MX6 don't have such kind of problem because they are not using =
dwmac.
Those are FEC MACs, and the MAC itself can provide delay to the switch.

Thanks,
Shenwei

> It does not really matter what you implement it for, so long is at is a c=
lear
> example for others to follow who might be using the switch with other SoC=
s.
>=20
>         Andrew