Received: by 2002:a05:6358:c692:b0:131:369:b2a3 with SMTP id fe18csp1570032rwb; Fri, 28 Jul 2023 11:18:08 -0700 (PDT) X-Google-Smtp-Source: APBJJlElybc0V04U/68g4kmKDeWoBgpsWz8U3ZC1UKVeT37szGs94TGH7Z4uKgg5NFIpS4EO8ZkH X-Received: by 2002:a05:6402:7c6:b0:521:aeba:c6c0 with SMTP id u6-20020a05640207c600b00521aebac6c0mr2359238edy.36.1690568288622; Fri, 28 Jul 2023 11:18:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690568288; cv=none; d=google.com; s=arc-20160816; b=i6v7+z2IGkbAy0KGvOJutnPfFPprpObX23B2nV8xJP6Me0Nrj9v3j0/0KdnLoDrpRB oDO7Xg00AcxkPDDVGUc8DQk79RjayulJKO2Fm555ipQeFar/InOk2apDC8oPRwayqeg4 v19wSTy5JrQZbaDQThWZyvcdT4iaUOS62eWS5EKGSzONZcC+y0Vj5mCldMAvA1fOJV5Q iorPzxwx84dFyMyw4+x0HDkl45mpaawg+DiKCg4cz5oZ7A8TN5Hybzpe6vNBZYnBVqhb cVLrHAOni3TJtf+kwAs/pmZc00QJ4UP9Xm/V0rZeIJ8NyC6mRhPAGgRem4x0MgDtNU01 g36w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=9VjY5Y713Uo9H4MrMvmCIZIjWdtRiGyMxovmYnkrO9Q=; fh=f+iiYXQjmSf1nqFclPF6h/9UCtqKRnuqcbTApcdAJ9s=; b=Uoh98OUsSqJk+r4lM0Y4u3fhPBjdefWQI5Zvr1xBfpVW2ndgIaIe+JqY+KANIgbsZU uJkTOFgrieWPrNEhyvIg9HgnmvSwokZA6x7T6lXjBrwhnZdyrfzKgP7DlnlO/s5TCXD9 MrrNOA5cncXrCGwjjIlqgrTV6X8T15noWtZ0UtSJXSe8IyhXLqlb199Aej3V071c17jt s+cV6ReGjNhZQzFchGv+dY439ptMRsYKkngv5Qdm2BngjMgbTvIwkrAp3Y4WK40H2KQy vuNk3nIsr2DKalYgcEeSr0dsILT70MsajkzO0rkphiywo3Y1iIapqPYpSncX8GTM/Wl8 XPjA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="C/ttZ6z+"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l27-20020a056402345b00b0052026a148cesi3025461edc.44.2023.07.28.11.17.42; Fri, 28 Jul 2023 11:18:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="C/ttZ6z+"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233277AbjG1R0B (ORCPT + 99 others); Fri, 28 Jul 2023 13:26:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53224 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233555AbjG1RZz (ORCPT ); Fri, 28 Jul 2023 13:25:55 -0400 Received: from mgamail.intel.com (unknown [134.134.136.31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EFF7535A9; Fri, 28 Jul 2023 10:25:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690565153; x=1722101153; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=GcL6iaETqQVjARAggiZd0t1TXOwNu7pm47nX2v7oMMc=; b=C/ttZ6z+iiXQMGK8J0uGYX6uzQsZXjxkBYHcn0kqnaQh3RLEJNxiPfia 8QjVN5k6RFNI7sYqI9y1jwJsfCpBqO1ZpwtRbMCMdvyFyNoTnpGOHhrYi whDS/BqOkO864k3ca+dnjXRN3f+xBOUnAu2ocfs4GsR9/C99cYamc2bCR zTU5vnEvio5+/QL/nlhPCN4+NicWjo3HWjEqO9e5P7RsQfi+5GF/gRfDq QX8U+rD4+D4Q+3utp5YCkz6DMVtD/lBQHPZxWKK1KxJPgnbo86CYT91mU UNicbd5dRkx7BYpiOCm0QjpopbQe/A30uHuMw4nEQOvmlqmhrgBq9g2Qk w==; X-IronPort-AV: E=McAfee;i="6600,9927,10784"; a="432457380" X-IronPort-AV: E=Sophos;i="6.01,238,1684825200"; d="scan'208";a="432457380" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jul 2023 10:25:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10784"; a="901363987" X-IronPort-AV: E=Sophos;i="6.01,238,1684825200"; d="scan'208";a="901363987" Received: from lkp-server02.sh.intel.com (HELO 953e8cd98f7d) ([10.239.97.151]) by orsmga005.jf.intel.com with ESMTP; 28 Jul 2023 10:25:42 -0700 Received: from kbuild by 953e8cd98f7d with local (Exim 4.96) (envelope-from ) id 1qPRDc-0003QX-0D; Fri, 28 Jul 2023 17:25:37 +0000 Date: Sat, 29 Jul 2023 01:25:10 +0800 From: kernel test robot To: Janusz Krzysztofik , Brendan Higgins , David Gow Cc: oe-kbuild-all@lists.linux.dev, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, Mauro Carvalho Chehab , linux-media@vger.kernel.org, igt-dev@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] kunit: Allow kunit test modules to use test filtering Message-ID: <202307290108.PShSxJaM-lkp@intel.com> References: <20230728154419.1810177-8-janusz.krzysztofik@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230728154419.1810177-8-janusz.krzysztofik@linux.intel.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Janusz, kernel test robot noticed the following build errors: [auto build test ERROR on shuah-kselftest/kunit-fixes] [also build test ERROR on linus/master v6.5-rc3] [cannot apply to shuah-kselftest/kunit next-20230728] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Janusz-Krzysztofik/kunit-Report-the-count-of-test-suites-in-a-module/20230728-234736 base: https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git kunit-fixes patch link: https://lore.kernel.org/r/20230728154419.1810177-8-janusz.krzysztofik%40linux.intel.com patch subject: [PATCH 3/3] kunit: Allow kunit test modules to use test filtering config: arc-randconfig-r043-20230728 (https://download.01.org/0day-ci/archive/20230729/202307290108.PShSxJaM-lkp@intel.com/config) compiler: arc-elf-gcc (GCC) 12.3.0 reproduce: (https://download.01.org/0day-ci/archive/20230729/202307290108.PShSxJaM-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202307290108.PShSxJaM-lkp@intel.com/ All error/warnings (new ones prefixed by >>): >> lib/kunit/executor.c:182:42: warning: 'struct suite_set' declared inside parameter list will not be visible outside of this definition or declaration 182 | static void kunit_exec_list_tests(struct suite_set *suite_set) | ^~~~~~~~~ lib/kunit/executor.c: In function 'kunit_exec_list_tests': >> lib/kunit/executor.c:190:32: error: invalid use of undefined type 'struct suite_set' 190 | for (suites = suite_set->start; suites < suite_set->end; suites++) | ^~ lib/kunit/executor.c:190:59: error: invalid use of undefined type 'struct suite_set' 190 | for (suites = suite_set->start; suites < suite_set->end; suites++) | ^~ lib/kunit/executor.c: In function 'kunit_run_all_tests': >> lib/kunit/executor.c:198:16: error: variable 'suite_set' has initializer but incomplete type 198 | struct suite_set suite_set = {__kunit_suites_start, __kunit_suites_end}; | ^~~~~~~~~ >> lib/kunit/executor.c:198:39: warning: excess elements in struct initializer 198 | struct suite_set suite_set = {__kunit_suites_start, __kunit_suites_end}; | ^~~~~~~~~~~~~~~~~~~~ lib/kunit/executor.c:198:39: note: (near initialization for 'suite_set') lib/kunit/executor.c:198:61: warning: excess elements in struct initializer 198 | struct suite_set suite_set = {__kunit_suites_start, __kunit_suites_end}; | ^~~~~~~~~~~~~~~~~~ lib/kunit/executor.c:198:61: note: (near initialization for 'suite_set') >> lib/kunit/executor.c:198:26: error: storage size of 'suite_set' isn't known 198 | struct suite_set suite_set = {__kunit_suites_start, __kunit_suites_end}; | ^~~~~~~~~ lib/kunit/executor.c:198:26: warning: unused variable 'suite_set' [-Wunused-variable] In file included from lib/kunit/executor.c:230: lib/kunit/executor_test.c: In function 'filter_suites_test': >> lib/kunit/executor_test.c:45:16: error: variable 'suite_set' has initializer but incomplete type 45 | struct suite_set suite_set = {.start = subsuite, .end = &subsuite[2]}; | ^~~~~~~~~ >> lib/kunit/executor_test.c:45:40: error: 'struct suite_set' has no member named 'start' 45 | struct suite_set suite_set = {.start = subsuite, .end = &subsuite[2]}; | ^~~~~ >> lib/kunit/executor_test.c:45:48: warning: excess elements in struct initializer 45 | struct suite_set suite_set = {.start = subsuite, .end = &subsuite[2]}; | ^~~~~~~~ lib/kunit/executor_test.c:45:48: note: (near initialization for 'suite_set') >> lib/kunit/executor_test.c:45:59: error: 'struct suite_set' has no member named 'end' 45 | struct suite_set suite_set = {.start = subsuite, .end = &subsuite[2]}; | ^~~ lib/kunit/executor_test.c:45:65: warning: excess elements in struct initializer 45 | struct suite_set suite_set = {.start = subsuite, .end = &subsuite[2]}; | ^ lib/kunit/executor_test.c:45:65: note: (near initialization for 'suite_set') >> lib/kunit/executor_test.c:45:26: error: storage size of 'suite_set' isn't known 45 | struct suite_set suite_set = {.start = subsuite, .end = &subsuite[2]}; | ^~~~~~~~~ >> lib/kunit/executor_test.c:46:26: error: storage size of 'got' isn't known 46 | struct suite_set got; | ^~~ In file included from lib/kunit/executor.c:4: >> include/kunit/test.h:737:29: warning: passing argument 1 of 'IS_ERR_OR_NULL' makes pointer from integer without a cast [-Wint-conversion] 737 | if (!IS_ERR_OR_NULL(__ptr)) \ | ^~~~~ | | | int include/kunit/test.h:1418:9: note: in expansion of macro 'KUNIT_PTR_NOT_ERR_OR_NULL_MSG_ASSERTION' 1418 | KUNIT_PTR_NOT_ERR_OR_NULL_MSG_ASSERTION(test, \ | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/kunit/test.h:1415:9: note: in expansion of macro 'KUNIT_ASSERT_NOT_ERR_OR_NULL_MSG' 1415 | KUNIT_ASSERT_NOT_ERR_OR_NULL_MSG(test, ptr, NULL) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ lib/kunit/executor_test.c:54:9: note: in expansion of macro 'KUNIT_ASSERT_NOT_ERR_OR_NULL' 54 | KUNIT_ASSERT_NOT_ERR_OR_NULL(test, got.start); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from include/linux/rwsem.h:17, from include/linux/notifier.h:15, from include/linux/reboot.h:6, from lib/kunit/executor.c:3: include/linux/err.h:70:68: note: expected 'const void *' but argument is of type 'int' 70 | static inline bool __must_check IS_ERR_OR_NULL(__force const void *ptr) | ~~~~~~~~~~~~^~~ >> include/kunit/test.h:744:64: warning: initialization of 'const void *' from 'int' makes pointer from integer without a cast [-Wint-conversion] 744 | KUNIT_INIT_ASSERT(.text = #ptr, .value = __ptr), \ | ^~~~~ include/kunit/test.h:510:49: note: in definition of macro '_KUNIT_FAILED' 510 | const struct assert_class __assertion = INITIALIZER; \ | ^~~~~~~~~~~ include/kunit/test.h:744:23: note: in expansion of macro 'KUNIT_INIT_ASSERT' 744 | KUNIT_INIT_ASSERT(.text = #ptr, .value = __ptr), \ | ^~~~~~~~~~~~~~~~~ include/kunit/test.h:1418:9: note: in expansion of macro 'KUNIT_PTR_NOT_ERR_OR_NULL_MSG_ASSERTION' 1418 | KUNIT_PTR_NOT_ERR_OR_NULL_MSG_ASSERTION(test, \ | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/kunit/test.h:1415:9: note: in expansion of macro 'KUNIT_ASSERT_NOT_ERR_OR_NULL_MSG' 1415 | KUNIT_ASSERT_NOT_ERR_OR_NULL_MSG(test, ptr, NULL) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ lib/kunit/executor_test.c:54:9: note: in expansion of macro 'KUNIT_ASSERT_NOT_ERR_OR_NULL' 54 | KUNIT_ASSERT_NOT_ERR_OR_NULL(test, got.start); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/kunit/test.h:744:64: note: (near initialization for '__assertion.value') 744 | KUNIT_INIT_ASSERT(.text = #ptr, .value = __ptr), \ | ^~~~~ include/kunit/test.h:510:49: note: in definition of macro '_KUNIT_FAILED' 510 | const struct assert_class __assertion = INITIALIZER; \ | ^~~~~~~~~~~ include/kunit/test.h:744:23: note: in expansion of macro 'KUNIT_INIT_ASSERT' 744 | KUNIT_INIT_ASSERT(.text = #ptr, .value = __ptr), \ | ^~~~~~~~~~~~~~~~~ include/kunit/test.h:1418:9: note: in expansion of macro 'KUNIT_PTR_NOT_ERR_OR_NULL_MSG_ASSERTION' 1418 | KUNIT_PTR_NOT_ERR_OR_NULL_MSG_ASSERTION(test, \ | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/kunit/test.h:1415:9: note: in expansion of macro 'KUNIT_ASSERT_NOT_ERR_OR_NULL_MSG' 1415 | KUNIT_ASSERT_NOT_ERR_OR_NULL_MSG(test, ptr, NULL) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ lib/kunit/executor_test.c:54:9: note: in expansion of macro 'KUNIT_ASSERT_NOT_ERR_OR_NULL' 54 | KUNIT_ASSERT_NOT_ERR_OR_NULL(test, got.start); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> include/kunit/test.h:737:29: warning: passing argument 1 of 'IS_ERR_OR_NULL' makes pointer from integer without a cast [-Wint-conversion] 737 | if (!IS_ERR_OR_NULL(__ptr)) \ | ^~~~~ | | | int include/kunit/test.h:1418:9: note: in expansion of macro 'KUNIT_PTR_NOT_ERR_OR_NULL_MSG_ASSERTION' 1418 | KUNIT_PTR_NOT_ERR_OR_NULL_MSG_ASSERTION(test, \ | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/kunit/test.h:1415:9: note: in expansion of macro 'KUNIT_ASSERT_NOT_ERR_OR_NULL_MSG' 1415 | KUNIT_ASSERT_NOT_ERR_OR_NULL_MSG(test, ptr, NULL) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ lib/kunit/executor_test.c:59:9: note: in expansion of macro 'KUNIT_ASSERT_NOT_ERR_OR_NULL' 59 | KUNIT_ASSERT_NOT_ERR_OR_NULL(test, got.start[0]); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/err.h:70:68: note: expected 'const void *' but argument is of type 'int' 70 | static inline bool __must_check IS_ERR_OR_NULL(__force const void *ptr) | ~~~~~~~~~~~~^~~ >> include/kunit/test.h:744:64: warning: initialization of 'const void *' from 'int' makes pointer from integer without a cast [-Wint-conversion] 744 | KUNIT_INIT_ASSERT(.text = #ptr, .value = __ptr), \ | ^~~~~ include/kunit/test.h:510:49: note: in definition of macro '_KUNIT_FAILED' 510 | const struct assert_class __assertion = INITIALIZER; \ | ^~~~~~~~~~~ include/kunit/test.h:744:23: note: in expansion of macro 'KUNIT_INIT_ASSERT' 744 | KUNIT_INIT_ASSERT(.text = #ptr, .value = __ptr), \ | ^~~~~~~~~~~~~~~~~ include/kunit/test.h:1418:9: note: in expansion of macro 'KUNIT_PTR_NOT_ERR_OR_NULL_MSG_ASSERTION' 1418 | KUNIT_PTR_NOT_ERR_OR_NULL_MSG_ASSERTION(test, \ | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/kunit/test.h:1415:9: note: in expansion of macro 'KUNIT_ASSERT_NOT_ERR_OR_NULL_MSG' 1415 | KUNIT_ASSERT_NOT_ERR_OR_NULL_MSG(test, ptr, NULL) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ lib/kunit/executor_test.c:59:9: note: in expansion of macro 'KUNIT_ASSERT_NOT_ERR_OR_NULL' 59 | KUNIT_ASSERT_NOT_ERR_OR_NULL(test, got.start[0]); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/kunit/test.h:744:64: note: (near initialization for '__assertion.value') 744 | KUNIT_INIT_ASSERT(.text = #ptr, .value = __ptr), \ | ^~~~~ include/kunit/test.h:510:49: note: in definition of macro '_KUNIT_FAILED' 510 | const struct assert_class __assertion = INITIALIZER; \ | ^~~~~~~~~~~ include/kunit/test.h:744:23: note: in expansion of macro 'KUNIT_INIT_ASSERT' 744 | KUNIT_INIT_ASSERT(.text = #ptr, .value = __ptr), \ | ^~~~~~~~~~~~~~~~~ include/kunit/test.h:1418:9: note: in expansion of macro 'KUNIT_PTR_NOT_ERR_OR_NULL_MSG_ASSERTION' 1418 | KUNIT_PTR_NOT_ERR_OR_NULL_MSG_ASSERTION(test, \ | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/kunit/test.h:1415:9: note: in expansion of macro 'KUNIT_ASSERT_NOT_ERR_OR_NULL_MSG' 1415 | KUNIT_ASSERT_NOT_ERR_OR_NULL_MSG(test, ptr, NULL) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ lib/kunit/executor_test.c:59:9: note: in expansion of macro 'KUNIT_ASSERT_NOT_ERR_OR_NULL' 59 | KUNIT_ASSERT_NOT_ERR_OR_NULL(test, got.start[0]); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ lib/kunit/executor_test.c:46:26: warning: unused variable 'got' [-Wunused-variable] 46 | struct suite_set got; | ^~~ lib/kunit/executor_test.c:45:26: warning: unused variable 'suite_set' [-Wunused-variable] 45 | struct suite_set suite_set = {.start = subsuite, .end = &subsuite[2]}; | ^~~~~~~~~ lib/kunit/executor_test.c: In function 'filter_suites_test_glob_test': lib/kunit/executor_test.c:69:16: error: variable 'suite_set' has initializer but incomplete type 69 | struct suite_set suite_set = {.start = subsuite, .end = &subsuite[2]}; | ^~~~~~~~~ lib/kunit/executor_test.c:69:40: error: 'struct suite_set' has no member named 'start' 69 | struct suite_set suite_set = {.start = subsuite, .end = &subsuite[2]}; | ^~~~~ lib/kunit/executor_test.c:69:48: warning: excess elements in struct initializer 69 | struct suite_set suite_set = {.start = subsuite, .end = &subsuite[2]}; | ^~~~~~~~ lib/kunit/executor_test.c:69:48: note: (near initialization for 'suite_set') lib/kunit/executor_test.c:69:59: error: 'struct suite_set' has no member named 'end' 69 | struct suite_set suite_set = {.start = subsuite, .end = &subsuite[2]}; | ^~~ lib/kunit/executor_test.c:69:65: warning: excess elements in struct initializer 69 | struct suite_set suite_set = {.start = subsuite, .end = &subsuite[2]}; | ^ lib/kunit/executor_test.c:69:65: note: (near initialization for 'suite_set') lib/kunit/executor_test.c:69:26: error: storage size of 'suite_set' isn't known 69 | struct suite_set suite_set = {.start = subsuite, .end = &subsuite[2]}; | ^~~~~~~~~ lib/kunit/executor_test.c:70:26: error: storage size of 'got' isn't known 70 | struct suite_set got; | ^~~ >> include/kunit/test.h:737:29: warning: passing argument 1 of 'IS_ERR_OR_NULL' makes pointer from integer without a cast [-Wint-conversion] 737 | if (!IS_ERR_OR_NULL(__ptr)) \ | ^~~~~ | | | int include/kunit/test.h:1418:9: note: in expansion of macro 'KUNIT_PTR_NOT_ERR_OR_NULL_MSG_ASSERTION' 1418 | KUNIT_PTR_NOT_ERR_OR_NULL_MSG_ASSERTION(test, \ | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/kunit/test.h:1415:9: note: in expansion of macro 'KUNIT_ASSERT_NOT_ERR_OR_NULL_MSG' 1415 | KUNIT_ASSERT_NOT_ERR_OR_NULL_MSG(test, ptr, NULL) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ lib/kunit/executor_test.c:78:9: note: in expansion of macro 'KUNIT_ASSERT_NOT_ERR_OR_NULL' 78 | KUNIT_ASSERT_NOT_ERR_OR_NULL(test, got.start); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/err.h:70:68: note: expected 'const void *' but argument is of type 'int' 70 | static inline bool __must_check IS_ERR_OR_NULL(__force const void *ptr) | ~~~~~~~~~~~~^~~ >> include/kunit/test.h:744:64: warning: initialization of 'const void *' from 'int' makes pointer from integer without a cast [-Wint-conversion] 744 | KUNIT_INIT_ASSERT(.text = #ptr, .value = __ptr), \ | ^~~~~ include/kunit/test.h:510:49: note: in definition of macro '_KUNIT_FAILED' 510 | const struct assert_class __assertion = INITIALIZER; \ | ^~~~~~~~~~~ include/kunit/test.h:744:23: note: in expansion of macro 'KUNIT_INIT_ASSERT' 744 | KUNIT_INIT_ASSERT(.text = #ptr, .value = __ptr), \ | ^~~~~~~~~~~~~~~~~ include/kunit/test.h:1418:9: note: in expansion of macro 'KUNIT_PTR_NOT_ERR_OR_NULL_MSG_ASSERTION' 1418 | KUNIT_PTR_NOT_ERR_OR_NULL_MSG_ASSERTION(test, \ | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/kunit/test.h:1415:9: note: in expansion of macro 'KUNIT_ASSERT_NOT_ERR_OR_NULL_MSG' 1415 | KUNIT_ASSERT_NOT_ERR_OR_NULL_MSG(test, ptr, NULL) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ lib/kunit/executor_test.c:78:9: note: in expansion of macro 'KUNIT_ASSERT_NOT_ERR_OR_NULL' 78 | KUNIT_ASSERT_NOT_ERR_OR_NULL(test, got.start); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/kunit/test.h:744:64: note: (near initialization for '__assertion.value') 744 | KUNIT_INIT_ASSERT(.text = #ptr, .value = __ptr), \ | ^~~~~ include/kunit/test.h:510:49: note: in definition of macro '_KUNIT_FAILED' 510 | const struct assert_class __assertion = INITIALIZER; \ | ^~~~~~~~~~~ include/kunit/test.h:744:23: note: in expansion of macro 'KUNIT_INIT_ASSERT' 744 | KUNIT_INIT_ASSERT(.text = #ptr, .value = __ptr), \ | ^~~~~~~~~~~~~~~~~ include/kunit/test.h:1418:9: note: in expansion of macro 'KUNIT_PTR_NOT_ERR_OR_NULL_MSG_ASSERTION' 1418 | KUNIT_PTR_NOT_ERR_OR_NULL_MSG_ASSERTION(test, \ | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/kunit/test.h:1415:9: note: in expansion of macro 'KUNIT_ASSERT_NOT_ERR_OR_NULL_MSG' 1415 | KUNIT_ASSERT_NOT_ERR_OR_NULL_MSG(test, ptr, NULL) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ lib/kunit/executor_test.c:78:9: note: in expansion of macro 'KUNIT_ASSERT_NOT_ERR_OR_NULL' 78 | KUNIT_ASSERT_NOT_ERR_OR_NULL(test, got.start); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> include/kunit/test.h:737:29: warning: passing argument 1 of 'IS_ERR_OR_NULL' makes pointer from integer without a cast [-Wint-conversion] 737 | if (!IS_ERR_OR_NULL(__ptr)) \ | ^~~~~ | | | int include/kunit/test.h:1418:9: note: in expansion of macro 'KUNIT_PTR_NOT_ERR_OR_NULL_MSG_ASSERTION' 1418 | KUNIT_PTR_NOT_ERR_OR_NULL_MSG_ASSERTION(test, \ | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/kunit/test.h:1415:9: note: in expansion of macro 'KUNIT_ASSERT_NOT_ERR_OR_NULL_MSG' 1415 | KUNIT_ASSERT_NOT_ERR_OR_NULL_MSG(test, ptr, NULL) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ lib/kunit/executor_test.c:83:9: note: in expansion of macro 'KUNIT_ASSERT_NOT_ERR_OR_NULL' 83 | KUNIT_ASSERT_NOT_ERR_OR_NULL(test, got.start[0]); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/err.h:70:68: note: expected 'const void *' but argument is of type 'int' 70 | static inline bool __must_check IS_ERR_OR_NULL(__force const void *ptr) | ~~~~~~~~~~~~^~~ >> include/kunit/test.h:744:64: warning: initialization of 'const void *' from 'int' makes pointer from integer without a cast [-Wint-conversion] 744 | KUNIT_INIT_ASSERT(.text = #ptr, .value = __ptr), \ | ^~~~~ include/kunit/test.h:510:49: note: in definition of macro '_KUNIT_FAILED' 510 | const struct assert_class __assertion = INITIALIZER; \ | ^~~~~~~~~~~ include/kunit/test.h:744:23: note: in expansion of macro 'KUNIT_INIT_ASSERT' 744 | KUNIT_INIT_ASSERT(.text = #ptr, .value = __ptr), \ | ^~~~~~~~~~~~~~~~~ include/kunit/test.h:1418:9: note: in expansion of macro 'KUNIT_PTR_NOT_ERR_OR_NULL_MSG_ASSERTION' 1418 | KUNIT_PTR_NOT_ERR_OR_NULL_MSG_ASSERTION(test, \ | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/kunit/test.h:1415:9: note: in expansion of macro 'KUNIT_ASSERT_NOT_ERR_OR_NULL_MSG' 1415 | KUNIT_ASSERT_NOT_ERR_OR_NULL_MSG(test, ptr, NULL) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ lib/kunit/executor_test.c:83:9: note: in expansion of macro 'KUNIT_ASSERT_NOT_ERR_OR_NULL' 83 | KUNIT_ASSERT_NOT_ERR_OR_NULL(test, got.start[0]); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/kunit/test.h:744:64: note: (near initialization for '__assertion.value') 744 | KUNIT_INIT_ASSERT(.text = #ptr, .value = __ptr), \ | ^~~~~ include/kunit/test.h:510:49: note: in definition of macro '_KUNIT_FAILED' 510 | const struct assert_class __assertion = INITIALIZER; \ | ^~~~~~~~~~~ include/kunit/test.h:744:23: note: in expansion of macro 'KUNIT_INIT_ASSERT' 744 | KUNIT_INIT_ASSERT(.text = #ptr, .value = __ptr), \ | ^~~~~~~~~~~~~~~~~ include/kunit/test.h:1418:9: note: in expansion of macro 'KUNIT_PTR_NOT_ERR_OR_NULL_MSG_ASSERTION' 1418 | KUNIT_PTR_NOT_ERR_OR_NULL_MSG_ASSERTION(test, \ | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/kunit/test.h:1415:9: note: in expansion of macro 'KUNIT_ASSERT_NOT_ERR_OR_NULL_MSG' 1415 | KUNIT_ASSERT_NOT_ERR_OR_NULL_MSG(test, ptr, NULL) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ lib/kunit/executor_test.c:83:9: note: in expansion of macro 'KUNIT_ASSERT_NOT_ERR_OR_NULL' 83 | KUNIT_ASSERT_NOT_ERR_OR_NULL(test, got.start[0]); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> include/kunit/test.h:737:29: warning: passing argument 1 of 'IS_ERR_OR_NULL' makes pointer from integer without a cast [-Wint-conversion] 737 | if (!IS_ERR_OR_NULL(__ptr)) \ | ^~~~~ | | | int include/kunit/test.h:1418:9: note: in expansion of macro 'KUNIT_PTR_NOT_ERR_OR_NULL_MSG_ASSERTION' 1418 | KUNIT_PTR_NOT_ERR_OR_NULL_MSG_ASSERTION(test, \ | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/kunit/test.h:1415:9: note: in expansion of macro 'KUNIT_ASSERT_NOT_ERR_OR_NULL_MSG' 1415 | KUNIT_ASSERT_NOT_ERR_OR_NULL_MSG(test, ptr, NULL) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ lib/kunit/executor_test.c:88:9: note: in expansion of macro 'KUNIT_ASSERT_NOT_ERR_OR_NULL' 88 | KUNIT_ASSERT_NOT_ERR_OR_NULL(test, got.start[0]->test_cases); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/err.h:70:68: note: expected 'const void *' but argument is of type 'int' 70 | static inline bool __must_check IS_ERR_OR_NULL(__force const void *ptr) | ~~~~~~~~~~~~^~~ include/kunit/test.h:744:64: warning: initialization of 'const void *' from 'int' makes pointer from integer without a cast [-Wint-conversion] 744 | KUNIT_INIT_ASSERT(.text = #ptr, .value = __ptr), \ | ^~~~~ include/kunit/test.h:510:49: note: in definition of macro '_KUNIT_FAILED' 510 | const struct assert_class __assertion = INITIALIZER; \ | ^~~~~~~~~~~ include/kunit/test.h:744:23: note: in expansion of macro 'KUNIT_INIT_ASSERT' 744 | KUNIT_INIT_ASSERT(.text = #ptr, .value = __ptr), \ | ^~~~~~~~~~~~~~~~~ include/kunit/test.h:1418:9: note: in expansion of macro 'KUNIT_PTR_NOT_ERR_OR_NULL_MSG_ASSERTION' 1418 | KUNIT_PTR_NOT_ERR_OR_NULL_MSG_ASSERTION(test, \ | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/kunit/test.h:1415:9: note: in expansion of macro 'KUNIT_ASSERT_NOT_ERR_OR_NULL_MSG' 1415 | KUNIT_ASSERT_NOT_ERR_OR_NULL_MSG(test, ptr, NULL) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ lib/kunit/executor_test.c:88:9: note: in expansion of macro 'KUNIT_ASSERT_NOT_ERR_OR_NULL' 88 | KUNIT_ASSERT_NOT_ERR_OR_NULL(test, got.start[0]->test_cases); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/kunit/test.h:744:64: note: (near initialization for '__assertion.value') 744 | KUNIT_INIT_ASSERT(.text = #ptr, .value = __ptr), \ | ^~~~~ include/kunit/test.h:510:49: note: in definition of macro '_KUNIT_FAILED' 510 | const struct assert_class __assertion = INITIALIZER; \ | ^~~~~~~~~~~ include/kunit/test.h:744:23: note: in expansion of macro 'KUNIT_INIT_ASSERT' 744 | KUNIT_INIT_ASSERT(.text = #ptr, .value = __ptr), \ | ^~~~~~~~~~~~~~~~~ include/kunit/test.h:1418:9: note: in expansion of macro 'KUNIT_PTR_NOT_ERR_OR_NULL_MSG_ASSERTION' 1418 | KUNIT_PTR_NOT_ERR_OR_NULL_MSG_ASSERTION(test, \ | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/kunit/test.h:1415:9: note: in expansion of macro 'KUNIT_ASSERT_NOT_ERR_OR_NULL_MSG' 1415 | KUNIT_ASSERT_NOT_ERR_OR_NULL_MSG(test, ptr, NULL) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ lib/kunit/executor_test.c:88:9: note: in expansion of macro 'KUNIT_ASSERT_NOT_ERR_OR_NULL' 88 | KUNIT_ASSERT_NOT_ERR_OR_NULL(test, got.start[0]->test_cases); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ lib/kunit/executor_test.c:70:26: warning: unused variable 'got' [-Wunused-variable] 70 | struct suite_set got; | ^~~ lib/kunit/executor_test.c:69:26: warning: unused variable 'suite_set' [-Wunused-variable] 69 | struct suite_set suite_set = {.start = subsuite, .end = &subsuite[2]}; | ^~~~~~~~~ lib/kunit/executor_test.c: In function 'filter_suites_to_empty_test': lib/kunit/executor_test.c:96:16: error: variable 'suite_set' has initializer but incomplete type 96 | struct suite_set suite_set = {.start = subsuite, .end = &subsuite[2]}; | ^~~~~~~~~ lib/kunit/executor_test.c:96:40: error: 'struct suite_set' has no member named 'start' 96 | struct suite_set suite_set = {.start = subsuite, .end = &subsuite[2]}; | ^~~~~ lib/kunit/executor_test.c:96:48: warning: excess elements in struct initializer 96 | struct suite_set suite_set = {.start = subsuite, .end = &subsuite[2]}; | ^~~~~~~~ lib/kunit/executor_test.c:96:48: note: (near initialization for 'suite_set') lib/kunit/executor_test.c:96:59: error: 'struct suite_set' has no member named 'end' 96 | struct suite_set suite_set = {.start = subsuite, .end = &subsuite[2]}; | ^~~ lib/kunit/executor_test.c:96:65: warning: excess elements in struct initializer 96 | struct suite_set suite_set = {.start = subsuite, .end = &subsuite[2]}; | ^ lib/kunit/executor_test.c:96:65: note: (near initialization for 'suite_set') lib/kunit/executor_test.c:96:26: error: storage size of 'suite_set' isn't known 96 | struct suite_set suite_set = {.start = subsuite, .end = &subsuite[2]}; | ^~~~~~~~~ lib/kunit/executor_test.c:97:26: error: storage size of 'got' isn't known 97 | struct suite_set got; | ^~~ include/kunit/test.h:628:55: warning: initialization of 'const void *' from 'int' makes pointer from integer without a cast [-Wint-conversion] 628 | .left_value = __left, \ | ^~~~~~ include/kunit/test.h:510:49: note: in definition of macro '_KUNIT_FAILED' 510 | const struct assert_class __assertion = INITIALIZER; \ | ^~~~~~~~~~~ include/kunit/test.h:627:23: note: in expansion of macro 'KUNIT_INIT_ASSERT' 627 | KUNIT_INIT_ASSERT(.text = &__text, \ | ^~~~~~~~~~~~~~~~~ include/kunit/test.h:656:9: note: in expansion of macro 'KUNIT_BASE_BINARY_ASSERTION' 656 | KUNIT_BASE_BINARY_ASSERTION(test, \ | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ include/kunit/test.h:825:9: note: in expansion of macro 'KUNIT_BINARY_PTR_ASSERTION' 825 | KUNIT_BINARY_PTR_ASSERTION(test, \ | ^~~~~~~~~~~~~~~~~~~~~~~~~~ lib/kunit/executor_test.c:107:9: note: in expansion of macro 'KUNIT_EXPECT_PTR_EQ_MSG' 107 | KUNIT_EXPECT_PTR_EQ_MSG(test, got.start, got.end, | ^~~~~~~~~~~~~~~~~~~~~~~ vim +190 lib/kunit/executor.c 9c6b0e1d8993e4 Daniel Latypov 2021-09-30 181 9c6b0e1d8993e4 Daniel Latypov 2021-09-30 @182 static void kunit_exec_list_tests(struct suite_set *suite_set) aac35468ca20a3 Alan Maguire 2020-08-04 183 { e5857d396f35e5 Daniel Latypov 2022-07-09 184 struct kunit_suite * const *suites; 9c6b0e1d8993e4 Daniel Latypov 2021-09-30 185 struct kunit_case *test_case; 9c6b0e1d8993e4 Daniel Latypov 2021-09-30 186 6c738b52316c58 Rae Moar 2022-11-23 187 /* Hack: print a ktap header so kunit.py can find the start of KUnit output. */ 6c738b52316c58 Rae Moar 2022-11-23 188 pr_info("KTAP version 1\n"); 9c6b0e1d8993e4 Daniel Latypov 2021-09-30 189 9c6b0e1d8993e4 Daniel Latypov 2021-09-30 @190 for (suites = suite_set->start; suites < suite_set->end; suites++) e5857d396f35e5 Daniel Latypov 2022-07-09 191 kunit_suite_for_each_test_case((*suites), test_case) { e5857d396f35e5 Daniel Latypov 2022-07-09 192 pr_info("%s.%s\n", (*suites)->name, test_case->name); 9c6b0e1d8993e4 Daniel Latypov 2021-09-30 193 } 9c6b0e1d8993e4 Daniel Latypov 2021-09-30 194 } 9c6b0e1d8993e4 Daniel Latypov 2021-09-30 195 9c6b0e1d8993e4 Daniel Latypov 2021-09-30 196 int kunit_run_all_tests(void) 9c6b0e1d8993e4 Daniel Latypov 2021-09-30 197 { e5857d396f35e5 Daniel Latypov 2022-07-09 @198 struct suite_set suite_set = {__kunit_suites_start, __kunit_suites_end}; 1b11063d32d7e1 Daniel Latypov 2022-05-13 199 int err = 0; d20a6ba5e3be5f Joe Fradley 2022-08-23 200 if (!kunit_enabled()) { d20a6ba5e3be5f Joe Fradley 2022-08-23 201 pr_info("kunit: disabled\n"); d20a6ba5e3be5f Joe Fradley 2022-08-23 202 goto out; d20a6ba5e3be5f Joe Fradley 2022-08-23 203 } aac35468ca20a3 Alan Maguire 2020-08-04 204 a02353f491622e Daniel Latypov 2022-05-11 205 if (filter_glob_param) { a02353f491622e Daniel Latypov 2022-05-11 206 suite_set = kunit_filter_suites(&suite_set, filter_glob_param, &err); a02353f491622e Daniel Latypov 2022-05-11 207 if (err) { a02353f491622e Daniel Latypov 2022-05-11 208 pr_err("kunit executor: error filtering suites: %d\n", err); 1b11063d32d7e1 Daniel Latypov 2022-05-13 209 goto out; a02353f491622e Daniel Latypov 2022-05-11 210 } a02353f491622e Daniel Latypov 2022-05-11 211 } 45dcbb6f5ef78b Brendan Higgins 2020-08-04 212 9c6b0e1d8993e4 Daniel Latypov 2021-09-30 213 if (!action_param) 9c6b0e1d8993e4 Daniel Latypov 2021-09-30 214 kunit_exec_run_tests(&suite_set); 9c6b0e1d8993e4 Daniel Latypov 2021-09-30 215 else if (strcmp(action_param, "list") == 0) 9c6b0e1d8993e4 Daniel Latypov 2021-09-30 216 kunit_exec_list_tests(&suite_set); 9c6b0e1d8993e4 Daniel Latypov 2021-09-30 217 else 9c6b0e1d8993e4 Daniel Latypov 2021-09-30 218 pr_err("kunit executor: unknown action '%s'\n", action_param); aac35468ca20a3 Alan Maguire 2020-08-04 219 e5857d396f35e5 Daniel Latypov 2022-07-09 220 if (filter_glob_param) { /* a copy was made of each suite */ a127b154a8f231 Daniel Latypov 2021-09-14 221 kunit_free_suite_set(suite_set); 5d31f71efcb6bc Daniel Latypov 2021-02-05 222 } 5d31f71efcb6bc Daniel Latypov 2021-02-05 223 1b11063d32d7e1 Daniel Latypov 2022-05-13 224 out: 1b11063d32d7e1 Daniel Latypov 2022-05-13 225 kunit_handle_shutdown(); 1b11063d32d7e1 Daniel Latypov 2022-05-13 226 return err; aac35468ca20a3 Alan Maguire 2020-08-04 227 } aac35468ca20a3 Alan Maguire 2020-08-04 228 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki