Received: by 2002:a05:6358:c692:b0:131:369:b2a3 with SMTP id fe18csp1573668rwb; Fri, 28 Jul 2023 11:22:01 -0700 (PDT) X-Google-Smtp-Source: APBJJlH226c16nHoSDEuF0J9Ave73WKcmeGgjeN5mc3bpQSHPH6XA9tN3KT5sowKHkCPmcSAWNBS X-Received: by 2002:a17:906:518e:b0:993:f9d4:eaac with SMTP id y14-20020a170906518e00b00993f9d4eaacmr125810ejk.24.1690568521545; Fri, 28 Jul 2023 11:22:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690568521; cv=none; d=google.com; s=arc-20160816; b=iR5LEva/VNYjgZGahTYN2K4/mvxOplLxu45qFQ8CHm3UfHhIpU/wyu2pJ5smD6Iv98 ww32+Mg1gzB1KUHyuVot/ElJVg/PkRH1m72E+Q++Ntkg2a4CORqR+sJ8PajxfXvgC4dl WFNKA4AyQC4FqEkapCnaXVppH9MsxgIIU6rnh9WpFLmDUGJt++7mZPRXw4+ZRhWydFsR LUD5UeFjggA2KFPzgFRE2zaIWmXtd2nCS+Rdev8wW9bHJ3RjHl7iS86E1bqWNG/35qJk M83VlZ1R0SKaXiqiFwWUcCkL1YCy6R1Dw4NFYPfcXIjevGotHprohEIcHmvtJQf0AaM/ vULg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:autocrypt :from:references:cc:to:content-language:subject:user-agent :mime-version:date:message-id:dkim-signature; bh=Y0KWziT1mxdmTj7u48lfqOSCiVjBr+WD1yIdlFS/Mwc=; fh=nxTtIXp+YeUW0dy9b6eCXd9HvCzACw07E51P+fRCTrE=; b=YsbZFH5vrCTol3bmUGMXAOaBIWOphUsOD+GQ7Ebh+BAFtJV2lC6WoByfms12qAhJZ0 B7z2/FC88quJOQy/RanVQnY2vnXeBeYilnT/kFcZNHVZPPAapgFKu/Unee2AcMGuJDUE DsrgbExqLDMZTfc1QAW6KzO8/8TxYevPhmdyZSJGbbPQAoCOQMP4sZsnpLGizCjYDD2V J9tWP82mtr1VPjdKR4sgsVAc3Zz/BSp+QDheippLnmXK9vk7swyZnZKg+VL7HD3CYMG4 0nmmW645WO7ZJJNm++i3b2KPYDZyJ4cgGD2RVEhmeJoNAmJF/B+sctee4JQTfWBmRKKw TZ3Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=x8guTRcR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q22-20020a17090622d600b0099bbcfbd199si48526eja.988.2023.07.28.11.21.37; Fri, 28 Jul 2023 11:22:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=x8guTRcR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232634AbjG1Rbo (ORCPT + 99 others); Fri, 28 Jul 2023 13:31:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57176 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229720AbjG1Rbd (ORCPT ); Fri, 28 Jul 2023 13:31:33 -0400 Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [IPv6:2a00:1450:4864:20::232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F2CB04682 for ; Fri, 28 Jul 2023 10:31:05 -0700 (PDT) Received: by mail-lj1-x232.google.com with SMTP id 38308e7fff4ca-2b6f97c7115so38469891fa.2 for ; Fri, 28 Jul 2023 10:31:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1690565459; x=1691170259; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Y0KWziT1mxdmTj7u48lfqOSCiVjBr+WD1yIdlFS/Mwc=; b=x8guTRcRIw9KKkzFxIpzfV3dkfInedxmUv4ClFVbFFf/94ioI7vTIcMLq/aplaaEF4 z2JXqZerlGswc3R/Ms3G6VCOi4aRYmOgryymZ6BJ0TGxzDgLkHcbJH83jgdE/H08XcgW +Rn8KhsBvTz8pbvjCEfvDcJRZNBYCnlXca5HACQnUTXzDdS6Mhm7qWmP4o3pF86wx8iw RFJX4vzHKtL99Y/A2u9Uoy4OCelU+OOOD4kFZqsb2Ik8zKx4ATIOrI409U06GtLTrvk/ ohiTwBfuQhxgEiZ6UzBrHXjOV3SlCa1vD/Mh6eND/LvN/rA+cel78qXMXzL3AHDIhsxe Bh3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690565459; x=1691170259; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Y0KWziT1mxdmTj7u48lfqOSCiVjBr+WD1yIdlFS/Mwc=; b=MucvdRRKWPlkYeT6UEqD0MS/FGHqx4F1jEz7CSMNdanu++J1xPABz4eN0AYfs2lCTm SO8s1rWjFarRLqGHIHq1Z2hrxHaIHZceC3ja1Y9tUbEU2gr1wLD0GijqLii+ZZYbONJL CXcHSv/nlW0vvOyb9NrvhE4wPOGFFU6uZcmi3E2IUhOHBrbflujr6D85IlmWUX9yw2JM rF6uQkLRVrTyYmYar05ErWlzH871aamvMoLyeB8neTybzUM+vp2MLohmcEdG3UiJ6uSG WGBGBF0YikNdTWKyxJ2q6sBv665OAnhAt8jfg6IDIVZouQd8/QwyqBh1LA40GgA5s3iT guOg== X-Gm-Message-State: ABy/qLbrHuRyz5BvE+1iNbmhIvF26+w6WrwspTo0219MdzQupsq87lUz JTbTuwaxkdCSyRhz5ZDcZEJHtw== X-Received: by 2002:a2e:9e89:0:b0:2b6:d5af:1160 with SMTP id f9-20020a2e9e89000000b002b6d5af1160mr2249527ljk.28.1690565459316; Fri, 28 Jul 2023 10:30:59 -0700 (PDT) Received: from [192.168.1.101] (abyk53.neoplus.adsl.tpnet.pl. [83.9.30.53]) by smtp.gmail.com with ESMTPSA id u22-20020a2ea176000000b002b6efce3f54sm1051032ljl.123.2023.07.28.10.30.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Jul 2023 10:30:58 -0700 (PDT) Message-ID: Date: Fri, 28 Jul 2023 19:30:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 12/33] iris: vidc: add helper functions for resource management Content-Language: en-US To: Vikash Garodia , stanimir.k.varbanov@gmail.com, agross@kernel.org, andersson@kernel.org, mchehab@kernel.org, hans.verkuil@cisco.com, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org Cc: quic_dikshita@quicinc.com References: <1690550624-14642-1-git-send-email-quic_vgarodia@quicinc.com> <1690550624-14642-13-git-send-email-quic_vgarodia@quicinc.com> From: Konrad Dybcio Autocrypt: addr=konrad.dybcio@linaro.org; keydata= xsFNBF9ALYUBEADWAhxdTBWrwAgDQQzc1O/bJ5O7b6cXYxwbBd9xKP7MICh5YA0DcCjJSOum BB/OmIWU6X+LZW6P88ZmHe+KeyABLMP5s1tJNK1j4ntT7mECcWZDzafPWF4F6m4WJOG27kTJ HGWdmtO+RvadOVi6CoUDqALsmfS3MUG5Pj2Ne9+0jRg4hEnB92AyF9rW2G3qisFcwPgvatt7 TXD5E38mLyOPOUyXNj9XpDbt1hNwKQfiidmPh5e7VNAWRnW1iCMMoKqzM1Anzq7e5Afyeifz zRcQPLaqrPjnKqZGL2BKQSZDh6NkI5ZLRhhHQf61fkWcUpTp1oDC6jWVfT7hwRVIQLrrNj9G MpPzrlN4YuAqKeIer1FMt8cq64ifgTzxHzXsMcUdclzq2LTk2RXaPl6Jg/IXWqUClJHbamSk t1bfif3SnmhA6TiNvEpDKPiT3IDs42THU6ygslrBxyROQPWLI9IL1y8S6RtEh8H+NZQWZNzm UQ3imZirlPjxZtvz1BtnnBWS06e7x/UEAguj7VHCuymVgpl2Za17d1jj81YN5Rp5L9GXxkV1 aUEwONM3eCI3qcYm5JNc5X+JthZOWsbIPSC1Rhxz3JmWIwP1udr5E3oNRe9u2LIEq+wH/toH kpPDhTeMkvt4KfE5m5ercid9+ZXAqoaYLUL4HCEw+HW0DXcKDwARAQABzShLb25yYWQgRHli Y2lvIDxrb25yYWQuZHliY2lvQGxpbmFyby5vcmc+wsGOBBMBCAA4FiEEU24if9oCL2zdAAQV R4cBcg5dfFgFAmQ5bqwCGwMFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQR4cBcg5dfFjO BQ//YQV6fkbqQCceYebGg6TiisWCy8LG77zV7DB0VMIWJv7Km7Sz0QQrHQVzhEr3trNenZrf yy+o2tQOF2biICzbLM8oyQPY8B///KJTWI2khoB8IJSJq3kNG68NjPg2vkP6CMltC/X3ohAo xL2UgwN5vj74QnlNneOjc0vGbtA7zURNhTz5P/YuTudCqcAbxJkbqZM4WymjQhe0XgwHLkiH 5LHSZ31MRKp/+4Kqs4DTXMctc7vFhtUdmatAExDKw8oEz5NbskKbW+qHjW1XUcUIrxRr667V GWH6MkVceT9ZBrtLoSzMLYaQXvi3sSAup0qiJiBYszc/VOu3RbIpNLRcXN3KYuxdQAptacTE mA+5+4Y4DfC3rUSun+hWLDeac9z9jjHm5rE998OqZnOU9aztbd6zQG5VL6EKgsVXAZD4D3RP x1NaAjdA3MD06eyvbOWiA5NSzIcC8UIQvgx09xm7dThCuQYJR4Yxjd+9JPJHI6apzNZpDGvQ BBZzvwxV6L1CojUEpnilmMG1ZOTstktWpNzw3G2Gis0XihDUef0MWVsQYJAl0wfiv/0By+XK mm2zRR+l/dnzxnlbgJ5pO0imC2w0TVxLkAp0eo0LHw619finad2u6UPQAkZ4oj++iIGrJkt5 Lkn2XgB+IW8ESflz6nDY3b5KQRF8Z6XLP0+IEdLOOARkOW7yEgorBgEEAZdVAQUBAQdAwmUx xrbSCx2ksDxz7rFFGX1KmTkdRtcgC6F3NfuNYkYDAQgHwsF2BBgBCAAgFiEEU24if9oCL2zd AAQVR4cBcg5dfFgFAmQ5bvICGwwACgkQR4cBcg5dfFju1Q//Xta1ShwL0MLSC1KL1lXGXeRM 8arzfyiB5wJ9tb9U/nZvhhdfilEDLe0jKJY0RJErbdRHsalwQCrtq/1ewQpMpsRxXzAjgfRN jc4tgxRWmI+aVTzSRpywNahzZBT695hMz81cVZJoZzaV0KaMTlSnBkrviPz1nIGHYCHJxF9r cIu0GSIyUjZ/7xslxdvjpLth16H27JCWDzDqIQMtg61063gNyEyWgt1qRSaK14JIH/DoYRfn jfFQSC8bffFjat7BQGFz4ZpRavkMUFuDirn5Tf28oc5ebe2cIHp4/kajTx/7JOxWZ80U70mA cBgEeYSrYYnX+UJsSxpzLc/0sT1eRJDEhI4XIQM4ClIzpsCIN5HnVF76UQXh3a9zpwh3dk8i bhN/URmCOTH+LHNJYN/MxY8wuukq877DWB7k86pBs5IDLAXmW8v3gIDWyIcgYqb2v8QO2Mqx YMqL7UZxVLul4/JbllsQB8F/fNI8AfttmAQL9cwo6C8yDTXKdho920W4WUR9k8NT/OBqWSyk bGqMHex48FVZhexNPYOd58EY9/7mL5u0sJmo+jTeb4JBgIbFPJCFyng4HwbniWgQJZ1WqaUC nas9J77uICis2WH7N8Bs9jy0wQYezNzqS+FxoNXmDQg2jetX8en4bO2Di7Pmx0jXA4TOb9TM izWDgYvmBE8= In-Reply-To: <1690550624-14642-13-git-send-email-quic_vgarodia@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28.07.2023 15:23, Vikash Garodia wrote: > From: Dikshita Agarwal > > This implements ops to initialize, enable and disable extrenal > resources needed by video driver like power domains, clocks etc. > > Signed-off-by: Dikshita Agarwal > Signed-off-by: Vikash Garodia > --- There's a whole bunch of kerneldoc abuses (comments should start with /* and not /**). Make sure you have proper spaces between single-line C-style comments (e.g. /*Get should be /* Get etc.) Capitalizing the first word within the comment would be nice too. Do we need a separate bus table? i.e. does it make sense to adjust the bandwidth values separately from the clock rates? Do you think there will be more than one set of msm_vidc_resources_ops? Perhaps it'd make sense to drop that layer of abstraction if not. Many function names could drop the __ prefix. A whole bunch of d_vpr_h seem almost excessive. MSM_VIDC_CLKFLAG_* are unused. Konrad