Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e6d7a9ab-ca03-57dc-b023-fa2cbf35fd65@linuxfoundation.org>
Date:   Fri, 28 Jul 2023 11:33:54 -0600
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: selftests: connector: proc_filter.c:48:20: error: invalid
 application of 'sizeof' to an incomplete type 'struct proc_input'
Content-Language: en-US
To:     Anjali Kulkarni <anjali.k.kulkarni@oracle.com>,
        Jakub Kicinski <kuba@kernel.org>
Cc:     Naresh Kamboju <naresh.kamboju@linaro.org>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>,
        "lkft-triage@lists.linaro.org" <lkft-triage@lists.linaro.org>,
        Netdev <netdev@vger.kernel.org>,
        clang-built-linux <llvm@lists.linux.dev>,
        Shuah Khan <shuah@kernel.org>,
        Anders Roxell <anders.roxell@linaro.org>,
        "David S. Miller" <davem@davemloft.net>,
        Liam Howlett <liam.howlett@oracle.com>,
        Shuah Khan <skhan@linuxfoundation.org>
References: <CA+G9fYt=6ysz636XcQ=-KJp7vJcMZ=NjbQBrn77v7vnTcfP2cA@mail.gmail.com>
 <E8C72537-4280-401A-B25D-9734D2756A6A@oracle.com>
 <BB43F17E-EC00-4E72-BB3D-F4E6FA65F954@oracle.com>
 <799d6088-e28f-f386-6a00-2291304171a2@linuxfoundation.org>
 <DD53AFBE-F948-40F9-A980-2DA155236237@oracle.com>
From:   Shuah Khan <skhan@linuxfoundation.org>
In-Reply-To: <DD53AFBE-F948-40F9-A980-2DA155236237@oracle.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 7/27/23 19:38, Anjali Kulkarni wrote:
> 
> 
>> On Jul 27, 2023, at 5:43 PM, Shuah Khan <skhan@linuxfoundation.org> wrote:
>>
>> On 7/27/23 11:34, Anjali Kulkarni wrote:
>>>> On Jul 25, 2023, at 9:48 AM, Anjali Kulkarni <Anjali.K.Kulkarni@oracle.com> wrote:
>>>>
>>>>
>>>>
>>>>> On Jul 25, 2023, at 6:05 AM, Naresh Kamboju <naresh.kamboju@linaro.org> wrote:
>>>>>
>>>>> selftests: connector: proc_filter build failed with clang-16 due to below
>>>>> warnings / errors on Linux next-20230725.
>>>>>
>>>>> Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
>>>>>
>>>>> clang --target=aarch64-linux-gnu -fintegrated-as
>>>>> -Werror=unknown-warning-option -Werror=ignored-optimization-argument
>>>>> -Werror=option-ignored -Werror=unused-command-line-argument
>>>>> --target=aarch64-linux-gnu -fintegrated-as -Wall proc_filter.c -o
>>>>> /home/tuxbuild/.cache/tuxmake/builds/1/build/kselftest/connector/proc_filter
>>>>> proc_filter.c:42:12: error: invalid application of 'sizeof' to an
>>>>> incomplete type 'struct proc_input'
>>>>> char buff[NL_MESSAGE_SIZE];
>>>>> ^~~~~~~~~~~~~~~
>>>>> proc_filter.c:22:5: note: expanded from macro 'NL_MESSAGE_SIZE'
>>>>> sizeof(struct proc_input))
>>>>> ^ ~~~~~~~~~~~~~~~~~~~
>>>>> proc_filter.c:42:12: note: forward declaration of 'struct proc_input'
>>>>> proc_filter.c:22:19: note: expanded from macro 'NL_MESSAGE_SIZE'
>>>>> sizeof(struct proc_input))
>>>>> ^
>>>>> proc_filter.c:48:20: error: invalid application of 'sizeof' to an
>>>>> incomplete type 'struct proc_input'
>>>>> hdr->nlmsg_len = NL_MESSAGE_SIZE;
>>>>> ^~~~~~~~~~~~~~~
>>>>> proc_filter.c:22:5: note: expanded from macro 'NL_MESSAGE_SIZE'
>>>>> sizeof(struct proc_input))
>>>>> ^ ~~~~~~~~~~~~~~~~~~~
>>>>> proc_filter.c:42:12: note: forward declaration of 'struct proc_input'
>>>>> char buff[NL_MESSAGE_SIZE];
>>>>> ^
>>>>> proc_filter.c:22:19: note: expanded from macro 'NL_MESSAGE_SIZE'
>>>>> sizeof(struct proc_input))
>>>>> ^
>>>>> proc_filter.c:64:14: error: invalid application of 'sizeof' to an
>>>>> incomplete type 'struct proc_input'
>>>>> msg->len = sizeof(struct proc_input);
>>>>> ^ ~~~~~~~~~~~~~~~~~~~
>>>>> proc_filter.c:42:12: note: forward declaration of 'struct proc_input'
>>>>> char buff[NL_MESSAGE_SIZE];
>>>>> ^
>>>>> proc_filter.c:22:19: note: expanded from macro 'NL_MESSAGE_SIZE'
>>>>> sizeof(struct proc_input))
>>>>> ^
>>>>> proc_filter.c:65:35: error: incomplete definition of type 'struct proc_input'
>>>>> ((struct proc_input *)msg->data)->mcast_op =
>>>>> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
>>>>> proc_filter.c:42:12: note: forward declaration of 'struct proc_input'
>>>>> char buff[NL_MESSAGE_SIZE];
>>>>> ^
>>>>> proc_filter.c:22:19: note: expanded from macro 'NL_MESSAGE_SIZE'
>>>>> sizeof(struct proc_input))
>>>>> ^
>>>>> proc_filter.c:66:31: error: incomplete definition of type 'struct proc_input'
>>>>> ((struct proc_input *)pinp)->mcast_op;
>>>>> ~~~~~~~~~~~~~~~~~~~~~~~~~~~^
>>>>> proc_filter.c:42:12: note: forward declaration of 'struct proc_input'
>>>>> char buff[NL_MESSAGE_SIZE];
>>>>> ^
>>>>> proc_filter.c:22:19: note: expanded from macro 'NL_MESSAGE_SIZE'
>>>>> sizeof(struct proc_input))
>>>>> ^
>>>>> proc_filter.c:67:35: error: incomplete definition of type 'struct proc_input'
>>>>> ((struct proc_input *)msg->data)->event_type =
>>>>> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
>>>>> proc_filter.c:42:12: note: forward declaration of 'struct proc_input'
>>>>> char buff[NL_MESSAGE_SIZE];
>>>>> ^
>>>>> proc_filter.c:22:19: note: expanded from macro 'NL_MESSAGE_SIZE'
>>>>> sizeof(struct proc_input))
>>>>> ^
>>>>> proc_filter.c:68:31: error: incomplete definition of type 'struct proc_input'
>>>>> ((struct proc_input *)pinp)->event_type;
>>>>> ~~~~~~~~~~~~~~~~~~~~~~~~~~~^
>>>>> proc_filter.c:42:12: note: forward declaration of 'struct proc_input'
>>>>> char buff[NL_MESSAGE_SIZE];
>>>>> ^
>>>>> proc_filter.c:22:19: note: expanded from macro 'NL_MESSAGE_SIZE'
>>>>> sizeof(struct proc_input))
>>>>> ^
>>>>> proc_filter.c:245:20: error: variable has incomplete type 'struct proc_input'
>>>>> struct proc_input input;
>>>>> ^
>>>>> proc_filter.c:245:9: note: forward declaration of 'struct proc_input'
>>>>> struct proc_input input;
>>>>> ^
>>>>> proc_filter.c:264:22: error: use of undeclared identifier
>>>>> 'PROC_EVENT_NONZERO_EXIT'
>>>>> input.event_type = PROC_EVENT_NONZERO_EXIT;
>>>>> ^
>>>>> 9 errors generated.
>>>>> make[4]: Leaving directory '/builds/linux/tools/testing/selftests/connector’
>>>>>
>>>>>
>>>> These are expected since you need to have the changes in kernel that were committed with this patch to be installed on the kernel on which this is being compiled/run on. That is what the test is for, and the check to make it run on previous kernels as well was made a runtime check. Do you expect this to compile on a kernel without the corresponding kernel changes that were committed with this patch?
>>>>
>>>> Anjali
>>> Gentle ping - could you answer above questions?
>>>>
>>
>> I am seeing the same on linux-next next-20230727
>>
>> PROC_EVENT_NONZERO_EXIT is defined and NL_MESSAGE_SIZE
>>
>> Anjali,
>>
>> What are the dependent commits and should they be in next?
>> Shouldn't this test patch go with the kernel patches it depends
>> on? Can you do some testing on next and let me know why this
>> test is failing to build?
> 
> All the commits went in together - however, the kernel changes that went in this patch need to be *installed on kernel on which this is being built*. Did you do that and then try?
> 

Building kernel and running "make headers" before building the test
is what is needed. That is what Naresh and I did.

How are you building this test?

I sent a 3 patch series with the fix to this problem and a couple of
others I found during testing.

Also please check the error messages - some of them are cryptic and
could use clarity.

Another thing is argument check - arg == 2 - does this test require
arguments? Note that without arguments the test runs - of that is
default it is fine. This test could use an usage information. Please
fix the above.

thanks,
-- Shuah