Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b247219c-f988-bcc2-36f5-22659e2ced96@linuxfoundation.org>
Date:   Fri, 28 Jul 2023 11:34:17 -0600
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: selftests: connector: proc_filter.c:48:20: error: invalid
 application of 'sizeof' to an incomplete type 'struct proc_input'
Content-Language: en-US
To:     Anjali Kulkarni <anjali.k.kulkarni@oracle.com>,
        Jakub Kicinski <kuba@kernel.org>
Cc:     Naresh Kamboju <naresh.kamboju@linaro.org>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>,
        "lkft-triage@lists.linaro.org" <lkft-triage@lists.linaro.org>,
        Netdev <netdev@vger.kernel.org>,
        clang-built-linux <llvm@lists.linux.dev>,
        Shuah Khan <shuah@kernel.org>,
        Anders Roxell <anders.roxell@linaro.org>,
        "David S. Miller" <davem@davemloft.net>,
        Liam Howlett <liam.howlett@oracle.com>,
        Shuah Khan <skhan@linuxfoundation.org>
References: <CA+G9fYt=6ysz636XcQ=-KJp7vJcMZ=NjbQBrn77v7vnTcfP2cA@mail.gmail.com>
 <E8C72537-4280-401A-B25D-9734D2756A6A@oracle.com>
 <BB43F17E-EC00-4E72-BB3D-F4E6FA65F954@oracle.com>
 <799d6088-e28f-f386-6a00-2291304171a2@linuxfoundation.org>
 <DD53AFBE-F948-40F9-A980-2DA155236237@oracle.com>
 <20230727194311.6a51f285@kernel.org>
 <5844361F-E776-4C52-BA8F-7E13D6B4EDE1@oracle.com>
From:   Shuah Khan <skhan@linuxfoundation.org>
In-Reply-To: <5844361F-E776-4C52-BA8F-7E13D6B4EDE1@oracle.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 7/28/23 10:46, Anjali Kulkarni wrote:
> 
> 
>> On Jul 27, 2023, at 7:43 PM, Jakub Kicinski <kuba@kernel.org> wrote:
>>
>> On Fri, 28 Jul 2023 01:38:40 +0000 Anjali Kulkarni wrote:
>>> Jakub,
>>> Do I need to revert the -f runtime filter option back to compile time
>>> and commit with that disabled so the selftest compiles on a kernel on
>>> which the new options are not defined?
>>
>> I'm not 100% sure myself on what's the expectations for building
>> selftests against uAPI headers is..
>>
>> I _think_ that you're supposed to add an -I$something to
>> the CFLAGS in your Makefile. KHDR_INCLUDES maybe? So that the uAPI
>> headers from the build get used (rendered by make headers).
>>
>> Take a look at Documentation/dev-tools/kselftest.rst, I hope
>> the answer is somewhere there.
> Ok thanks, I will look into your suggestions.
> Anjali
> 

I sent a 3 patch series with the fix to this problem and a couple of
others I found during testing.

thanks,
-- Shuah