Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Anjali Kulkarni <anjali.k.kulkarni@oracle.com>
To:     Shuah Khan <skhan@linuxfoundation.org>
CC:     Shuah Khan <shuah@kernel.org>,
        Liam Howlett <liam.howlett@oracle.com>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH next 3/3] selftests:connector: Add root check and fix arg
 error paths to skip
Thread-Topic: [PATCH next 3/3] selftests:connector: Add root check and fix arg
 error paths to skip
Thread-Index: AQHZwXkWbDEKB7ogokq33I6v8z/kP6/PesIA
Date:   Fri, 28 Jul 2023 18:10:57 +0000
Message-ID: <0CB227BA-69FD-447F-BE73-2482A6998F7E@oracle.com>
References: <cover.1690564372.git.skhan@linuxfoundation.org>
 <2c0ac97f9c8e6bd46b60854c136099c0dd4a09f6.1690564372.git.skhan@linuxfoundation.org>
In-Reply-To: <2c0ac97f9c8e6bd46b60854c136099c0dd4a09f6.1690564372.git.skhan@linuxfoundation.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?dfj6xtdk2BQs2jsBAVS1KVRLS0/VAukddCJk1Gpphv0riAMuRIRCk72YvE2J?=
 =?us-ascii?Q?XsOZSG5oaXg78efA9R1KeFbAz5ps6OhoW2OicU9wHwEL1T/x66yWnEmyOyzq?=
 =?us-ascii?Q?bBKOwcnkqBhsKbtvRbsGPuiXcMXQs900cq/vxzf6LONtJ7b/EdIdXKg8/oX+?=
 =?us-ascii?Q?elaVjDYyv+TlQoVJcGFNrpftJ/BZRzWkecJ3MwEASHlXF/SCiHJvEDfgBr28?=
 =?us-ascii?Q?Cr8gJVWxKQu9m2+TkC2TLDpDbId1mkzGjONs3iDLqqiTn4pfvFCa+05MrrOw?=
 =?us-ascii?Q?6ca567bdudN/n4Dj6LV9Q+O2CAMBYe7dknjtM7lZjkZ1s+jN/UucG9JKIz+N?=
 =?us-ascii?Q?lSwI0I19zU4t357ylEIDbAo4FtSmPc04UqmK0jj5wBLKE2O4ELO4Fqv9FJbw?=
 =?us-ascii?Q?O7LoM6nCJr6abhJu8nmssdKrTl1V3Fv0P1mucPsK63AHFf6WXvZCmd9qqTui?=
 =?us-ascii?Q?R582Tz8CezeF3d0y0p6/QYGctGfB8MbQLARNOo+YgKVRY04FMa9LdFPDiyTr?=
 =?us-ascii?Q?oI+rGalgQb+9L4TGHGq6/9LFO9oHUOS705SzuEDGjopQu8EE3o2KOxFPbcBe?=
 =?us-ascii?Q?1FIDNEoTWYPVjULyzaxNSDde4gT2csoQV5VxIFbo5RnFORXaPbzT947M9yLc?=
 =?us-ascii?Q?3kSqqPMPjcZbUqaJg7N9V7KIAp6m5NwvEp4Mpkff3E8YyVhNX3/l8U8rclHU?=
 =?us-ascii?Q?3M++TYdge76c85fMSCkVpRF40G/4u9M7e2msdX8LtKNVC94HZuH9PEVaUAfY?=
 =?us-ascii?Q?zdU2EzaQINKwA6CMlyWFqO/lC3lT1uRL4UJNZMBfOfVbLoHIttdZJKoALb7W?=
 =?us-ascii?Q?XzUtmeo+HjRPQeRh3EdZsKdQeZxq39KuMa0XJl6O6r4MT/BxtY1eqrnXF1fE?=
 =?us-ascii?Q?BVGGnB4XTOQDpvHl9QdkfffmOExO7Pa1I0cGBXIhwD7rh2qtnsXxWcLzJ8f0?=
 =?us-ascii?Q?9ECI0z0XE2RHmzBvRAzn90zckTbC7mHTRyakkrsfx3X5ckvGF9kFZBRbUEwe?=
 =?us-ascii?Q?lrRLre99R0M9JvqYf0K6Ro95qCXy7LE1NuwcK2T+BVC2AH8Aq/k0F/rVglOs?=
 =?us-ascii?Q?7kUv9HcZPKqyGJZ7GpDuJoZAm3is9bwh9NcQeV+9jIBK4ly7UtiVZxi0aSW7?=
 =?us-ascii?Q?W7ZenT8e6HDek1ilqG3AWTQ6YAhytyyuW29Sx74lwR3n0UukKFQBBjNWlc7J?=
 =?us-ascii?Q?SVWw6Ky4GJ117xINSHYwo9LxKmA4DZU86tTTk7GL3zTCjJc+ZhtBdPHkBL3F?=
 =?us-ascii?Q?9CSMZlCectNLcwKIEHSI0qbEIYkAwUrFegrrvtGXFBxFpRA0F4UUVW79uMe0?=
 =?us-ascii?Q?zy9uVa/zEoKB/QHqtMwdv0pGGSy5cWMG2z+f6CKLZ3sbFuR4KsiugAnFoUmd?=
 =?us-ascii?Q?HjcFhzx1aing8WGUN/5r3KSUXFrgcGYVqyZ2YZ1Y5WAkPbjR0uXdK0qfuHbl?=
 =?us-ascii?Q?pkTfn9P7200VwCzd5YAtF5OZ1pLvkFNHZaLom7WQToOoOxZXInSqp6tFsFOM?=
 =?us-ascii?Q?BY4EqKqq63fbZV145OtI/92HxTHb/uA5UCCEWktdrOHCMf40xEgrjUiukaxp?=
 =?us-ascii?Q?jqcnoYaRX5+OhdhFKmygKawojOO1On/DBfuHp09vrl2hToCJr12FgyGYFyuE?=
 =?us-ascii?Q?OkgsXp5LxYQJlUeZb/haQuOOmO61SdgtLPvBCz7KqsGlmpebczYoJVcVKwOR?=
 =?us-ascii?Q?y5qG9cdfhPhf5hwJajJUvjPUSMQ=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <70A68BFD5BB4BB47ABEC89ABF69FB3FA@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 6WlZtdobdyc61RUUZIEpxehl69lxX4sNbp6zubbUCmw9VfyzJ6iAvxtqQ6hW5GHqYpWk8kuyybLSt6U8eKcUrwpAqQnX9I+YkDeFS8Vq8Q3qJ3SlyglRfi64aDFoNm1vBmTIpfjJvOLI0LXn+UcHrO5kIM+5zUnSTqLZMan9okUyCqtk2pevJuthhbX1PJQa+kKyEMQrEgQSlydjlzkkIURdAgHPH6WZcot8Juy8a18F1q4MXofnh9+NsAxsF2TQFxeiYTQsqubJVRsRlwPdva8+54hLN4Sh1iWkPxKubjz0sqshPvKSUIszuVWtdm/R8UF4AOkfrj44/B6UnNDYupZkSMV1UfXzB1MuZRrpe1IHACEXLC98xuOnirH93XRHetKN9wtvBS7ePdXiHzZUHS28V4ODrR2GzMvfKCfyut7D1quu804kucCAfuvUKb1A75pWlvS4YzuO4d9yQlPSUQmpKIDvV41Y7y5Lvs7Z+8QAQCUDol5KwfMYJ8vkOEjvWK5O+ZsKKDuonUccUTkonORGQcMbrejlPxYlTl0cvO3YbMyPWzsTTiGOgxguIr0Rus9E4unSskjRgFi+lbugZnlklqP5R8j6MP1lLXCC3yzl3KswYyNYJcdZh3PbzXCoT3eTnA1ePowg0NOQroxyg2mJAETIeLL6KQm6Vn/UkTIZ7LUarO12aBBCl+W9DO0RtRwSp9LCY9E37ny0SYSN8xg0bjcvEw2FjpGojKtbRxe4LkXJUofl8V8MEZPU3VkCHpj39R9uLcDza4uuYn25Zu+/qmGS0TV2u8mrO96Nuo9ZuPIcF5N+RtzDdQGXncxX5PSJ5vq/Nt4Wqh7Ra02xGC+YHpIxLWI9FX3r1ouqDZifYCOwEBQ0L2c110ei1UWA
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4129.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b1d60fc7-6a45-413b-7232-08db8f95fda0
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jul 2023 18:10:57.0875
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: IDiY1PcoSyPvUfpPred37YxsobVa9AzigAX/D4iiZYi4vKjGqdqmxNWwfXTh2oFf8EYOqEB62j1Bis9aO1vL+ySs9wlZpyLkXLE8L/KPQYE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR10MB6560
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26
 definitions=2023-07-27_10,2023-07-26_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 adultscore=0 bulkscore=0
 mlxlogscore=999 suspectscore=0 phishscore=0 malwarescore=0 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2306200000
 definitions=main-2307280165
X-Proofpoint-ORIG-GUID: xqSjhWR92XmyYjXFh_2U7agtJNzfyPWg
X-Proofpoint-GUID: xqSjhWR92XmyYjXFh_2U7agtJNzfyPWg
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Jul 28, 2023, at 10:29 AM, Shuah Khan <skhan@linuxfoundation.org> wrot=
e:
>=20
> proc_filter test requires root privileges. Add root privilege check
> and skip the test. Also fix argument parsing paths to skip in their
> error legs.
>=20
> Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
> ---
> tools/testing/selftests/connector/proc_filter.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>=20
> diff --git a/tools/testing/selftests/connector/proc_filter.c b/tools/test=
ing/selftests/connector/proc_filter.c
> index 4fe8c6763fd8..7b2081b98e5c 100644
> --- a/tools/testing/selftests/connector/proc_filter.c
> +++ b/tools/testing/selftests/connector/proc_filter.c
> @@ -248,7 +248,7 @@ int main(int argc, char *argv[])
>=20
> 	if (argc > 2) {
> 		printf("Expected 0(assume no-filter) or 1 argument(-f)\n");
> -		exit(1);
> +		exit(KSFT_SKIP);
> 	}
>=20
> 	if (argc =3D=3D 2) {
> @@ -256,10 +256,15 @@ int main(int argc, char *argv[])
> 			filter =3D 1;
> 		} else {
> 			printf("Valid option : -f (for filter feature)\n");
> -			exit(1);
> +			exit(KSFT_SKIP);
> 		}
> 	}
>=20
> +	if (geteuid()) {
> +		printf("Connector test requires root privileges.\n");
> +		exit(KSFT_SKIP);
> +	}
> +

I am not sure why you have added this check? proc_filter does not need root=
 privilege to run.

Anjali
> 	if (filter) {
> 		input.event_type =3D PROC_EVENT_NONZERO_EXIT;
> 		input.mcast_op =3D PROC_CN_MCAST_LISTEN;
> --=20
> 2.39.2
>=20