Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Ajay Kaher <akaher@vmware.com>
To:     rostedt@goodmis.org, shuah@kernel.org, mhiramat@kernel.org
Cc:     chinglinyu@google.com, linux-kernel@vger.kernel.org,
        linux-kselftest@vger.kernel.org,
        linux-trace-kernel@vger.kernel.org, lkp@intel.com,
        namit@vmware.com, oe-lkp@lists.linux.dev, akaher@vmware.com,
        amakhalov@vmware.com, er.ajay.kaher@gmail.com,
        srivatsa@csail.mit.edu, tkundu@vmware.com, vsirnapalli@vmware.com
Subject: [PATCH v6 02/10] eventfs: Implement tracefs_inode_cache
Date:   Fri, 28 Jul 2023 23:50:44 +0530
Message-Id: <1690568452-46553-3-git-send-email-akaher@vmware.com>
In-Reply-To: <1690568452-46553-1-git-send-email-akaher@vmware.com>
References: <1690568452-46553-1-git-send-email-akaher@vmware.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?FT4kDbKFeog1QQTHAEjr0zKDhcWf4NAqNAqgf0atGwUCVt1vg5G3/EHSnsDC?=
 =?us-ascii?Q?7tA/SDn1Z/YV8TvIL65P2AfJTmimQ6O17t2xr3o9yO95rJFcSF1A6HqYFsAp?=
 =?us-ascii?Q?0rkCHii5iWvtks/70BUx/kol3+scWhWA/tNk6LIIJaPvwTza/kD1Z0shXbEy?=
 =?us-ascii?Q?6GAQzawP6BLU73htIlRswe5tLBFqW3RhqM2EqUuvQ+JEy3ntSrS4/V0F0ZXe?=
 =?us-ascii?Q?OTmMwFRJW2hNp6qCM84pbOttTB+bVSUwBYV4SU/ugA1vuZ0xpcAVtlxMSbDg?=
 =?us-ascii?Q?82b9eb146C7Jouu6bZcNaib5jHnJ7RX9XmQsSNsG858SD9JXx36w0HMHMd2E?=
 =?us-ascii?Q?oYpJkJTX7CkjTRupaCNIwCMbqTOnMG0v9dxmvhcxQ487b+wUUz9BUE2yvkmo?=
 =?us-ascii?Q?n0oNsIVpqeFmLP79/jV3iSPGvACc9asBLqUdlGFTQL5bcgSp6tHtjFhrrEPo?=
 =?us-ascii?Q?LJBj19pDdkEkigmPdRPu8EkN7cBTlN54ZLm+72Wf3oLiy5JacbwnMJUTjYGw?=
 =?us-ascii?Q?t9yqYLpkqUqnrgpMiNormERxl2ueeknCczQQ7iBcTg0guP76MWuNf0uoRVpN?=
 =?us-ascii?Q?9r4vTNRqLCmYUQ3HGKOMzMnrfx3VX38tocRRhY33LY/y3DVUDucGn+8d/1bn?=
 =?us-ascii?Q?eE+LjWXP3IbVZ/7BHoDdMNqnCoieKrjfDPfB08BZv/VlFWth32tw3L3kgVfY?=
 =?us-ascii?Q?vZLtvF+2s/YzPSYsSL0418KByIPASqUKa3hck6dR++A3PDriRWVdCQRIfX1Z?=
 =?us-ascii?Q?WeRVYihYepfT7QvfryUKb9Ps+9wDoAqCiZO2MrJ9ZxCv0FlGytc29+8OZMLa?=
 =?us-ascii?Q?E4JrA+SUOYdsUW9+NrZW/XF4y9/mq9Df3riZ5Xs3afpKjXsCAjkFfl+HjAZw?=
 =?us-ascii?Q?RW/b0EQjwzTgEMfhs2cc5JMswU2iqlnK7p2RBwry2EAelp8IxGbSaaOaiL10?=
 =?us-ascii?Q?S6waB2Xm8UQORcWsNmknJTeljDyEgwI1cd86fx9Ho40XMVzpDJk+aPE/1VgU?=
 =?us-ascii?Q?gTXy1PzW67CoADgW/IZLbHHDNuBfBsNNQfSMMmHXRuuCKtL16OHKENLULjGz?=
 =?us-ascii?Q?gbxzdJWOzHSzLwzgd+LEHgb1SRKWyMAKe66hFnS2zgAolaOkFRtMLizBSb5u?=
 =?us-ascii?Q?aCoUYPfxnRQvg/pigigEnHN9I40C5/YCaUiH+buS+bcEP45cO73Mxdc2zIIH?=
 =?us-ascii?Q?d1X6zKWgoMKH5MSgfHSuwRdhEXL5BWj048EM/hU28WpZ0UvM0yNM2RX0xCHm?=
 =?us-ascii?Q?hAVpqsFdZQznHu/7+PU9DOMzea9dz7mCyz5GE3aVvL/wU2IyMdOrsoTSPw0O?=
 =?us-ascii?Q?lCIR/YGcLZymIi+xvJI3lqlvkPW1R51GNWhgEhpoNEL9XohODnacJjdWvIaM?=
 =?us-ascii?Q?uFoMJZbbnJ++kVgH7aPDNPRqRHriitrsS1Oj22lYnoFdsGJujjVmyxc7i8uG?=
 =?us-ascii?Q?Fb1XbTyD7c8ysnj6qr4IBSJhe/XGtXz/Ss7el/uf34jLY6Ff3BjADH5oxMyS?=
 =?us-ascii?Q?kra7wLacCBqGXDwLRpn5Nmv1xD0d2jv65oimw3S9towP9nWwztm35gSHshdV?=
 =?us-ascii?Q?zjVU6olcIaSqV49tNNviwmL8XXzwXaU76w0rj6SJ?=
X-OriginatorOrg: vmware.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ad2bbd36-b5c7-4bb0-64e5-08db8f977027
X-MS-Exchange-CrossTenant-AuthSource: PH0PR05MB8703.namprd05.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jul 2023 18:21:18.9072
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ckH8W+j2TocyhhE8cWr03ICvNYJh5h9KNKjUquNF2vjOk+oIv65/6kmik5lOL+G66uAVz6I3ea8wY5htajpnzg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR05MB9264
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Create a kmem cache of tracefs_inodes. To be more efficient, as there are
lots of tracefs inodes, create its own cache. This also allows to see how
many tracefs inodes have been created.

Add helper functions:
tracefs_alloc_inode()
tracefs_free_inode()
get_tracefs()

Signed-off-by: Ajay Kaher <akaher@vmware.com>
Co-developed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Tested-by: Ching-lin Yu <chinglinyu@google.com>
---
 fs/tracefs/inode.c    | 39 +++++++++++++++++++++++++++++++++++++++
 fs/tracefs/internal.h | 15 +++++++++++++++
 2 files changed, 54 insertions(+)
 create mode 100644 fs/tracefs/internal.h

diff --git a/fs/tracefs/inode.c b/fs/tracefs/inode.c
index 57ac8aa4a724..2508944cc4d8 100644
--- a/fs/tracefs/inode.c
+++ b/fs/tracefs/inode.c
@@ -21,13 +21,33 @@
 #include <linux/parser.h>
 #include <linux/magic.h>
 #include <linux/slab.h>
+#include "internal.h"
 
 #define TRACEFS_DEFAULT_MODE	0700
+static struct kmem_cache *tracefs_inode_cachep __ro_after_init;
 
 static struct vfsmount *tracefs_mount;
 static int tracefs_mount_count;
 static bool tracefs_registered;
 
+static struct inode *tracefs_alloc_inode(struct super_block *sb)
+{
+	struct tracefs_inode *ti;
+
+	ti = kmem_cache_alloc(tracefs_inode_cachep, GFP_KERNEL);
+	if (!ti)
+		return NULL;
+
+	ti->flags = 0;
+
+	return &ti->vfs_inode;
+}
+
+static void tracefs_free_inode(struct inode *inode)
+{
+	kmem_cache_free(tracefs_inode_cachep, get_tracefs(inode));
+}
+
 static ssize_t default_read_file(struct file *file, char __user *buf,
 				 size_t count, loff_t *ppos)
 {
@@ -346,6 +366,9 @@ static int tracefs_show_options(struct seq_file *m, struct dentry *root)
 }
 
 static const struct super_operations tracefs_super_operations = {
+	.alloc_inode    = tracefs_alloc_inode,
+	.free_inode     = tracefs_free_inode,
+	.drop_inode     = generic_delete_inode,
 	.statfs		= simple_statfs,
 	.remount_fs	= tracefs_remount,
 	.show_options	= tracefs_show_options,
@@ -628,10 +651,26 @@ bool tracefs_initialized(void)
 	return tracefs_registered;
 }
 
+static void init_once(void *foo)
+{
+	struct tracefs_inode *ti = (struct tracefs_inode *) foo;
+
+	inode_init_once(&ti->vfs_inode);
+}
+
 static int __init tracefs_init(void)
 {
 	int retval;
 
+	tracefs_inode_cachep = kmem_cache_create("tracefs_inode_cache",
+						 sizeof(struct tracefs_inode),
+						 0, (SLAB_RECLAIM_ACCOUNT|
+						     SLAB_MEM_SPREAD|
+						     SLAB_ACCOUNT),
+						 init_once);
+	if (!tracefs_inode_cachep)
+		return -ENOMEM;
+
 	retval = sysfs_create_mount_point(kernel_kobj, "tracing");
 	if (retval)
 		return -EINVAL;
diff --git a/fs/tracefs/internal.h b/fs/tracefs/internal.h
new file mode 100644
index 000000000000..954ea005632b
--- /dev/null
+++ b/fs/tracefs/internal.h
@@ -0,0 +1,15 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+#ifndef _TRACEFS_INTERNAL_H
+#define _TRACEFS_INTERNAL_H
+
+struct tracefs_inode {
+	unsigned long           flags;
+	void                    *private;
+	struct inode            vfs_inode;
+};
+
+static inline struct tracefs_inode *get_tracefs(const struct inode *inode)
+{
+	return container_of(inode, struct tracefs_inode, vfs_inode);
+}
+#endif /* _TRACEFS_INTERNAL_H */
-- 
2.39.0