Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date:   Fri, 28 Jul 2023 18:55:56 +0000
Message-Id: <CUE18VURE744.1E29WQ8EU666G@seitikki>
Cc:     <keyrings@vger.kernel.org>,
        <linux-security-module@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 -next] keys: Remove unused extern declarations
From:   "Jarkko Sakkinen" <jarkko@kernel.org>
To:     "YueHaibing" <yuehaibing@huawei.com>, <dhowells@redhat.com>,
        <paul@paul-moore.com>, <jmorris@namei.org>, <serge@hallyn.com>
References: <20230724144717.23660-1-yuehaibing@huawei.com>
In-Reply-To: <20230724144717.23660-1-yuehaibing@huawei.com>
Precedence: bulk

On Mon Jul 24, 2023 at 2:47 PM UTC, YueHaibing wrote:
> Since commit b2a4df200d57 ("KEYS: Expand the capacity of a keyring")
> iterate_over_keyring() is never used, so can be removed.
>
> And commit b5f545c880a2 ("[PATCH] keys: Permit running process to instant=
iate keys")
> left behind keyring_search_instkey().
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Please use the fixes tag properly.

> ---
> v2: Also remove keyring_search_instkey()
> ---
>  security/keys/internal.h | 7 -------
>  1 file changed, 7 deletions(-)
>
> diff --git a/security/keys/internal.h b/security/keys/internal.h
> index 3c1e7122076b..471cf36dedc0 100644
> --- a/security/keys/internal.h
> +++ b/security/keys/internal.h
> @@ -109,13 +109,6 @@ extern void __key_link_end(struct key *keyring,
>  extern key_ref_t find_key_to_update(key_ref_t keyring_ref,
>  				    const struct keyring_index_key *index_key);
> =20
> -extern struct key *keyring_search_instkey(struct key *keyring,
> -					  key_serial_t target_id);
> -
> -extern int iterate_over_keyring(const struct key *keyring,
> -				int (*func)(const struct key *key, void *data),
> -				void *data);
> -
>  struct keyring_search_context {
>  	struct keyring_index_key index_key;
>  	const struct cred	*cred;
> --=20
> 2.34.1


BR, Jarkko