Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760120AbXJ2S6T (ORCPT ); Mon, 29 Oct 2007 14:58:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753866AbXJ2S6J (ORCPT ); Mon, 29 Oct 2007 14:58:09 -0400 Received: from brick.kernel.dk ([87.55.233.238]:23563 "EHLO kernel.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752894AbXJ2S6J (ORCPT ); Mon, 29 Oct 2007 14:58:09 -0400 Date: Mon, 29 Oct 2007 19:58:04 +0100 From: Jens Axboe To: "Robert P. J. Day" Cc: Linux Kernel Mailing List , gorcunov@gmail.com Subject: Re: [PATCH] Clean up scatterlist.h and introduce macros for readability. Message-ID: <20071029185803.GA7499@kernel.dk> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 741 Lines: 20 On Mon, Oct 29 2007, Robert P. J. Day wrote: > > Add some macros to to make the bit manipulation > more readable, and expand on some of the documentation. > > This patch incorporates content from Cyrill Gorcunov > as well. I don't like it, I already explained why I don't consider the 'magic' values a problem. The use of the bits is supposed to be scatterlist.h private and the values are documented at the top of that include file. -- Jens Axboe - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/