Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <79ee5522-3f3e-3480-dfb2-0c7640a97587@amd.com>
Date:   Fri, 28 Jul 2023 14:29:05 -0500
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] ACPI: resource: Add a quirk for Lenovo Yoga 7 14ARB7
To:     August Wikerfors <git@augustwikerfors.se>
Cc:     rafael@kernel.org, linux-kernel@vger.kernel.org,
        linux-acpi@vger.kernel.org, regressions@lists.linux.dev
References: <20230728183921.17230-1-mario.limonciello@amd.com>
 <1af52057-84e4-be2a-5fac-24847361812d@augustwikerfors.se>
Content-Language: en-US
From:   "Limonciello, Mario" <mario.limonciello@amd.com>
In-Reply-To: <1af52057-84e4-be2a-5fac-24847361812d@augustwikerfors.se>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dWNDYlI3WDNuS0dJUzhnMW9oSkR1NHJyZkUzVzlReGF2Vk1Lb04rSzlHUkQx?=
 =?utf-8?B?Y3ZNcG9BRG9lNGNZSGRCRkcvNnc0aE5sWkNkaldTU1VIUmVTUWhOUjZPQmQ5?=
 =?utf-8?B?anFDaHpuaE9pL2NzNzBoMlc5YnBLTjQ4N2xCMmUvMkpEcnNUaWhFbWNISkRF?=
 =?utf-8?B?a21qMDJHbm1GSi9KUEdEQ25aS0FWTUpFSU5kdk1sdkd2TGc1R0dqME84ZXFU?=
 =?utf-8?B?a3Fiam5RN0V0VnZrUjY2RzdYNURjcWpIMUZ6K0N2bGhnUlJ0VGhxTGhqNEpn?=
 =?utf-8?B?Q1BKTUV6a2I5eGlzcXd5MVBYc3g2R1Y1dE1TQXZYQnMzRW1NUGdpdTZIdEx6?=
 =?utf-8?B?VmJGNTQ0NXdXVW9pVVNPWE1SYXlLQ0tCNTFaMVA0UE9vNUhZTTFHRlVwM3NT?=
 =?utf-8?B?U0JFWjR6c1V4dkwzRWhXZG1UTmExZHROUUVnTGlQZHk2TzUvKzRsc2NVZ3BS?=
 =?utf-8?B?d3h6YzkyeTdlZTlSKzBodDBJSEsyNUlPektyd3lQSHhmNWVLanRvZ1BuK2Z0?=
 =?utf-8?B?ajFDbmE4QlJZQ2J1d1BtR0owR3daTVkwblFIV1pXVi9jMjhQcGIyODBUejcw?=
 =?utf-8?B?cFFpbVF4ckdxWlJabXlmU3VvV2xiQ3pSVEFSaXBjSGlmUDNSaE1nNVlsKzYv?=
 =?utf-8?B?N0VUVkZZaTJnNWViQU8weGg3ZXBPMzRzSDRwQ203TTAvVkV1dWhTc1lZT3Vj?=
 =?utf-8?B?WFlLejVlUmE2N3FFbG43QnJhODFsYlMyKy9pUlBCc1ExZXRrc1QveXdYQWEr?=
 =?utf-8?B?N1JLejR5NzJrdUxvcEhobDNCQnZTTGxyNHhxRFQ0YWp4MFVLeXA3SlhQTURs?=
 =?utf-8?B?QU5Hb3FKUWRJbmNuWUdEQzlJYTEvMFM4U3BqQ1dEbVBXa05JNWx6Uk4vRTJK?=
 =?utf-8?B?MmhTdnBCcjluMU0yZG5jcHRSZTE0RWVOYXdTY1RqYXJGR1ptK01TWEd2NG9H?=
 =?utf-8?B?ckxySjdlSXRTOSs2Z3dFSElWaUtlOGMrc2tUNUdBVzBXakFjQXRDbTZYRzFG?=
 =?utf-8?B?dmtBa2dVSkJNMThTSmJBNWM2bHNpbXJCdnRhd3pxcWFpMktzaDJLRG5NdHpn?=
 =?utf-8?B?aEdZZFlZcGFEUnV5czhPTitPQnhEb2wwNUFmUlVJVVlnZ1ZqOG9waURyV2Zu?=
 =?utf-8?B?V1JUeUJpLzM0ZUhNM2NIdnN1eU4zNStGMkpZZHVKN3YyQmF2NnIzeURxQ2tV?=
 =?utf-8?B?TnRsRWNnNmJxSWdLLzgrNElqTlRadW02NWpaSExmZkF4Qi9BUHZOYmt4S09h?=
 =?utf-8?B?S0xhWitnVEp0cGZnRS9GWDFjVnc5QnF2SjhTZW5Ndnl6eFdFZFdrK2tDdmZN?=
 =?utf-8?B?TWdHdlMweHdkcFlzZllsSHhNUkJXU1NxWGxYYVZRay8vbWN1SThZYmg2ZlRj?=
 =?utf-8?B?cFR4TFgvU1VpQjRXdUR2VFZ5WkhWNVJHRWZkNk44UUNBTks1THBNYjJTVHYz?=
 =?utf-8?B?SE11RXU0cXY1NGZrK1N4RnVOakFsZmQ1b2lZeDlnYjhkaDZoeTJLVkdFOHFp?=
 =?utf-8?B?ZG5XYmIrenlMdVNwUDBxVEQyNGZ0bEZadk50QWk3ZElQVWNQN21HM2taNFFu?=
 =?utf-8?B?eE9lWlAvK3YyRHhLbDAraE90ckFBc1VuYVpoeW9vdzVBRlIray9wTlBNZVEy?=
 =?utf-8?B?bWIrRmJSMU5LSnRkaTlkNVFnTEVDR3J3RUJReGJtYk1Bb2I3REttcG1mTHll?=
 =?utf-8?B?Q0xqMUtid3RuazkzQmQzWlEyRmJkR2NDSTdYcWdQM001Nll3aG94bzZUR2wv?=
 =?utf-8?B?L3dTZlRCZHNGN3lhM2tiYmY3S0wvaThoZzNZaVpwTzFHWTlNNmdYSmd6SXFo?=
 =?utf-8?B?STRmaUV3TmxBZ0FoajNjQjRJRzRjZkRsTyt2QXYwZzFxa0xqelo1NnkxcGN3?=
 =?utf-8?B?V3ZxV2o1ZlpIaWNwdGcreVdzQlE2bVluUi9mcFVMeG5vZjFNSWRYM1B2TWta?=
 =?utf-8?B?VFdXY1NKVVF4SVlnejROTmwvZTZlcitGdVhIaCtmVXBDN2drL3FuN1p0S2p4?=
 =?utf-8?B?MlNoWWcxUGF3dm1XMG4zTzQzQ042cGVKY2hyZk4vQ2hPUzRtWFRkTkhldC8z?=
 =?utf-8?B?dVpKRXB4L2d3L0tERkt0RHc4Z0UvbkkzYlp4ZTdMYlRvOWpycFB1UTg3YnNG?=
 =?utf-8?Q?dlwymrgvW/+aiU0y+FWr2VVdl?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 38b5991d-14b9-4ee9-f43e-08db8fa0ea45
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jul 2023 19:29:09.2265
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6TEJcEBxDfP70PJx/SlAuAiYBZaQrrT3mbPE082FEg92esSzSFTBib61Q3ASjc7isnC4K0k/dTPsTlOCXlbiMQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB7272
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 7/28/2023 2:25 PM, August Wikerfors wrote:
> On 2023-07-28 20:39, Mario Limonciello wrote:
>> Lenovo Yoga 7 needs to have keyboard interrupt signaling polarity
>> is incorrect in the MADT and the value from the DSDT should be used.
>>
>> Reported-by: August Wikerfors <git@augustwikerfors.se>
>> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=217718
>> Fixes: a9c4a912b7dc ("ACPI: resource: Remove "Zen" specific match and 
>> quirks")
>> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
>> ---
>>   drivers/acpi/resource.c | 12 ++++++++++++
>>   1 file changed, 12 insertions(+)
>>
>> diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c
>> index 1dd8d5aebf678..1a826419d5837 100644
>> --- a/drivers/acpi/resource.c
>> +++ b/drivers/acpi/resource.c
>> @@ -481,6 +481,17 @@ static const struct dmi_system_id lg_laptop[] = {
>>       { }
>>   };
>> +static const struct dmi_system_id lenovo_laptop[] = {
>> +    {
>> +        .ident = "Lenovo Yoga 7 14ARB7",
>> +        .matches = {
>> +            DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
>> +            DMI_MATCH(DMI_PRODUCT_NAME, "82QF"),
>> +        },
>> +    },
>> +    { }
>> +};
>> +
>>   struct irq_override_cmp {
>>       const struct dmi_system_id *system;
>>       unsigned char irq;
>> @@ -494,6 +505,7 @@ static const struct irq_override_cmp 
>> override_table[] = {
>>       { medion_laptop, 1, ACPI_LEVEL_SENSITIVE, ACPI_ACTIVE_LOW, 0, 
>> false },
>>       { asus_laptop, 1, ACPI_LEVEL_SENSITIVE, ACPI_ACTIVE_LOW, 0, 
>> false },
>>       { lg_laptop, 1, ACPI_LEVEL_SENSITIVE, ACPI_ACTIVE_LOW, 0, false },
>> +    { lenovo_laptop, 1, ACPI_LEVEL_SENSITIVE, ACPI_ACTIVE_LOW, 1, false}
> This should have ACPI_EDGE_SENSITIVE, not ACPI_LEVEL_SENSITIVE, see 
> https://bugzilla.kernel.org/show_bug.cgi?id=217718#c11

Thanks, sorry about that mistake.  I'll resend it.