Received: by 2002:a05:6358:c692:b0:131:369:b2a3 with SMTP id fe18csp1892219rwb; Fri, 28 Jul 2023 17:29:57 -0700 (PDT) X-Google-Smtp-Source: APBJJlGvVpzrpSFzCsae3U02gMgAhs0Pj1ZPLGkDuzr8RCSXCt7wcNyLIqfLj37aAp1eKlwIAu09 X-Received: by 2002:a05:6a00:842:b0:684:b886:e392 with SMTP id q2-20020a056a00084200b00684b886e392mr3603418pfk.25.1690590597599; Fri, 28 Jul 2023 17:29:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690590597; cv=none; d=google.com; s=arc-20160816; b=Vatr7jn+I2amUfoGaBvhO8l9J3fprGzTBnwnaY+H18NWzttOjCWtRP7KEiRYlvp5cq PMYagFWpm/pAOfl8zCv3+8/Eus6DRZor15LkBWjscG3+Pmh3mrB/rAydgCguedJ6EeBQ pJDad2U90fLnfXPJrsdEc87kxjxh5Md5NpzMMT47AtLozi1ne+A3Ow5IaAM2V/xA2Lk3 cur1dMebeUeGjOwhOeSK8U2xoAlEJxgUI0FEcyqjNzZNjJz9DpP4RHY820ioZYZHy40Q GdRyGYZ3qI8pyPX83LwcddpsFj206TvKcO7Lj88ocTe/KKT8A9aClI1R0jT9oWqBisI+ KhoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:references :in-reply-to:subject:cc:to:dkim-signature:dkim-signature:from; bh=6IqxueJihZdskvWxidXUVsjKtqOSCm2RR/PabSw5ug8=; fh=tJChKWmpA3sQTxDIi3UaV22wRL380tLQEZXBOa7LfdQ=; b=ysAPDq2h1CDnrlRXfBrA1vE8exsoTn1ofAErDmjyzp7IdjsENRGqWyaFuU0bpjtD1z dKo+XOvi9dZnPPLDVWxmzNHcL/rL9BN01mTtkuPCk+A5cxghFUghE4HPXOh9XyAhHSCS 77eQSpoy3T1A30PKfF08E9hsU01LxdepLrBZOfW/VZHV1NFiTjz+QyxBQWqEe2qg8QOj 2VnJOZSm46RAlxWYaK2/QIzfZ+Jwnsu39srAW/nMQUqEI7HvMtyUdRdJp/qjPZhpVxgK CXKuTK7IFvXwhyR5WXJu+RyYG+WCaRAo7MjiCWR/XniBbJ18FxzccPf3vu3jJR6hdnI1 dzAA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=IHMd2CQu; dkim=neutral (no key) header.i=@linutronix.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id fa32-20020a056a002d2000b006870c1e9feesi2067735pfb.274.2023.07.28.17.29.46; Fri, 28 Jul 2023 17:29:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=IHMd2CQu; dkim=neutral (no key) header.i=@linutronix.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232606AbjG1WuW (ORCPT + 99 others); Fri, 28 Jul 2023 18:50:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53192 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229740AbjG1WuU (ORCPT ); Fri, 28 Jul 2023 18:50:20 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 30141173F; Fri, 28 Jul 2023 15:50:20 -0700 (PDT) From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1690584616; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6IqxueJihZdskvWxidXUVsjKtqOSCm2RR/PabSw5ug8=; b=IHMd2CQu+RUSScvlJTJWocAFi6CYMIjmSSvzxYR4SVUuNfEzsjoTNfmVk4BPk++YB3xMtw C2Hb9SZ7XxQzGyanFTP1XZwSjCNwzeV9m+49sY2CBz+BXFdhwV3ZK1yG9f+menpNAWKYj9 wFBzqO2l9P2dDJPNMG1DVDgKGoPvNra1ft5XP8EWPJU95AU+FNEgNx9vnZuV/rhr2STbRW 9i3R0sqatM563UDwYbkCJfOWlplTXoWkjM2ReakKhVPm3/VtL+jLx9FIq6Ph5A0GeZg09j Ly2zI06kxzDNpoAyErn+YNo3JpWqLPzRWIW7IcEbBnqceGlPl6WjATa8N9Nhdw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1690584616; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6IqxueJihZdskvWxidXUVsjKtqOSCm2RR/PabSw5ug8=; b=YIU21vK5J7ASWrNM8Toawzal/abIIPXf8upc4Jld2Q3sjseBlomtk9m8MLINaebPXLKBDB fedYBRbOTvSEPjAA== To: Sohil Mehta , LKML Cc: x86@kernel.org, Tom Lendacky , Andrew Cooper , Arjan van de Ven , "James E.J. Bottomley" , Dick Kennedy , James Smart , "Martin K. Petersen" , linux-scsi@vger.kernel.org, Guenter Roeck , linux-hwmon@vger.kernel.org, Jean Delvare , Huang Rui , Juergen Gross , Steve Wahl , Mike Travis , Dimitri Sivanich , Russ Anderson Subject: Re: [patch v2 11/38] x86/apic: Use BAD_APICID consistently; In-Reply-To: <48b6d063-8528-2208-5117-5c9c095886e5@intel.com> References: <20230728105650.565799744@linutronix.de> <20230728120930.281607646@linutronix.de> <48b6d063-8528-2208-5117-5c9c095886e5@intel.com> Date: Sat, 29 Jul 2023 00:50:16 +0200 Message-ID: <87wmyjps5z.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 28 2023 at 15:36, Sohil Mehta wrote: > There is an extra semicolon at the end of the patch subject. Oops > On 7/28/2023 5:12 AM, Thomas Gleixner wrote: >> APIC ID checks compare with BAD_APICID all over the place, but some >> initializers and some code which fiddles with global data structure use >> -1[U] instead. That simply cannot work at all. >> >> Fix it up and use BAD_APICID consistenly all over the place. >> > > s/consistenly/consistently Indeed.