Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 28 Jul 2023 16:58:39 -0700
From:   Dan Williams <dan.j.williams@intel.com>
To:     Ira Weiny <ira.weiny@intel.com>,
        Alison Schofield <alison.schofield@intel.com>,
        Vishal Verma <vishal.l.verma@intel.com>,
        "Dan Williams" <dan.j.williams@intel.com>,
        Dave Jiang <dave.jiang@intel.com>,
        Jonathan Cameron <Jonathan.Cameron@huawei.com>
CC:     <linux-cxl@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Ira Weiny <ira.weiny@intel.com>
Subject: RE: [PATCH] cxl/memdev: Avoid mailbox functionality on device memory
 CXL devices
Message-ID: <64c4562fb7531_a88b29481@dwillia2-xfh.jf.intel.com.notmuch>
References: <20230728-cxl-fix-devmemdev-v1-1-dbd3269b3295@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230728-cxl-fix-devmemdev-v1-1-dbd3269b3295@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?tXR5hUOFJTsBfNR3AA13wQc1vxRyFNLynNvl0ncIKHltY2HQdj6a+NJoEnSX?=
 =?us-ascii?Q?T3K3a/uHHpfLbHrp9YTFODwg17Gmpt0GhxIJv1bs+S8oeGeZvRXajnrlhJo5?=
 =?us-ascii?Q?nmFuTOt2fCVFM6KEOI7iMz+n0izrrluFE9V8Rx6DpHJl2SdsIQZ4H+Cg9i+x?=
 =?us-ascii?Q?6h3P2tH7K9QiCJ/Bd+YyPx4SSDLo7egq/itKJI4yXdSVhX3eht1g7fx70oc1?=
 =?us-ascii?Q?sI+LOp+cOoEoobK5pYom6j/+o+cOQxIFGOfJ65X+ELMpNQUyGnqqledkTNTJ?=
 =?us-ascii?Q?mGWAJOQyr+CORDzAm4vwAPAUBONigpd45KpuPGxpOAV4W68heePjlOdVbpWM?=
 =?us-ascii?Q?9HBl4QZMcW30BOWX0mZKPMyt+dhmw9v1USNfRd8+ZE2XEchG85a/rNDBI8eM?=
 =?us-ascii?Q?HmL/ileN4xsuzicUWNJE62C9Ic6HDQWImiJwSDIDzgiN4yBQZ5NZoJZ+bfyI?=
 =?us-ascii?Q?vZTUlkQDgFq9NtIWcLcLTTF9lZjk/b8eMS0pPyZc/BK/Eb1r6rIOuqA6q21q?=
 =?us-ascii?Q?5P+W/bPCTZbTiMVBCBC8vq/Np9idlNkkCrrAB62a8T+z1RlRH4XM9hgv0vZ2?=
 =?us-ascii?Q?NynN7xWH5Y/BvG7Q7sfFiPxFbMQnVnEYJSZjQ73/UHm9gg79LbssmMwDYNOf?=
 =?us-ascii?Q?QdtMKd+Ws//SaokLpl/nrHD4R91o8ov7pgyMpV6rdF1KOqbikvy0hqpaDGTb?=
 =?us-ascii?Q?F57NH94YWNVu4iJ/ih48tzNOSrFRbNJO2WttlmLudv1hpftQg4pKNTNIiSwC?=
 =?us-ascii?Q?aAdz0hepYQJkewe+teC0jWHQJPEGw/aBsDHVezFAucscbMzgnz8Wqy3PcERZ?=
 =?us-ascii?Q?33gAgA8EopKPCjr3HbWerVBBxW09jdP5/3A5iszeTnqXY+lsE6K2I/DTdJ0m?=
 =?us-ascii?Q?7YzHvMRJC0HCvgaRqpTjPgo3TRaQc91vsIROtBHpiKKCES1W3xI2A8m5WWWA?=
 =?us-ascii?Q?gR3BPRK1lCaZRnrwhA79lcelMZxc8REEsJcPiFIjXn0jYbhZgiM7g8vMwdzH?=
 =?us-ascii?Q?VMzxFsCxoxiFlbpjoChxd0eUWOAv5xGbXafhHK3S0hHpdD1asEaAuFUj+c9p?=
 =?us-ascii?Q?3NLTbrxC2qruibZa3rpWTcXtZk9HrEkDIuJp5jFB3gzBQ++Kf8zHL94AU/fx?=
 =?us-ascii?Q?+OctAUUOaE/ZbZu0haL9xerQHfxMI29d7Vx6bF4bPjSSLOIa+noQ+TsVC55i?=
 =?us-ascii?Q?Nacw/qyXEAOFnR1S9shIuQaonPgaq1gFTOdcK4K6JIbBZtKysmEEuQ8z5QK3?=
 =?us-ascii?Q?0yiqeKXADnG7anvYVjm9vqXLurU6f3izS36vmiX5mvHY7DPYn1jWFz2Sk7DZ?=
 =?us-ascii?Q?7na1GKuGYSu3U3QkIyqDJ1yjSI8KW+lCeAYyGPX/yHkDI6sD9IkwuScyaUUd?=
 =?us-ascii?Q?hnOrGalYFOW+3s058SUoEiZSZi/knY29Z+iASP7+gOeoAgykXgPuKpsB9Ffz?=
 =?us-ascii?Q?o33n9TAqeTCuXVlpAZsy+kPdbWHAwB4SHb0/FarOYZ+GlYog3UYOhGh77Ldk?=
 =?us-ascii?Q?vsRkgw7+DmnNQecB4s3MGRFvE4MZ6+aqP+SWcYMBQZwKd5Y/3UoUAgs+6adR?=
 =?us-ascii?Q?KkOrzJheTzVr8QB+SNiErQcxRCgITgJQ/7hxm7Yvu0Fi55IbK7o482xCbgYJ?=
 =?us-ascii?Q?DQ=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c2539ebb-e49c-484d-c92f-08db8fc692f1
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jul 2023 23:58:43.8219
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DVmcto8WfCAmZ0R3OEkxFm+ZDOj3pkE4WkJI14o7YVEdw+ohvuZLAyXJP1BX3P6kfmdGVIfiSiYiPYIS1L8Gnp57ye/0FniEYPO8WxlNePs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB7040
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Ira Weiny wrote:
> Using the proposed type-2 cxl-test device[1] the following
> splat was observed:
> 
>   BUG: kernel NULL pointer dereference, address: 0000000000000278
>   [...]
>   RIP: 0010:devm_cxl_add_memdev+0x1de/0x2c0 [cxl_core]

It would be useful to decode this to a line number, the rest of this
call trace is not adding much.

>   [...]
>   Call Trace:
>    <TASK>
>    ? __die+0x1f/0x70
>    ? page_fault_oops+0x149/0x420
>    ? fixup_exception+0x22/0x310
>    ? kernelmode_fixup_or_oops+0x84/0x110
>    ? exc_page_fault+0x6d/0x150
>    ? asm_exc_page_fault+0x22/0x30
>    ? devm_cxl_add_memdev+0x1de/0x2c0 [cxl_core]
>    cxl_mock_mem_probe+0x632/0x870 [cxl_mock_mem]
>    platform_probe+0x40/0x90
>    really_probe+0x19e/0x3e0
>    ? __pfx___driver_attach+0x10/0x10
>    __driver_probe_device+0x78/0x160
>    driver_probe_device+0x1f/0x90
>    __driver_attach+0xce/0x1c0
>    bus_for_each_dev+0x63/0xa0
>    bus_add_driver+0x112/0x210
>    driver_register+0x55/0x100
>    ? __pfx_cxl_mock_mem_driver_init+0x10/0x10 [cxl_mock_mem]
>    [...]
> 
> Commit f6b8ab32e3ec made the mailbox functionality optional.  However,
> some mailbox functionality was merged after that patch.  Therefore some
> mailbox functionality can be accessed on a device which did not set up
> the mailbox.

cxl_memdev_security_init() definitely needs to move out of
devm_cxl_add_memdev() and after that I do not think @mds NULL checks
need to be sprinkled everywhere. In other words something is wrong at a
higher level if we get into some of these helper functions without the
memory device state.

So definitely this uncovered a problem where cxl_memdev_security_init()
needs to move, but the rest of the mds NULL checks need clear
reproduction scenarios and expect most of them are precluded higher in
the call stack.