Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <48b6d063-8528-2208-5117-5c9c095886e5@intel.com>
Date:   Fri, 28 Jul 2023 15:36:42 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [patch v2 11/38] x86/apic: Use BAD_APICID consistently;
Content-Language: en-US
To:     Thomas Gleixner <tglx@linutronix.de>,
        LKML <linux-kernel@vger.kernel.org>
CC:     <x86@kernel.org>, Tom Lendacky <thomas.lendacky@amd.com>,
        Andrew Cooper <andrew.cooper3@citrix.com>,
        Arjan van de Ven <arjan@linux.intel.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        Dick Kennedy <dick.kennedy@broadcom.com>,
        James Smart <james.smart@broadcom.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        <linux-scsi@vger.kernel.org>, Guenter Roeck <linux@roeck-us.net>,
        <linux-hwmon@vger.kernel.org>, "Jean Delvare" <jdelvare@suse.com>,
        Huang Rui <ray.huang@amd.com>, Juergen Gross <jgross@suse.com>,
        Steve Wahl <steve.wahl@hpe.com>,
        Mike Travis <mike.travis@hpe.com>,
        Dimitri Sivanich <dimitri.sivanich@hpe.com>,
        "Russ Anderson" <russ.anderson@hpe.com>
References: <20230728105650.565799744@linutronix.de>
 <20230728120930.281607646@linutronix.de>
From:   Sohil Mehta <sohil.mehta@intel.com>
In-Reply-To: <20230728120930.281607646@linutronix.de>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aFVpN2c0aTJvWnVjMkYrNjQ3U0QreS9IRlljUkUyeTRJUFFrdG5vcnJ6U3JI?=
 =?utf-8?B?cFZWWkZsOUs5NW1Pamx3ZTBKS0tpWlNGMU10eDE0MUQ5VmVGcHZGb28xaTFt?=
 =?utf-8?B?MnVKMVdQV2dBbE10QnBMVk5MeUxnaXFPY1cvMXJGcThTeXFyTWxPOFhPUHhO?=
 =?utf-8?B?WXJiS2R4WG9aOE1uMmkxSDJRS3ZnVSs1N0ROMy9JWnBCRkx2bFFlQmNoWk13?=
 =?utf-8?B?SjBYMllYRytkelNiS1lHcmRCTEhYbW9RV1Vwa0tBdVF6OU9hUEx3aUtqQW8x?=
 =?utf-8?B?by81bms0L0F4bkpXVDVzYkVUQUNRTmxMcWNkN3ZNaHNreW1NQmt0WFZZNTlS?=
 =?utf-8?B?Ry8xN094VUdPN0FpNWZPdzlDcFVGRktJQ25sY1ltSk9KYk5BeFFoOXVHcGtO?=
 =?utf-8?B?QlNnazdaZkY5QzNLQ2tnL3BOb0dXWFNBSUY3bkk5YTRoUHNCcjZBQ2t6M1dG?=
 =?utf-8?B?SFROSTlkQ21qYkJnN3Roc0hFM2NsTTBwc1B6VkRkREZlVDJZKytGVkpNRlhh?=
 =?utf-8?B?aHFuaGVKSC9KN1JrOEtmbGJDRXh0RzlqbVl1SGxpeGpjQUJHTGlpdE9hOGtX?=
 =?utf-8?B?SFVVQ254ZjRUdHNmZVBsWU5uYUl3YzFoZGJiWVFMVUxtdzJoUGI4NlNXdzl2?=
 =?utf-8?B?RS81NWRKTXZodHpVOW4yQWNlRVZqNHVUMmdJZEdwWlJaMHFUakM5TFRKSFho?=
 =?utf-8?B?MjJ3ajJueUxmeXd1QVpHN3BzZzdjVHBHTWdTTURNZjN3OElhekJJZVFXRGxx?=
 =?utf-8?B?alhOYkZWRHNyNjEvU01ZZHUyQ2tFWVU1VjJTNmRReFFSaFNESUxVVGw0cmVW?=
 =?utf-8?B?djRNWWRvZ0JEcS9BYWk5ejVEWmN6NmxGUkVGenNOTllKSmMvMTFFWEhjWWF6?=
 =?utf-8?B?U2lMUi84eUI0a3pya0o0eUIwSC9TZnAzMVE0ZlhlRkpMcGgza2NGU2ZKem1q?=
 =?utf-8?B?dmN6NjJhNW01cWZLY0VvNDFNUjhhVHhGdzBVYjNCcTF5TTZhbFZvSVhKMWNU?=
 =?utf-8?B?NGFJRGkwa3I1Z3hENzBCREVlZFhGTUFwSjQ4R0FJc1YycWxKb2xYdlkwajlW?=
 =?utf-8?B?UWJGWVZqN09xbTY0bUp4eS9lMjVCWjlpbmw2b0lxZVptWjdBb3gzOGVnRnBm?=
 =?utf-8?B?VkMwQ09YZzBDTnNVLytId2xZbVV5MjRWNkJrbzFTWWQwcTk5dnNlTlpYcm85?=
 =?utf-8?B?L0F1TWw4Yk51eVA2cFl6RGdNWWtLYmtmSnFidDJnQkpYRm4wTEZVOFJ3NHVD?=
 =?utf-8?B?UEd4b2tjM0FQWFQzTDcvSmdhcWVxN1VJYU1BUVFCMFF5Z1llUWVtdVF0QlV1?=
 =?utf-8?B?OFF6ZFVZYjVqemwxdFZCbU1mY2dwNkRLcnVabWpOR1dRSDEraFBxOU9qOVJv?=
 =?utf-8?B?VmNSN0Y4SEhsczVGQ0d3eW1adEhHNmpDdnFoRXYvbVlvcm1oTGhHSzBNMEhj?=
 =?utf-8?B?MmRWd3NWVzVDcVlWWEZkRDNpQlJ4bHVGcnZPdS9yTGFHT3pSbXNrWGRlTytW?=
 =?utf-8?B?dWM5QTh4aVZQSVRjSU1GTjBHUElrN2xmK2RnVTdGN3RTci9YTkJRUzNYeElv?=
 =?utf-8?B?ZndIOHhvRHJHcUxpTE55YUFiM1pQejBrdHlLRFc0UVRqMzZPeHRrTTk2MWZP?=
 =?utf-8?B?SkZaV1Y2OHpWZVNQL2x2TWJBYXlMMy96bU50TW1CSEpQVVM3YlpOK0RZOTVj?=
 =?utf-8?B?TVNPSjhjSi9UaUtjQTlxUm0wL1JPWk0vZmk1WHlrZnZSZlkyUnRKTW5ablZY?=
 =?utf-8?B?bkpHa0kwRyt6V0dBc01VemVkMm0zSGRTc2ZuYlZCU01jWHhPRmIvbFRtTUZx?=
 =?utf-8?B?L0hjbm0zUjQ5RTVVRGV2UkhEMFh6RC9seE1wNmxOVFE0VjRhcEhweVVSWElw?=
 =?utf-8?B?UlRuSTM2UDZTZzFyYUZMQmU1U1VDWVVDd01RWXJQSEtwckFpRTlSNEQrUEZK?=
 =?utf-8?B?NHFoYUJoSmhDaG50TmtSNHJzTEc5ZHR1QVdIZWQ5VXA1MG5IUW5Jdm1KVGJ2?=
 =?utf-8?B?cmpxeGhWTDFtN1FsQkpzd2JEMm56L2U0WW9WMWhxTkFnaVdtS3pyRWJoajB0?=
 =?utf-8?B?QmJ2bmEzTVdod1JWc25WUkVieGJqbU1OeHVOQjlML0ZVVWREN1g1QlVtNU5E?=
 =?utf-8?Q?apMJY7UgRLCrEmXdsjBqyRfvb?=
X-MS-Exchange-CrossTenant-Network-Message-Id: f6496497-0157-4434-0b3b-08db8fbb1eda
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3320.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jul 2023 22:36:44.4141
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: eCBnYYpoM3VWIVdlYhlbD2In4qWsrCoMOWmrIafg0nKEWmy6CDgQ1L/7QjWY79GuaiSWZvi81ZoQLt9BOFeNFA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7622
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

There is an extra semicolon at the end of the patch subject.

On 7/28/2023 5:12 AM, Thomas Gleixner wrote:
> APIC ID checks compare with BAD_APICID all over the place, but some
> initializers and some code which fiddles with global data structure use
> -1[U] instead. That simply cannot work at all.
> 
> Fix it up and use BAD_APICID consistenly all over the place.
> 

s/consistenly/consistently

-Sohil